mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 04:32:44 +01:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
26 lines
1.1 KiB
LLVM
26 lines
1.1 KiB
LLVM
; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s
|
|
; RUN: verify-uselistorder %s
|
|
|
|
; CHECK: !named = !{!0, !1, !2, !3, !4, !4, !5, !6, !7, !7}
|
|
!named = !{!0, !1, !2, !3, !4, !5, !6, !7, !8, !9}
|
|
|
|
!0 = distinct !{}
|
|
!1 = distinct !DISubprogram(name: "foo", scope: !2)
|
|
!2 = !DIFile(filename: "path/to/file", directory: "/path/to/dir")
|
|
|
|
; CHECK: !3 = !DILexicalBlock(scope: !1, file: !2, line: 7, column: 35)
|
|
!3 = !DILexicalBlock(scope: !1, file: !2, line: 7, column: 35)
|
|
|
|
; CHECK: !4 = !DILexicalBlock(scope: !1)
|
|
!4 = !DILexicalBlock(scope: !1)
|
|
!5 = !DILexicalBlock(scope: !1, file: null, line: 0, column: 0)
|
|
|
|
; CHECK: !5 = !DILexicalBlockFile(scope: !3, file: !2, discriminator: 0)
|
|
; CHECK: !6 = !DILexicalBlockFile(scope: !3, file: !2, discriminator: 1)
|
|
!6 = !DILexicalBlockFile(scope: !3, file: !2, discriminator: 0)
|
|
!7 = !DILexicalBlockFile(scope: !3, file: !2, discriminator: 1)
|
|
|
|
; CHECK: !7 = !DILexicalBlockFile(scope: !3, discriminator: 7)
|
|
!8 = !DILexicalBlockFile(scope: !3, discriminator: 7)
|
|
!9 = !DILexicalBlockFile(scope: !3, file: null, discriminator: 7)
|