mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 03:02:36 +01:00
ea9bf98c05
This patch adds the safe stack instrumentation pass to LLVM, which separates the program stack into a safe stack, which stores return addresses, register spills, and local variables that are statically verified to be accessed in a safe way, and the unsafe stack, which stores everything else. Such separation makes it much harder for an attacker to corrupt objects on the safe stack, including function pointers stored in spilled registers and return addresses. You can find more information about the safe stack, as well as other parts of or control-flow hijack protection technique in our OSDI paper on code-pointer integrity (http://dslab.epfl.ch/pubs/cpi.pdf) and our project website (http://levee.epfl.ch). The overhead of our implementation of the safe stack is very close to zero (0.01% on the Phoronix benchmarks). This is lower than the overhead of stack cookies, which are supported by LLVM and are commonly used today, yet the security guarantees of the safe stack are strictly stronger than stack cookies. In some cases, the safe stack improves performance due to better cache locality. Our current implementation of the safe stack is stable and robust, we used it to recompile multiple projects on Linux including Chromium, and we also recompiled the entire FreeBSD user-space system and more than 100 packages. We ran unit tests on the FreeBSD system and many of the packages and observed no errors caused by the safe stack. The safe stack is also fully binary compatible with non-instrumented code and can be applied to parts of a program selectively. This patch is our implementation of the safe stack on top of LLVM. The patches make the following changes: - Add the safestack function attribute, similar to the ssp, sspstrong and sspreq attributes. - Add the SafeStack instrumentation pass that applies the safe stack to all functions that have the safestack attribute. This pass moves all unsafe local variables to the unsafe stack with a separate stack pointer, whereas all safe variables remain on the regular stack that is managed by LLVM as usual. - Invoke the pass as the last stage before code generation (at the same time the existing cookie-based stack protector pass is invoked). - Add unit tests for the safe stack. Original patch by Volodymyr Kuznetsov and others at the Dependable Systems Lab at EPFL; updates and upstreaming by myself. Differential Revision: http://reviews.llvm.org/D6094 llvm-svn: 239761
51 lines
2.0 KiB
LLVM
51 lines
2.0 KiB
LLVM
; RUN: opt -safe-stack -S -mtriple=i386-pc-linux-gnu < %s -o - | FileCheck %s
|
|
; RUN: opt -safe-stack -S -mtriple=x86_64-pc-linux-gnu < %s -o - | FileCheck %s
|
|
|
|
%struct.small = type { i8 }
|
|
|
|
@.str = private unnamed_addr constant [4 x i8] c"%s\0A\00", align 1
|
|
|
|
; Address-of a structure taken in a function with a loop where
|
|
; the alloca is an incoming value to a PHI node and a use of that PHI
|
|
; node is also an incoming value.
|
|
; Verify that the address-of analysis does not get stuck in infinite
|
|
; recursion when chasing the alloca through the PHI nodes.
|
|
; Requires protector.
|
|
define i32 @foo(i32 %arg) nounwind uwtable safestack {
|
|
bb:
|
|
; CHECK: __safestack_unsafe_stack_ptr
|
|
%tmp = alloca %struct.small*, align 8
|
|
%tmp1 = call i32 (...) @dummy(%struct.small** %tmp) nounwind
|
|
%tmp2 = load %struct.small*, %struct.small** %tmp, align 8
|
|
%tmp3 = ptrtoint %struct.small* %tmp2 to i64
|
|
%tmp4 = trunc i64 %tmp3 to i32
|
|
%tmp5 = icmp sgt i32 %tmp4, 0
|
|
br i1 %tmp5, label %bb6, label %bb21
|
|
|
|
bb6: ; preds = %bb17, %bb
|
|
%tmp7 = phi %struct.small* [ %tmp19, %bb17 ], [ %tmp2, %bb ]
|
|
%tmp8 = phi i64 [ %tmp20, %bb17 ], [ 1, %bb ]
|
|
%tmp9 = phi i32 [ %tmp14, %bb17 ], [ %tmp1, %bb ]
|
|
%tmp10 = getelementptr inbounds %struct.small, %struct.small* %tmp7, i64 0, i32 0
|
|
%tmp11 = load i8, i8* %tmp10, align 1
|
|
%tmp12 = icmp eq i8 %tmp11, 1
|
|
%tmp13 = add nsw i32 %tmp9, 8
|
|
%tmp14 = select i1 %tmp12, i32 %tmp13, i32 %tmp9
|
|
%tmp15 = trunc i64 %tmp8 to i32
|
|
%tmp16 = icmp eq i32 %tmp15, %tmp4
|
|
br i1 %tmp16, label %bb21, label %bb17
|
|
|
|
bb17: ; preds = %bb6
|
|
%tmp18 = getelementptr inbounds %struct.small*, %struct.small** %tmp, i64 %tmp8
|
|
%tmp19 = load %struct.small*, %struct.small** %tmp18, align 8
|
|
%tmp20 = add i64 %tmp8, 1
|
|
br label %bb6
|
|
|
|
bb21: ; preds = %bb6, %bb
|
|
%tmp22 = phi i32 [ %tmp1, %bb ], [ %tmp14, %bb6 ]
|
|
%tmp23 = call i32 (...) @dummy(i32 %tmp22) nounwind
|
|
ret i32 undef
|
|
}
|
|
|
|
declare i32 @dummy(...)
|