mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
233ed83478
Summary: Targets often have instructions that can sign-extend certain cases faster than the equivalent shift-left/arithmetic-shift-right. Such cases can be identified by matching a shift-left/shift-right pair but there are some issues with this in the context of combines. For example, suppose you can sign-extend 8-bit up to 32-bit with a target extend instruction. %1:_(s32) = G_SHL %0:_(s32), i32 24 # (I've inlined the G_CONSTANT for brevity) %2:_(s32) = G_ASHR %1:_(s32), i32 24 %3:_(s32) = G_ASHR %2:_(s32), i32 1 would reasonably combine to: %1:_(s32) = G_SHL %0:_(s32), i32 24 %2:_(s32) = G_ASHR %1:_(s32), i32 25 which no longer matches the special case. If your shifts and extend are equal cost, this would break even as a pair of shifts but if your shift is more expensive than the extend then it's cheaper as: %2:_(s32) = G_SEXT_INREG %0:_(s32), i32 8 %3:_(s32) = G_ASHR %2:_(s32), i32 1 It's possible to match the shift-pair in ISel and emit an extend and ashr. However, this is far from the only way to break this shift pair and make it hard to match the extends. Another example is that with the right known-zeros, this: %1:_(s32) = G_SHL %0:_(s32), i32 24 %2:_(s32) = G_ASHR %1:_(s32), i32 24 %3:_(s32) = G_MUL %2:_(s32), i32 2 can become: %1:_(s32) = G_SHL %0:_(s32), i32 24 %2:_(s32) = G_ASHR %1:_(s32), i32 23 All upstream targets have been configured to lower it to the current G_SHL,G_ASHR pair but will likely want to make it legal in some cases to handle their faster cases. To follow-up: Provide a way to legalize based on the constant. At the moment, I'm thinking that the best way to achieve this is to provide the MI in LegalityQuery but that opens the door to breaking core principles of the legalizer (legality is not context sensitive). That said, it's worth noting that looking at other instructions and acting on that information doesn't violate this principle in itself. It's only a violation if, at the end of legalization, a pass that checks legality without being able to see the context would say an instruction might not be legal. That's a fairly subtle distinction so to give a concrete example, saying %2 in: %1 = G_CONSTANT 16 %2 = G_SEXT_INREG %0, %1 is legal is in violation of that principle if the legality of %2 depends on %1 being constant and/or being 16. However, legalizing to either: %2 = G_SEXT_INREG %0, 16 or: %1 = G_CONSTANT 16 %2:_(s32) = G_SHL %0, %1 %3:_(s32) = G_ASHR %2, %1 depending on whether %1 is constant and 16 does not violate that principle since both outputs are genuinely legal. Reviewers: bogner, aditya_nandakumar, volkan, aemerson, paquette, arsenm Subscribers: sdardis, jvesely, wdng, nhaehnle, rovka, kristof.beyls, javed.absar, hiraditya, jrtc27, atanasyan, Petar.Avramovic, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D61289 llvm-svn: 368487 |
||
|---|---|---|
| .. | ||
| AsmParser | ||
| Disassembler | ||
| MCTargetDesc | ||
| TargetInfo | ||
| Utils | ||
| AArch64.h | ||
| AArch64.td | ||
| AArch64A53Fix835769.cpp | ||
| AArch64A57FPLoadBalancing.cpp | ||
| AArch64AdvSIMDScalarPass.cpp | ||
| AArch64AsmPrinter.cpp | ||
| AArch64BranchTargets.cpp | ||
| AArch64CallingConvention.cpp | ||
| AArch64CallingConvention.h | ||
| AArch64CallingConvention.td | ||
| AArch64CallLowering.cpp | ||
| AArch64CallLowering.h | ||
| AArch64CleanupLocalDynamicTLSPass.cpp | ||
| AArch64CollectLOH.cpp | ||
| AArch64CompressJumpTables.cpp | ||
| AArch64CondBrTuning.cpp | ||
| AArch64ConditionalCompares.cpp | ||
| AArch64ConditionOptimizer.cpp | ||
| AArch64DeadRegisterDefinitionsPass.cpp | ||
| AArch64ExpandImm.cpp | ||
| AArch64ExpandImm.h | ||
| AArch64ExpandPseudoInsts.cpp | ||
| AArch64FalkorHWPFFix.cpp | ||
| AArch64FastISel.cpp | ||
| AArch64FrameLowering.cpp | ||
| AArch64FrameLowering.h | ||
| AArch64GenRegisterBankInfo.def | ||
| AArch64InstrAtomics.td | ||
| AArch64InstrFormats.td | ||
| AArch64InstrInfo.cpp | ||
| AArch64InstrInfo.h | ||
| AArch64InstrInfo.td | ||
| AArch64InstructionSelector.cpp | ||
| AArch64ISelDAGToDAG.cpp | ||
| AArch64ISelLowering.cpp | ||
| AArch64ISelLowering.h | ||
| AArch64LegalizerInfo.cpp | ||
| AArch64LegalizerInfo.h | ||
| AArch64LoadStoreOptimizer.cpp | ||
| AArch64MachineFunctionInfo.h | ||
| AArch64MacroFusion.cpp | ||
| AArch64MacroFusion.h | ||
| AArch64MCInstLower.cpp | ||
| AArch64MCInstLower.h | ||
| AArch64PBQPRegAlloc.cpp | ||
| AArch64PBQPRegAlloc.h | ||
| AArch64PerfectShuffle.h | ||
| AArch64PfmCounters.td | ||
| AArch64PreLegalizerCombiner.cpp | ||
| AArch64PromoteConstant.cpp | ||
| AArch64RedundantCopyElimination.cpp | ||
| AArch64RegisterBankInfo.cpp | ||
| AArch64RegisterBankInfo.h | ||
| AArch64RegisterBanks.td | ||
| AArch64RegisterInfo.cpp | ||
| AArch64RegisterInfo.h | ||
| AArch64RegisterInfo.td | ||
| AArch64SchedA53.td | ||
| AArch64SchedA57.td | ||
| AArch64SchedA57WriteRes.td | ||
| AArch64SchedCyclone.td | ||
| AArch64SchedExynosM1.td | ||
| AArch64SchedExynosM3.td | ||
| AArch64SchedExynosM4.td | ||
| AArch64SchedFalkor.td | ||
| AArch64SchedFalkorDetails.td | ||
| AArch64SchedKryo.td | ||
| AArch64SchedKryoDetails.td | ||
| AArch64SchedPredExynos.td | ||
| AArch64SchedPredicates.td | ||
| AArch64SchedThunderX2T99.td | ||
| AArch64SchedThunderX.td | ||
| AArch64Schedule.td | ||
| AArch64SelectionDAGInfo.cpp | ||
| AArch64SelectionDAGInfo.h | ||
| AArch64SIMDInstrOpt.cpp | ||
| AArch64SpeculationHardening.cpp | ||
| AArch64StackOffset.h | ||
| AArch64StackTagging.cpp | ||
| AArch64StorePairSuppress.cpp | ||
| AArch64Subtarget.cpp | ||
| AArch64Subtarget.h | ||
| AArch64SVEInstrInfo.td | ||
| AArch64SystemOperands.td | ||
| AArch64TargetMachine.cpp | ||
| AArch64TargetMachine.h | ||
| AArch64TargetObjectFile.cpp | ||
| AArch64TargetObjectFile.h | ||
| AArch64TargetTransformInfo.cpp | ||
| AArch64TargetTransformInfo.h | ||
| CMakeLists.txt | ||
| LLVMBuild.txt | ||
| SVEInstrFormats.td | ||