mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 04:32:44 +01:00
b23e310c99
This is a patch that disables the poison-unsafe select -> and/or i1 folding. It has been blocking D72396 and also has been the source of a few miscompilations described in llvm.org/pr49688 . D99674 conditionally blocked this folding and successfully fixed the latter one. The former one was still blocked, and this patch addresses it. Note that a few test functions that has `_logical` suffix are now deoptimized. These are created by @nikic to check the impact of disabling this optimization by copying existing original functions and replacing and/or with select. I can see that most of these are poison-unsafe; they can be revived by introducing freeze instruction. I left comments at fcmp + select optimizations (or-fcmp.ll, and-fcmp.ll) because I think they are good targets for freeze fix. Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D101191
55 lines
1.9 KiB
LLVM
55 lines
1.9 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
|
|
; RUN: opt < %s -instcombine -S | FileCheck %s
|
|
|
|
; rdar://5771353
|
|
|
|
define float @test(float %x, x86_fp80 %y) nounwind readonly {
|
|
; CHECK-LABEL: @test(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[TMP67:%.*]] = fcmp uno x86_fp80 [[Y:%.*]], 0xK00000000000000000000
|
|
; CHECK-NEXT: [[TMP71:%.*]] = fcmp uno float [[X:%.*]], 0.000000e+00
|
|
; CHECK-NEXT: [[BOTHCOND:%.*]] = or i1 [[TMP67]], [[TMP71]]
|
|
; CHECK-NEXT: br i1 [[BOTHCOND]], label [[BB74:%.*]], label [[BB80:%.*]]
|
|
; CHECK: bb74:
|
|
; CHECK-NEXT: ret float 0.000000e+00
|
|
; CHECK: bb80:
|
|
; CHECK-NEXT: ret float 0.000000e+00
|
|
;
|
|
entry:
|
|
%tmp67 = fcmp uno x86_fp80 %y, 0xK00000000000000000000 ; <i1> [#uses=1]
|
|
%tmp71 = fcmp uno float %x, 0.000000e+00 ; <i1> [#uses=1]
|
|
%bothcond = or i1 %tmp67, %tmp71 ; <i1> [#uses=1]
|
|
br i1 %bothcond, label %bb74, label %bb80
|
|
|
|
bb74: ; preds = %entry
|
|
ret float 0.000000e+00
|
|
|
|
bb80: ; preds = %entry
|
|
ret float 0.000000e+00
|
|
}
|
|
|
|
define float @test_logical(float %x, x86_fp80 %y) nounwind readonly {
|
|
; CHECK-LABEL: @test_logical(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[TMP67:%.*]] = fcmp uno x86_fp80 [[Y:%.*]], 0xK00000000000000000000
|
|
; CHECK-NEXT: [[TMP71:%.*]] = fcmp uno float [[X:%.*]], 0.000000e+00
|
|
; CHECK-NEXT: [[BOTHCOND:%.*]] = select i1 [[TMP67]], i1 true, i1 [[TMP71]]
|
|
; CHECK-NEXT: br i1 [[BOTHCOND]], label [[BB74:%.*]], label [[BB80:%.*]]
|
|
; CHECK: bb74:
|
|
; CHECK-NEXT: ret float 0.000000e+00
|
|
; CHECK: bb80:
|
|
; CHECK-NEXT: ret float 0.000000e+00
|
|
;
|
|
entry:
|
|
%tmp67 = fcmp uno x86_fp80 %y, 0xK00000000000000000000 ; <i1> [#uses=1]
|
|
%tmp71 = fcmp uno float %x, 0.000000e+00 ; <i1> [#uses=1]
|
|
%bothcond = select i1 %tmp67, i1 true, i1 %tmp71 ; <i1> [#uses=1]
|
|
br i1 %bothcond, label %bb74, label %bb80
|
|
|
|
bb74: ; preds = %entry
|
|
ret float 0.000000e+00
|
|
|
|
bb80: ; preds = %entry
|
|
ret float 0.000000e+00
|
|
}
|