mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
846be29e5e
Recommit r352791 after tweaking DerivedTypes.h slightly, so that gcc doesn't choke on it, hopefully. Original Message: The FunctionCallee type is effectively a {FunctionType*,Value*} pair, and is a useful convenience to enable code to continue passing the result of getOrInsertFunction() through to EmitCall, even once pointer types lose their pointee-type. Then: - update the CallInst/InvokeInst instruction creation functions to take a Callee, - modify getOrInsertFunction to return FunctionCallee, and - update all callers appropriately. One area of particular note is the change to the sanitizer code. Previously, they had been casting the result of `getOrInsertFunction` to a `Function*` via `checkSanitizerInterfaceFunction`, and storing that. That would report an error if someone had already inserted a function declaraction with a mismatching signature. However, in general, LLVM allows for such mismatches, as `getOrInsertFunction` will automatically insert a bitcast if needed. As part of this cleanup, cause the sanitizer code to do the same. (It will call its functions using the expected signature, however they may have been declared.) Finally, in a small number of locations, callers of `getOrInsertFunction` actually were expecting/requiring that a brand new function was being created. In such cases, I've switched them to Function::Create instead. Differential Revision: https://reviews.llvm.org/D57315 llvm-svn: 352827
195 lines
6.9 KiB
C++
195 lines
6.9 KiB
C++
//===- llvm/unittest/IR/VerifierTest.cpp - Verifier unit tests --*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/IR/Verifier.h"
|
|
#include "llvm/IR/Constants.h"
|
|
#include "llvm/IR/DIBuilder.h"
|
|
#include "llvm/IR/DerivedTypes.h"
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/IR/GlobalAlias.h"
|
|
#include "llvm/IR/GlobalVariable.h"
|
|
#include "llvm/IR/IRBuilder.h"
|
|
#include "llvm/IR/Instructions.h"
|
|
#include "llvm/IR/LLVMContext.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
namespace llvm {
|
|
namespace {
|
|
|
|
TEST(VerifierTest, Branch_i1) {
|
|
LLVMContext C;
|
|
Module M("M", C);
|
|
FunctionType *FTy = FunctionType::get(Type::getVoidTy(C), /*isVarArg=*/false);
|
|
Function *F = Function::Create(FTy, Function::ExternalLinkage, "foo", M);
|
|
BasicBlock *Entry = BasicBlock::Create(C, "entry", F);
|
|
BasicBlock *Exit = BasicBlock::Create(C, "exit", F);
|
|
ReturnInst::Create(C, Exit);
|
|
|
|
// To avoid triggering an assertion in BranchInst::Create, we first create
|
|
// a branch with an 'i1' condition ...
|
|
|
|
Constant *False = ConstantInt::getFalse(C);
|
|
BranchInst *BI = BranchInst::Create(Exit, Exit, False, Entry);
|
|
|
|
// ... then use setOperand to redirect it to a value of different type.
|
|
|
|
Constant *Zero32 = ConstantInt::get(IntegerType::get(C, 32), 0);
|
|
BI->setOperand(0, Zero32);
|
|
|
|
EXPECT_TRUE(verifyFunction(*F));
|
|
}
|
|
|
|
TEST(VerifierTest, InvalidRetAttribute) {
|
|
LLVMContext C;
|
|
Module M("M", C);
|
|
FunctionType *FTy = FunctionType::get(Type::getInt32Ty(C), /*isVarArg=*/false);
|
|
Function *F = Function::Create(FTy, Function::ExternalLinkage, "foo", M);
|
|
AttributeList AS = F->getAttributes();
|
|
F->setAttributes(
|
|
AS.addAttribute(C, AttributeList::ReturnIndex, Attribute::UWTable));
|
|
|
|
std::string Error;
|
|
raw_string_ostream ErrorOS(Error);
|
|
EXPECT_TRUE(verifyModule(M, &ErrorOS));
|
|
EXPECT_TRUE(StringRef(ErrorOS.str()).startswith(
|
|
"Attribute 'uwtable' only applies to functions!"));
|
|
}
|
|
|
|
TEST(VerifierTest, CrossModuleRef) {
|
|
LLVMContext C;
|
|
Module M1("M1", C);
|
|
Module M2("M2", C);
|
|
Module M3("M3", C);
|
|
FunctionType *FTy = FunctionType::get(Type::getInt32Ty(C), /*isVarArg=*/false);
|
|
Function *F1 = Function::Create(FTy, Function::ExternalLinkage, "foo1", M1);
|
|
Function *F2 = Function::Create(FTy, Function::ExternalLinkage, "foo2", M2);
|
|
Function *F3 = Function::Create(FTy, Function::ExternalLinkage, "foo3", M3);
|
|
|
|
BasicBlock *Entry1 = BasicBlock::Create(C, "entry", F1);
|
|
BasicBlock *Entry3 = BasicBlock::Create(C, "entry", F3);
|
|
|
|
// BAD: Referencing function in another module
|
|
CallInst::Create(F2,"call",Entry1);
|
|
|
|
// BAD: Referencing personality routine in another module
|
|
F3->setPersonalityFn(F2);
|
|
|
|
// Fill in the body
|
|
Constant *ConstZero = ConstantInt::get(Type::getInt32Ty(C), 0);
|
|
ReturnInst::Create(C, ConstZero, Entry1);
|
|
ReturnInst::Create(C, ConstZero, Entry3);
|
|
|
|
std::string Error;
|
|
raw_string_ostream ErrorOS(Error);
|
|
EXPECT_TRUE(verifyModule(M2, &ErrorOS));
|
|
EXPECT_TRUE(StringRef(ErrorOS.str())
|
|
.equals("Global is used by function in a different module\n"
|
|
"i32 ()* @foo2\n"
|
|
"; ModuleID = 'M2'\n"
|
|
"i32 ()* @foo3\n"
|
|
"; ModuleID = 'M3'\n"
|
|
"Global is referenced in a different module!\n"
|
|
"i32 ()* @foo2\n"
|
|
"; ModuleID = 'M2'\n"
|
|
" %call = call i32 @foo2()\n"
|
|
"i32 ()* @foo1\n"
|
|
"; ModuleID = 'M1'\n"));
|
|
|
|
Error.clear();
|
|
EXPECT_TRUE(verifyModule(M1, &ErrorOS));
|
|
EXPECT_TRUE(StringRef(ErrorOS.str()).equals(
|
|
"Referencing function in another module!\n"
|
|
" %call = call i32 @foo2()\n"
|
|
"; ModuleID = 'M1'\n"
|
|
"i32 ()* @foo2\n"
|
|
"; ModuleID = 'M2'\n"));
|
|
|
|
Error.clear();
|
|
EXPECT_TRUE(verifyModule(M3, &ErrorOS));
|
|
EXPECT_TRUE(StringRef(ErrorOS.str()).startswith(
|
|
"Referencing personality function in another module!"));
|
|
|
|
// Erase bad methods to avoid triggering an assertion failure on destruction
|
|
F1->eraseFromParent();
|
|
F3->eraseFromParent();
|
|
}
|
|
|
|
TEST(VerifierTest, InvalidVariableLinkage) {
|
|
LLVMContext C;
|
|
Module M("M", C);
|
|
new GlobalVariable(M, Type::getInt8Ty(C), false,
|
|
GlobalValue::LinkOnceODRLinkage, nullptr, "Some Global");
|
|
std::string Error;
|
|
raw_string_ostream ErrorOS(Error);
|
|
EXPECT_TRUE(verifyModule(M, &ErrorOS));
|
|
EXPECT_TRUE(
|
|
StringRef(ErrorOS.str()).startswith("Global is external, but doesn't "
|
|
"have external or weak linkage!"));
|
|
}
|
|
|
|
TEST(VerifierTest, InvalidFunctionLinkage) {
|
|
LLVMContext C;
|
|
Module M("M", C);
|
|
|
|
FunctionType *FTy = FunctionType::get(Type::getVoidTy(C), /*isVarArg=*/false);
|
|
Function::Create(FTy, GlobalValue::LinkOnceODRLinkage, "foo", &M);
|
|
std::string Error;
|
|
raw_string_ostream ErrorOS(Error);
|
|
EXPECT_TRUE(verifyModule(M, &ErrorOS));
|
|
EXPECT_TRUE(
|
|
StringRef(ErrorOS.str()).startswith("Global is external, but doesn't "
|
|
"have external or weak linkage!"));
|
|
}
|
|
|
|
TEST(VerifierTest, DetectInvalidDebugInfo) {
|
|
{
|
|
LLVMContext C;
|
|
Module M("M", C);
|
|
DIBuilder DIB(M);
|
|
DIB.createCompileUnit(dwarf::DW_LANG_C89, DIB.createFile("broken.c", "/"),
|
|
"unittest", false, "", 0);
|
|
DIB.finalize();
|
|
EXPECT_FALSE(verifyModule(M));
|
|
|
|
// Now break it by inserting non-CU node to the list of CUs.
|
|
auto *File = DIB.createFile("not-a-CU.f", ".");
|
|
NamedMDNode *NMD = M.getOrInsertNamedMetadata("llvm.dbg.cu");
|
|
NMD->addOperand(File);
|
|
EXPECT_TRUE(verifyModule(M));
|
|
}
|
|
{
|
|
LLVMContext C;
|
|
Module M("M", C);
|
|
DIBuilder DIB(M);
|
|
auto *CU = DIB.createCompileUnit(dwarf::DW_LANG_C89,
|
|
DIB.createFile("broken.c", "/"),
|
|
"unittest", false, "", 0);
|
|
new GlobalVariable(M, Type::getInt8Ty(C), false,
|
|
GlobalValue::ExternalLinkage, nullptr, "g");
|
|
|
|
auto *F = Function::Create(FunctionType::get(Type::getVoidTy(C), false),
|
|
Function::ExternalLinkage, "f", M);
|
|
IRBuilder<> Builder(BasicBlock::Create(C, "", F));
|
|
Builder.CreateUnreachable();
|
|
F->setSubprogram(DIB.createFunction(
|
|
CU, "f", "f", DIB.createFile("broken.c", "/"), 1, nullptr, 1,
|
|
DINode::FlagZero,
|
|
DISubprogram::SPFlagLocalToUnit | DISubprogram::SPFlagDefinition));
|
|
DIB.finalize();
|
|
EXPECT_FALSE(verifyModule(M));
|
|
|
|
// Now break it by not listing the CU at all.
|
|
M.eraseNamedMetadata(M.getOrInsertNamedMetadata("llvm.dbg.cu"));
|
|
EXPECT_TRUE(verifyModule(M));
|
|
}
|
|
}
|
|
|
|
} // end anonymous namespace
|
|
} // end namespace llvm
|