mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
bbf5be9d55
This adds infrastructure to print and parse MIR MachineOperand comments. The motivation for the ARM backend is to print condition code names instead of magic constants that are difficult to read (for human beings). For example, instead of this: dead renamable $r2, $cpsr = tEOR killed renamable $r2, renamable $r1, 14, $noreg t2Bcc %bb.4, 0, killed $cpsr we now print this: dead renamable $r2, $cpsr = tEOR killed renamable $r2, renamable $r1, 14 /* CC::always */, $noreg t2Bcc %bb.4, 0 /* CC:eq */, killed $cpsr This shows that MachineOperand comments are enclosed between /* and */. In this example, the EOR instruction is not conditionally executed (i.e. it is "always executed"), which is encoded by the 14 immediate machine operand. Thus, now this machine operand has /* CC::always */ as a comment. The 0 on the next conditional branch instruction represents the equal condition code, thus now this operand has /* CC:eq */ as a comment. As it is a comment, the MI lexer/parser completely ignores it. The benefit is that this keeps the change in the lexer extremely minimal and no target specific parsing needs to be done. The changes on the MIPrinter side are also minimal, as there is only one target hooks that is used to create the machine operand comments. Differential Revision: https://reviews.llvm.org/D74306
31 lines
1.2 KiB
YAML
31 lines
1.2 KiB
YAML
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
|
|
# RUN: llc -mtriple armv7-gnueabihf -run-pass instruction-select \
|
|
# RUN: -verify-machineinstrs -o - %s | FileCheck %s
|
|
---
|
|
# Test that we constrain register classes of temporary virtual registers
|
|
# defined by nested instructions built from a Dst Pattern
|
|
#
|
|
# G_FPTOSI selects to a (COPY_TO_REGCLASS (VTOSIZS SPR:$a), GPR), where
|
|
# COPY_TO_REGCLASS doesn't constrain its source register class. It exposes the
|
|
# bug as we create a tmp reg for VTOSIZS' result and don't constrain its
|
|
# register class as COPY_TO_REGCLASS' source (which is fine) nor as VTOSIZS'
|
|
# destination (which is not).
|
|
#
|
|
# https://bugs.llvm.org/show_bug.cgi?id=35965
|
|
name: test_fptosi
|
|
legalized: true
|
|
regBankSelected: true
|
|
body: |
|
|
bb.1:
|
|
; CHECK-LABEL: name: test_fptosi
|
|
; CHECK: [[COPY:%[0-9]+]]:spr = COPY $s0
|
|
; CHECK: [[VTOSIZS:%[0-9]+]]:spr = VTOSIZS [[COPY]], 14 /* CC::al */, $noreg
|
|
; CHECK: [[COPY1:%[0-9]+]]:gpr = COPY [[VTOSIZS]]
|
|
; CHECK: $r0 = COPY [[COPY1]]
|
|
; CHECK: MOVPCLR 14 /* CC::al */, $noreg, implicit $r0
|
|
%0:fprb(s32) = COPY $s0
|
|
%1:gprb(s32) = G_FPTOSI %0(s32)
|
|
$r0 = COPY %1(s32)
|
|
MOVPCLR 14, $noreg, implicit $r0
|
|
...
|