mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-21 12:02:58 +02:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
12 lines
449 B
LLVM
12 lines
449 B
LLVM
; RUN: llvm-dis < %s.bc | FileCheck %s
|
|
; Check that subprogram definitions are correctly upgraded to 'distinct'.
|
|
; Bitcode compiled from r245235 of the 3.7 release branch.
|
|
|
|
!named = !{!0}
|
|
!0 = distinct !DICompileUnit(language: 12, file: !1, subprograms: !2)
|
|
!1 = !DIFile(filename: "path/to/file", directory: "/path/to/dir")
|
|
!2 = !{!3}
|
|
|
|
; CHECK: = distinct !DISubprogram({{.*}}, isDefinition: true
|
|
!3 = !DISubprogram(name: "foo", isDefinition: true)
|