mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 04:32:44 +01:00
2a8b1d4992
units. This was debated back and forth a bunch, but using references is now clearly cleaner. Of all the code written using pointers thus far, in only one place did it really make more sense to have a pointer. In most cases, this just removes immediate dereferencing from the code. I think it is much better to get errors on null IR units earlier, potentially at compile time, than to delay it. Most notably, the legacy pass manager uses references for its routines and so as more and more code works with both, the use of pointers was likely to become really annoying. I noticed this when I ported the domtree analysis over and wrote the entire thing with references only to have it fail to compile. =/ It seemed better to switch now than to delay. We can, of course, revisit this is we learn that references are really problematic in the API. llvm-svn: 225145 |
||
---|---|---|
.. | ||
BitcodeWriter.cpp | ||
BitcodeWriterPass.cpp | ||
BitWriter.cpp | ||
CMakeLists.txt | ||
LLVMBuild.txt | ||
Makefile | ||
ValueEnumerator.cpp | ||
ValueEnumerator.h |