mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
48bac26038
LowerDbgDeclare inserts a dbg.value before each use of an address described by a dbg.declare. When inserting a dbg.value before a CallInst use, however, it fails to append DW_OP_deref to the DIExpression. The DW_OP_deref is needed to reflect the fact that a dbg.value describes a source variable directly (as opposed to a dbg.declare, which relies on pointer indirection). This patch adds in the DW_OP_deref where needed. This results in the correct values being shown during a debug session for a program compiled with ASan and optimizations (see https://reviews.llvm.org/D49520). Note that ConvertDebugDeclareToDebugValue is already correct -- no changes there were needed. One complication is that SelectionDAG is unable to distinguish between direct and indirect frame-index (FRAMEIX) SDDbgValues. This patch also fixes this long-standing issue in order to not regress integration tests relying on the incorrect assumption that all frame-index SDDbgValues are indirect. This is a necessary fix: the newly-added DW_OP_derefs cannot be lowered properly otherwise. Basically the fix prevents a direct SDDbgValue with DIExpression(DW_OP_deref) from being dereferenced twice by a debugger. There were a handful of tests relying on this incorrect "FRAMEIX => indirect" assumption which actually had incorrect DW_AT_locations: these are all fixed up in this patch. Testing: - check-llvm, and an end-to-end test using lldb to debug an optimized program. - Existing unit tests for DIExpression::appendToStack fully cover the new DIExpression::append utility. - check-debuginfo (the debug info integration tests) Differential Revision: https://reviews.llvm.org/D49454 llvm-svn: 338069
92 lines
3.2 KiB
LLVM
92 lines
3.2 KiB
LLVM
; RUN: llc -O1 -filetype=obj -o - %s | llvm-dwarfdump -all - | FileCheck %s
|
|
; Generated with -O1 from:
|
|
; int f1();
|
|
; void f2(int*);
|
|
; int f3(int);
|
|
;
|
|
; int foo() {
|
|
; int i = 3;
|
|
; f3(i);
|
|
; i = 7;
|
|
; i = f1();
|
|
; f2(&i);
|
|
; return 0;
|
|
; }
|
|
;
|
|
; Test that we generate valid debug info for optimized code,
|
|
; particularly variables that are described as constants and passed
|
|
; by reference.
|
|
; rdar://problem/14874886
|
|
;
|
|
; CHECK: .debug_info contents:
|
|
; CHECK: DW_TAG_variable
|
|
; CHECK-NOT: DW_TAG
|
|
; CHECK: DW_AT_location {{.*}}({{.*}}
|
|
; CHECK-NEXT: [0x{{0*.*}}, 0x[[C1:.*]]): DW_OP_consts +3
|
|
; CHECK-NEXT: [0x[[C1]], 0x[[C2:.*]]): DW_OP_consts +7
|
|
; CHECK-NEXT: [0x[[C2]], 0x[[R1:.*]]): DW_OP_reg0 RAX
|
|
; CHECK-NEXT: [0x[[R1]], 0x[[R2:.*]]): DW_OP_breg7 RSP+4)
|
|
; CHECK-NOT: DW_TAG
|
|
; CHECK: DW_AT_name{{.*}}"i"
|
|
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx10.9.0"
|
|
|
|
; Function Attrs: nounwind ssp uwtable
|
|
define i32 @foo() #0 !dbg !4 {
|
|
entry:
|
|
%i = alloca i32, align 4
|
|
call void @llvm.dbg.value(metadata i32 3, metadata !10, metadata !DIExpression()), !dbg !15
|
|
%call = call i32 @f3(i32 3) #3, !dbg !16
|
|
call void @llvm.dbg.value(metadata i32 7, metadata !10, metadata !DIExpression()), !dbg !18
|
|
%call1 = call i32 (...) @f1() #3, !dbg !19
|
|
call void @llvm.dbg.value(metadata i32 %call1, metadata !10, metadata !DIExpression()), !dbg !19
|
|
store i32 %call1, i32* %i, align 4, !dbg !19, !tbaa !20
|
|
call void @llvm.dbg.value(metadata i32* %i, metadata !10, metadata !DIExpression(DW_OP_deref)), !dbg !24
|
|
call void @f2(i32* %i) #3, !dbg !24
|
|
ret i32 0, !dbg !25
|
|
}
|
|
|
|
declare i32 @f3(i32)
|
|
|
|
declare i32 @f1(...)
|
|
|
|
declare void @f2(i32*)
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare void @llvm.dbg.value(metadata, metadata, metadata) #2
|
|
|
|
attributes #0 = { nounwind ssp uwtable }
|
|
attributes #2 = { nounwind readnone }
|
|
attributes #3 = { nounwind }
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!11, !12}
|
|
!llvm.ident = !{!13}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 3.5.0 ", isOptimized: true, emissionKind: FullDebug, file: !1, enums: !2, retainedTypes: !2, globals: !2, imports: !2)
|
|
!1 = !DIFile(filename: "dbg-value-const-byref.c", directory: "")
|
|
!2 = !{}
|
|
!4 = distinct !DISubprogram(name: "foo", line: 5, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: true, unit: !0, scopeLine: 5, file: !1, scope: !5, type: !6, retainedNodes: !9)
|
|
!5 = !DIFile(filename: "dbg-value-const-byref.c", directory: "")
|
|
!6 = !DISubroutineType(types: !7)
|
|
!7 = !{!8}
|
|
!8 = !DIBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!9 = !{!10}
|
|
!10 = !DILocalVariable(name: "i", line: 6, scope: !4, file: !5, type: !8)
|
|
!11 = !{i32 2, !"Dwarf Version", i32 2}
|
|
!12 = !{i32 1, !"Debug Info Version", i32 3}
|
|
!13 = !{!"clang version 3.5.0 "}
|
|
!14 = !{i32 3}
|
|
!15 = !DILocation(line: 6, scope: !4)
|
|
!16 = !DILocation(line: 7, scope: !4)
|
|
!17 = !{i32 7}
|
|
!18 = !DILocation(line: 8, scope: !4)
|
|
!19 = !DILocation(line: 9, scope: !4)
|
|
!20 = !{!21, !21, i64 0}
|
|
!21 = !{!"int", !22, i64 0}
|
|
!22 = !{!"omnipotent char", !23, i64 0}
|
|
!23 = !{!"Simple C/C++ TBAA"}
|
|
!24 = !DILocation(line: 10, scope: !4)
|
|
!25 = !DILocation(line: 11, scope: !4)
|