mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
f717458fdf
Sometimes you want to disable a FileCheck directive without removing it entirely, or you want to write comments that mention a directive by name. The `COM:` directive makes it easy to do this. For example, you might have: ``` ; X32: pinsrd_1: ; X32: pinsrd $1, 4(%esp), %xmm0 ; COM: FIXME: X64 isn't working correctly yet for this part of codegen, but ; COM: X64 will have something similar to X32: ; COM: ; COM: X64: pinsrd_1: ; COM: X64: pinsrd $1, %edi, %xmm0 ``` Without this patch, you need to use some combination of rewording and directive syntax mangling to prevent FileCheck from recognizing the commented occurrences of `X32:` and `X64:` above as directives. Moreover, FileCheck diagnostics have been proposed that might complain about the occurrences of `X64` that don't have the trailing `:` because they look like directive typos: <http://lists.llvm.org/pipermail/llvm-dev/2020-April/140610.html> I think dodging all these problems can prove tedious for test authors, and directive syntax mangling already makes the purpose of existing test code unclear. `COM:` can avoid all these problems. This patch also updates the small set of existing tests that define `COM` as a check prefix: - clang/test/CodeGen/default-address-space.c - clang/test/CodeGenOpenCL/addr-space-struct-arg.cl - clang/test/Driver/hip-device-libs.hip - llvm/test/Assembler/drop-debug-info-nonzero-alloca.ll I think lit should support `COM:` as well. Perhaps `clang -verify` should too. Reviewed By: jhenderson, thopre Differential Revision: https://reviews.llvm.org/D79276
49 lines
3.0 KiB
Plaintext
49 lines
3.0 KiB
Plaintext
# Bad comment prefixes are diagnosed.
|
|
|
|
# Check empty comment prefix.
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes= | \
|
|
RUN: FileCheck -check-prefix=PREFIX-EMPTY %s
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes=,FOO | \
|
|
RUN: FileCheck -check-prefix=PREFIX-EMPTY %s
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes=FOO, | \
|
|
RUN: FileCheck -check-prefix=PREFIX-EMPTY %s
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes=FOO,,BAR | \
|
|
RUN: FileCheck -check-prefix=PREFIX-EMPTY %s
|
|
PREFIX-EMPTY: error: supplied comment prefix must not be the empty string
|
|
|
|
# Check invalid characters in comment prefix.
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes=. | \
|
|
RUN: FileCheck -check-prefix=PREFIX-BAD-CHAR1 %s
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes='foo ' | \
|
|
RUN: FileCheck -check-prefix=PREFIX-BAD-CHAR2 %s
|
|
PREFIX-BAD-CHAR1: error: supplied comment prefix must start with a letter and contain only alphanumeric characters, hyphens, and underscores: '.'
|
|
PREFIX-BAD-CHAR2: error: supplied comment prefix must start with a letter and contain only alphanumeric characters, hyphens, and underscores: 'foo '
|
|
|
|
# Check duplicate comment prefixes.
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes=FOO,BAR,BAZ,BAR | \
|
|
RUN: FileCheck -check-prefix=COMMENT-PREFIX-DUP %s
|
|
COMMENT-PREFIX-DUP: error: supplied comment prefix must be unique among check and comment prefixes: 'BAR'
|
|
|
|
# Check user-supplied check prefix that duplicates a default comment prefix.
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -check-prefixes=FOO,COM | \
|
|
RUN: FileCheck -check-prefix=CHECK-PREFIX-DUP-COM %s
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -check-prefixes=RUN,FOO | \
|
|
RUN: FileCheck -check-prefix=CHECK-PREFIX-DUP-RUN_ %s
|
|
CHECK-PREFIX-DUP-COM: error: supplied check prefix must be unique among check and comment prefixes: 'COM'
|
|
CHECK-PREFIX-DUP-RUN_: error: supplied check prefix must be unique among check and comment prefixes: 'RUN'
|
|
|
|
# Check user-supplied comment prefix that duplicates default check prefixes.
|
|
RUN: %ProtectFileCheckOutput not FileCheck /dev/null < /dev/null 2>&1 \
|
|
RUN: -comment-prefixes=CHECK | \
|
|
RUN: FileCheck -check-prefix=COMMENT-PREFIX-DUP-CHECK %s
|
|
COMMENT-PREFIX-DUP-CHECK: error: supplied comment prefix must be unique among check and comment prefixes: 'CHECK'
|