mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 10:42:39 +01:00
683bdb08a0
When a nodeduplicate COMDAT group contains a weak symbol, choose a non-weak symbol (or one of the weak ones) rather than reporting an error. This should address issue PR51394. With the current IR representation, a generic comdat nodeduplicate semantics is not representable for LTO. In the linker, sections and symbols are separate concepts. A dropped weak symbol does not force the defining input section to be dropped as well (though it can be collected by GC). In the IR, when a weak linkage symbol is dropped, its associate section content is dropped as well. For InstrProfiling, which is where ran into this issue in PR51394, the deduplication semantic is a sufficient workaround. Differential Revision: https://reviews.llvm.org/D108689
15 lines
527 B
LLVM
15 lines
527 B
LLVM
; RUN: split-file %s %t.dir
|
|
; RUN: not llvm-link %t.dir/global.ll %t.dir/global.ll -S -o - 2>&1 | FileCheck %s
|
|
; RUN: llvm-link %t.dir/global.ll %t.dir/weak.ll -S -o - 2>&1
|
|
; RUN: llvm-link %t.dir/weak.ll %t.dir/global.ll -S -o - 2>&1
|
|
; RUN: llvm-link %t.dir/weak.ll %t.dir/weak.ll -S -o - 2>&1
|
|
|
|
;--- global.ll
|
|
$foo = comdat nodeduplicate
|
|
@foo = global i64 43, comdat($foo)
|
|
; CHECK: Linking COMDATs named 'foo': nodeduplicate has been violated!
|
|
|
|
;--- weak.ll
|
|
$foo = comdat nodeduplicate
|
|
@foo = weak global i64 43, comdat($foo)
|