mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
bae1c75f0d
For context, the proposed RISC-V bit manipulation extension has a subset of instructions which require one of two SubtargetFeatures to be enabled, 'zbb' or 'zbp', and there is no defined feature which both of these can imply to use as a constraint either (see comments in D65649). AssemblerPredicates allow multiple SubtargetFeatures to be declared in the "AssemblerCondString" field, separated by commas, and this means that the two features must both be enabled. There is no equivalent to say that _either_ feature X or feature Y must be enabled, short of creating a dummy SubtargetFeature for this purpose and having features X and Y imply the new feature. To solve the case where X or Y is needed without adding a new feature, and to better match a typical TableGen style, this replaces the existing "AssemblerCondString" with a dag "AssemblerCondDag" which represents the same information. Two operators are defined for use with AssemblerCondDag, "all_of", which matches the current behaviour, and "any_of", which adds the new proposed ORing features functionality. This was originally proposed in the RFC at http://lists.llvm.org/pipermail/llvm-dev/2020-February/139138.html Changes to all current backends are mechanical to support the replaced functionality, and are NFCI. At this stage, it is illegal to combine features with ands and ors in a single AssemblerCondDag. I suspect this case is sufficiently rare that adding more complex changes to support it are unnecessary. Differential Revision: https://reviews.llvm.org/D74338
105 lines
4.3 KiB
TableGen
105 lines
4.3 KiB
TableGen
// RUN: llvm-tblgen -gen-disassembler -I %p/../../include %s | \
|
|
// RUN: FileCheck --check-prefix=DISASS %s
|
|
// RUN: llvm-tblgen -gen-asm-matcher -I %p/../../include %s | \
|
|
// RUN: FileCheck --check-prefix=MATCHER %s
|
|
// RUN: llvm-tblgen -gen-asm-writer -I %p/../../include %s | \
|
|
// RUN: FileCheck --check-prefix=WRITER %s
|
|
|
|
// Check that combining conditions in AssemblerPredicate generates the correct
|
|
// output when using both the (all_of) AND operator, and the (any_of) OR
|
|
// operator.
|
|
|
|
include "llvm/Target/Target.td"
|
|
|
|
def archInstrInfo : InstrInfo { }
|
|
def archAsmWriter : AsmWriter {
|
|
int PassSubtarget = 1;
|
|
}
|
|
|
|
def arch : Target {
|
|
let InstructionSet = archInstrInfo;
|
|
let AssemblyWriters = [archAsmWriter];
|
|
}
|
|
|
|
let Namespace = "arch" in {
|
|
def R0 : Register<"r0">;
|
|
def R1 : Register<"r1">;
|
|
def R2 : Register<"r2">;
|
|
def R3 : Register<"r3">;
|
|
def R4 : Register<"r4">;
|
|
}
|
|
def Regs : RegisterClass<"Regs", [i32], 32, (add R0, R1, R2, R3, R4)>;
|
|
|
|
class TestInsn<int Opc, list<Predicate> Preds> : Instruction {
|
|
let Size = 2;
|
|
let OutOperandList = (outs);
|
|
let InOperandList = (ins Regs:$r);
|
|
field bits<16> Inst;
|
|
let Inst = Opc;
|
|
let AsmString = NAME # " $r";
|
|
field bits<16> SoftFail = 0;
|
|
let Predicates = Preds;
|
|
}
|
|
|
|
|
|
def AsmCond1 : SubtargetFeature<"cond1", "cond1", "true", "">;
|
|
def AsmCond2a: SubtargetFeature<"cond2a", "cond2a", "true", "">;
|
|
def AsmCond2b: SubtargetFeature<"cond2b", "cond2b", "true", "">;
|
|
def AsmCond3a: SubtargetFeature<"cond3a", "cond3a", "true", "">;
|
|
def AsmCond3b: SubtargetFeature<"cond3b", "cond3b", "true", "">;
|
|
|
|
def AsmPred1 : Predicate<"Pred1">, AssemblerPredicate<(all_of AsmCond1)>;
|
|
def AsmPred2 : Predicate<"Pred2">, AssemblerPredicate<(all_of AsmCond2a, AsmCond2b)>;
|
|
def AsmPred3 : Predicate<"Pred3">, AssemblerPredicate<(any_of AsmCond3a, AsmCond3b)>;
|
|
// MATCHER: if (FB[arch::AsmCond1])
|
|
// MATCHER-NEXT: Features.set(Feature_AsmPred1Bit);
|
|
// MATCHER-NEXT: if (FB[arch::AsmCond2a] && FB[arch::AsmCond2b])
|
|
// MATCHER-NEXT: Features.set(Feature_AsmPred2Bit);
|
|
// MATCHER-NEXT: if ((FB[arch::AsmCond3a] || FB[arch::AsmCond3b]))
|
|
// MATCHER-NEXT: Features.set(Feature_AsmPred3Bit);
|
|
|
|
def insn1 : TestInsn<1, [AsmPred1]>;
|
|
// DISASS: return (Bits[arch::AsmCond1]);
|
|
|
|
def insn2 : TestInsn<2, [AsmPred2]>;
|
|
// DISASS: return (Bits[arch::AsmCond2a] && Bits[arch::AsmCond2b])
|
|
|
|
def insn3 : TestInsn<3, [AsmPred3]>;
|
|
// DISASS: return ((Bits[arch::AsmCond3a] || Bits[arch::AsmCond3b]))
|
|
|
|
def insn4 : TestInsn<4, [AsmPred1, AsmPred2]>;
|
|
// DISASS: return (Bits[arch::AsmCond1] && Bits[arch::AsmCond2a] && Bits[arch::AsmCond2b])
|
|
|
|
def insn5 : TestInsn<5, [AsmPred1, AsmPred3]>;
|
|
// DISASS: return (Bits[arch::AsmCond1] && (Bits[arch::AsmCond3a] || Bits[arch::AsmCond3b]))
|
|
|
|
def insn6 : TestInsn<6, []>;
|
|
def : InstAlias<"alias1", (insn6 R0)> { let Predicates = [AsmPred1]; }
|
|
// WRITER: // (insn6 R0)
|
|
// WRITER-NEXT: {AliasPatternCond::K_Reg, arch::R0},
|
|
// WRITER-NEXT: {AliasPatternCond::K_Feature, arch::AsmCond1},
|
|
def : InstAlias<"alias2", (insn6 R1)> { let Predicates = [AsmPred2]; }
|
|
// WRITER: // (insn6 R1)
|
|
// WRITER-NEXT: {AliasPatternCond::K_Reg, arch::R1},
|
|
// WRITER-NEXT: {AliasPatternCond::K_Feature, arch::AsmCond2a},
|
|
// WRITER-NEXT: {AliasPatternCond::K_Feature, arch::AsmCond2b},
|
|
def : InstAlias<"alias3", (insn6 R2)> { let Predicates = [AsmPred3]; }
|
|
// WRITER: // (insn6 R2)
|
|
// WRITER-NEXT: {AliasPatternCond::K_Reg, arch::R2},
|
|
// WRITER-NEXT: {AliasPatternCond::K_OrFeature, arch::AsmCond3a},
|
|
// WRITER-NEXT: {AliasPatternCond::K_OrFeature, arch::AsmCond3b},
|
|
// WRITER-NEXT: {AliasPatternCond::K_EndOrFeatures, 0},
|
|
def : InstAlias<"alias4", (insn6 R3)> { let Predicates = [AsmPred1, AsmPred2]; }
|
|
// WRITER: // (insn6 R3)
|
|
// WRITER-NEXT: {AliasPatternCond::K_Reg, arch::R3},
|
|
// WRITER-NEXT: {AliasPatternCond::K_Feature, arch::AsmCond1},
|
|
// WRITER-NEXT: {AliasPatternCond::K_Feature, arch::AsmCond2a},
|
|
// WRITER-NEXT: {AliasPatternCond::K_Feature, arch::AsmCond2b},
|
|
def : InstAlias<"alias5", (insn6 R4)> { let Predicates = [AsmPred1, AsmPred3]; }
|
|
// WRITER: // (insn6 R4)
|
|
// WRITER-NEXT: {AliasPatternCond::K_Reg, arch::R4},
|
|
// WRITER-NEXT: {AliasPatternCond::K_Feature, arch::AsmCond1},
|
|
// WRITER-NEXT: {AliasPatternCond::K_OrFeature, arch::AsmCond3a},
|
|
// WRITER-NEXT: {AliasPatternCond::K_OrFeature, arch::AsmCond3b},
|
|
// WRITER-NEXT: {AliasPatternCond::K_EndOrFeatures, 0},
|