mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
0febb42ed0
Summary: The WebAssembly backend automatically lowers atomic operations and TLS to nonatomic operations and non-TLS data when either are present and the atomics or bulk-memory features are not present, respectively. The resulting object is no longer thread-safe, so the linker has to be told not to allow it to be linked into a module with shared memory. This was previously done by disallowing the 'atomics' feature, which prevented any objct with its atomic operations or TLS removed from being linked with any object containing atomics or TLS, and therefore preventing it from being linked into a module with shared memory since shared memory requires atomics. However, as of https://github.com/WebAssembly/threads/issues/144, the validation rules are relaxed to allow atomic operations to validate with unshared memories, which makes it perfectly safe to link an object with stripped atomics and TLS with another object that still contains TLS and atomics as long as the resulting module has an unshared memory. To allow this kind of link, this patch disallows a pseudo-feature 'shared-mem' rather than 'atomics' to communicate to the linker that the object is not thread-safe. This means that the 'atomics' feature is available to accurately reflect whether or not an object has atomics enabled. As a drive-by tweak, this change also requires that bulk-memory be enabled in addition to atomics in order to use shared memory. This is because initializing shared memories requires bulk-memory operations. Reviewers: aheejin, sbc100 Subscribers: dschuff, jgravelle-google, hiraditya, sunfish, jfb, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79542
27 lines
882 B
LLVM
27 lines
882 B
LLVM
; RUN: llc < %s -mattr=-bulk-memory | FileCheck %s --check-prefixes NO-BULK-MEM
|
|
; RUN: llc < %s -mattr=+bulk-memory | FileCheck %s --check-prefixes BULK-MEM
|
|
|
|
; Test that the target features section contains -atomics or +atomics
|
|
; for modules that have thread local storage in their source.
|
|
|
|
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
|
|
target triple = "wasm32-unknown-unknown"
|
|
|
|
@foo = internal thread_local global i32 0
|
|
|
|
; -bulk-memory
|
|
; NO-BULK-MEM-LABEL: .custom_section.target_features,"",@
|
|
; NO-BULK-MEM-NEXT: .int8 1
|
|
; NO-BULK-MEM-NEXT: .int8 45
|
|
; NO-BULK-MEM-NEXT: .int8 10
|
|
; NO-BULK-MEM-NEXT: .ascii "shared-mem"
|
|
; NO-BULK-MEM-NEXT: .bss.foo,"",@
|
|
|
|
; +bulk-memory
|
|
; BULK-MEM-LABEL: .custom_section.target_features,"",@
|
|
; BULK-MEM-NEXT: .int8 1
|
|
; BULK-MEM-NEXT: .int8 43
|
|
; BULK-MEM-NEXT: .int8 11
|
|
; BULK-MEM-NEXT: .ascii "bulk-memory"
|
|
; BULK-MEM-NEXT: .tbss.foo,"",@
|