mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
1f9320a4cd
Summary: This patch is part of 3 patches that together form a single patch, but must be introduced in stages in order not to break things. The way that LLVM interprets DW_OP_plus in DIExpression nodes is basically that of the DW_OP_plus_uconst operator since LLVM expects an unsigned constant operand. This unnecessarily restricts the DW_OP_plus operator, preventing it from being used to describe the evaluation of runtime values on the expression stack. These patches try to align the semantics of DW_OP_plus and DW_OP_minus with that of the DWARF definition, which pops two elements off the expression stack, performs the operation and pushes the result back on the stack. This is done in three stages: • The first patch (LLVM) adds support for DW_OP_plus_uconst. • The second patch (Clang) contains changes all its uses from DW_OP_plus to DW_OP_plus_uconst. • The third patch (LLVM) changes the semantics of DW_OP_plus and DW_OP_minus to be in line with its DWARF meaning. This patch includes the bitcode upgrade from legacy DIExpressions. Patch by Sander de Smalen. Reviewers: echristo, pcc, aprantl Reviewed By: aprantl Subscribers: fhahn, javed.absar, aprantl, llvm-commits Differential Revision: https://reviews.llvm.org/D33894 llvm-svn: 305386
40 lines
2.3 KiB
LLVM
40 lines
2.3 KiB
LLVM
; RUN: llvm-dis -o - %s.bc | FileCheck %s
|
|
; RUN: llvm-dis -o - %s.bc | llvm-as - | llvm-bcanalyzer -dump - | FileCheck %s --check-prefix=BC
|
|
|
|
; BC: GLOBAL_VAR_EXPR
|
|
; BC: GLOBAL_DECL_ATTACHMENT
|
|
; CHECK: @g = common global i32 0, align 4, !dbg ![[G:[0-9]+]]
|
|
; CHECK: @h = common global i32 0, align 4, !dbg ![[H:[0-9]+]]
|
|
; CHECK: ![[G]] = {{.*}}!DIGlobalVariableExpression(var: ![[GVAR:[0-9]+]], expr: ![[GEXPR:[0-9]+]])
|
|
; CHECK: ![[GVAR]] = distinct !DIGlobalVariable(name: "g",
|
|
; CHECK: DICompileUnit({{.*}}, imports: ![[IMPORTS:[0-9]+]]
|
|
; CHECK: !DIGlobalVariableExpression(var: ![[CVAR:[0-9]+]], expr: ![[CEXPR:[0-9]+]])
|
|
; CHECK: ![[CVAR]] = distinct !DIGlobalVariable(name: "c",
|
|
; CHECK: ![[CEXPR]] = !DIExpression(DW_OP_constu, 23, DW_OP_stack_value)
|
|
; CHECK: ![[HVAR:[0-9]+]] = distinct !DIGlobalVariable(name: "h",
|
|
; CHECK: ![[IMPORTS]] = !{![[CIMPORT:[0-9]+]]}
|
|
; CHECK: ![[CIMPORT]] = !DIImportedEntity({{.*}}entity: ![[HVAR]]
|
|
; CHECK: ![[GEXPR]] = !DIExpression(DW_OP_plus_uconst, 1)
|
|
; CHECK: ![[H]] = {{.*}}!DIGlobalVariableExpression(var: ![[HVAR]])
|
|
|
|
@g = common global i32 0, align 4, !dbg !0
|
|
@h = common global i32 0, align 4, !dbg !11
|
|
|
|
!llvm.dbg.cu = !{!1}
|
|
!llvm.module.flags = !{!6, !7, !8}
|
|
!llvm.ident = !{!9}
|
|
|
|
!0 = distinct !DIGlobalVariable(name: "g", scope: !1, file: !2, line: 1, type: !5, isLocal: false, isDefinition: true, expr: !DIExpression(DW_OP_plus, 1))
|
|
!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, producer: "clang version 4.0.0 (trunk 286129) (llvm/trunk 286128)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, globals: !4, imports: !3)
|
|
!2 = !DIFile(filename: "a.c", directory: "/")
|
|
!3 = !{!12}
|
|
!4 = !{!0, !10, !11}
|
|
!5 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
!6 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!7 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!8 = !{i32 1, !"PIC Level", i32 2}
|
|
!9 = !{!"clang version 4.0.0 (trunk 286129) (llvm/trunk 286128)"}
|
|
!10 = distinct !DIGlobalVariable(name: "c", scope: !1, file: !2, line: 1, type: !5, isLocal: false, isDefinition: true, expr: !DIExpression(DW_OP_constu, 23, DW_OP_stack_value))
|
|
!11 = distinct !DIGlobalVariable(name: "h", scope: !1, file: !2, line: 2, type: !5, isLocal: false, isDefinition: true)
|
|
!12 = !DIImportedEntity(tag: DW_TAG_imported_declaration, line: 1, scope: !1, entity: !11)
|