mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
6587d6dd55
Reject the following IR as malformed (assuming that %entry, %next are
not in a loop):
next:
%y = phi i32 [ 0, %entry ]
%x = phi i32 [ %y, %entry ]
Such PHI nodes came up in PR26718. While there was no consensus on
whether or not this is valid IR, most opinions on that bug and in a
discussion on the llvm-dev mailing list tended towards a
"strict interpretation" (term by Joseph Tremoulet) of PHI node uses.
Also, the language reference explicitly states that "the use of each
incoming value is deemed to occur on the edge from the corresponding
predecessor block to the current block" and
`DominatorTree::dominates(Instruction*, Use&)` uses this definition as
well.
For the code mentioned in PR15384, clang does not compile to such PHIs
(anymore?). The test case still hangs when replacing `%tmp6` with `%tmp`
in revisions before r176366 (where PR15384 has been fixed). The
occurrence of %tmp6 therefore was probably unintentional. Its value is
not used except in other PHIs.
Reviewers: majnemer, reames, JosephTremoulet, bkramer, grosser, jdoerfert, kparzysz, sanjoy
Differential Revision: http://reviews.llvm.org/D18443
llvm-svn: 264528
71 lines
1.6 KiB
LLVM
71 lines
1.6 KiB
LLVM
; RUN: not llvm-as < %s -o /dev/null 2>&1 | FileCheck %s
|
|
|
|
define i32 @f1(i32 %x) {
|
|
%y = add i32 %z, 1
|
|
%z = add i32 %x, 1
|
|
ret i32 %y
|
|
; CHECK: Instruction does not dominate all uses!
|
|
; CHECK-NEXT: %z = add i32 %x, 1
|
|
; CHECK-NEXT: %y = add i32 %z, 1
|
|
}
|
|
|
|
declare i32 @g()
|
|
define void @f2(i32 %x) personality i32 ()* @g {
|
|
bb0:
|
|
%y1 = invoke i32 @g() to label %bb1 unwind label %bb2
|
|
bb1:
|
|
ret void
|
|
bb2:
|
|
%y2 = phi i32 [%y1, %bb0]
|
|
%y3 = landingpad i32
|
|
cleanup
|
|
ret void
|
|
; CHECK: Instruction does not dominate all uses!
|
|
; CHECK-NEXT: %y1 = invoke i32 @g()
|
|
; CHECK-NEXT: to label %bb1 unwind label %bb2
|
|
; CHECK-NEXT: %y2 = phi i32 [ %y1, %bb0 ]
|
|
}
|
|
|
|
define void @f3(i32 %x) personality i32 ()* @g {
|
|
bb0:
|
|
%y1 = invoke i32 @g() to label %bb1 unwind label %bb2
|
|
bb1:
|
|
ret void
|
|
bb2:
|
|
%y2 = landingpad i32
|
|
cleanup
|
|
br label %bb3
|
|
bb3:
|
|
%y3 = phi i32 [%y1, %bb2]
|
|
ret void
|
|
; CHECK: Instruction does not dominate all uses!
|
|
; CHECK-NEXT: %y1 = invoke i32 @g()
|
|
; CHECK-NEXT: to label %bb1 unwind label %bb2
|
|
; CHECK-NEXT: %y3 = phi i32 [ %y1, %bb2 ]
|
|
}
|
|
|
|
define void @f4(i32 %x) {
|
|
bb0:
|
|
br label %bb1
|
|
bb1:
|
|
%y3 = phi i32 [%y1, %bb0]
|
|
%y1 = add i32 %x, 1
|
|
ret void
|
|
; CHECK: Instruction does not dominate all uses!
|
|
; CHECK-NEXT: %y1 = add i32 %x, 1
|
|
; CHECK-NEXT: %y3 = phi i32 [ %y1, %bb0 ]
|
|
}
|
|
|
|
define void @f5() {
|
|
entry:
|
|
br label %next
|
|
|
|
next:
|
|
%y = phi i32 [ 0, %entry ]
|
|
%x = phi i32 [ %y, %entry ]
|
|
ret void
|
|
; CHECK: Instruction does not dominate all uses!
|
|
; CHECK-NEXT: %y = phi i32 [ 0, %entry ]
|
|
; CHECK-NEXT: %x = phi i32 [ %y, %entry ]
|
|
}
|