James Nagurne d728d4b4e8 [CMake] Prefer multi-target variables over generic target variables in runtimes build ... Runtimes variables in a multi-target environment are defined like: RUNTIMES_target_VARIABLE_NAME RUNTIMES_target+multi_VARIABLE_NAME In my case, I have a downstream runtimes cache that does the following: set(RUNTIMES_${target}+except_LIBCXXABI_ENABLE_EXCEPTIONS ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "") I found that I was always getting the 'target' variable value (OFF) in my 'target+except' build, which was unexpected. This behavior was caused by the loop in llvm/runtimes/CMakeLists.txt that runs through all variable names, adding '-DVARIABLE_NAME=' options to the subsequent external project's cmake command. The issue is that the loop does a single pass, such that if the 'target' value appears in the cache after the 'target+except' value, the 'target' value will take precedence. I suggest in my change here that the more specific 'target+except' value should take precedence always, without relying on CMake cache ordering. Differential Revision: https://reviews.llvm.org/D71570 Patch By: JamesNagurne		2020-01-17 15:18:18 -08:00
..
CMakeLists.txt	[CMake] Prefer multi-target variables over generic target variables in runtimes build	2020-01-17 15:18:18 -08:00
Components.cmake.in
llvm-strip-link.in	[runtime] Use --strip-all rather than --strip-sections	2019-03-10 04:26:54 +00:00