mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-20 03:23:01 +02:00
5033237287
Just aligning segment offsets to segment alignment is incorrect and also wastes more space than is needed. The requirement is that p_offset == p_addr modulo p_align *not* that p_offset == 0 modulo p_align. Generally speaking we've been using p_addr == 0 modulo p_align. In fact yaml2obj can't even produce a valid situation which causes llvm-objcopy to produce incorrect results because alignment and offset were both inherited from the sections the program header covers. This change fixes this bad behavior in llvm-objcopy. Differential Revision: https://reviews.llvm.org/D39132 llvm-svn: 317284
68 lines
1.7 KiB
Plaintext
68 lines
1.7 KiB
Plaintext
# RUN: yaml2obj %s -o %t
|
|
# RUN: llvm-objcopy %t %t2
|
|
# RUN: llvm-readobj -program-headers %t2 | FileCheck %s
|
|
|
|
!ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_EXEC
|
|
Machine: EM_X86_64
|
|
Sections:
|
|
- Name: .text
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
|
|
Address: 0x1000
|
|
AddressAlign: 0x0000000000001000
|
|
Content: "c3c3c3c3"
|
|
- Name: .data
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC ]
|
|
Address: 0x1008
|
|
AddressAlign: 0x0000000000000008
|
|
Content: "3232"
|
|
ProgramHeaders:
|
|
- Type: PT_LOAD
|
|
Flags: [ PF_X, PF_R ]
|
|
VAddr: 0x1000
|
|
PAddr: 0x1000
|
|
Align: 0x1000
|
|
Sections:
|
|
- Section: .text
|
|
- Type: PT_LOAD
|
|
Flags: [ PF_R, PF_W ]
|
|
VAddr: 0x1008
|
|
PAddr: 0x1008
|
|
Align: 0x1000
|
|
Sections:
|
|
- Section: .data
|
|
|
|
#CHECK: ProgramHeaders [
|
|
#CHECK-NEXT: ProgramHeader {
|
|
#CHECK-NEXT: Type: PT_LOAD
|
|
#CHECK-NEXT: Offset: 0x1000
|
|
#CHECK-NEXT: VirtualAddress: 0x1000
|
|
#CHECK-NEXT: PhysicalAddress: 0x1000
|
|
#CHECK-NEXT: FileSize: 4
|
|
#CHECK-NEXT: MemSize: 4
|
|
#CHECK-NEXT: Flags [
|
|
#CHECK-NEXT: PF_R
|
|
#CHECK-NEXT: PF_X
|
|
#CHECK-NEXT: ]
|
|
#CHECK-NEXT: Alignment: 4096
|
|
#CHECK-NEXT: }
|
|
#CHECK-NEXT: ProgramHeader {
|
|
#CHECK-NEXT: Type: PT_LOAD
|
|
#CHECK-NEXT: Offset: 0x1008
|
|
#CHECK-NEXT: VirtualAddress: 0x1008
|
|
#CHECK-NEXT: PhysicalAddress: 0x1008
|
|
#CHECK-NEXT: FileSize: 2
|
|
#CHECK-NEXT: MemSize: 2
|
|
#CHECK-NEXT: Flags [
|
|
#CHECK-NEXT: PF_R
|
|
#CHECK-NEXT: PF_W
|
|
#CHECK-NEXT: ]
|
|
#CHECK-NEXT: Alignment: 4096
|
|
#CHECK-NEXT: }
|
|
#CHECK-NEXT:]
|