mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
87135ac747
These symbols need to be external (MSVC tools error out if a weak external points at a symbol that isn't external; this was tried before but had to be reverted in bc5b7217dceecd3eec69593026a9e38dfbfd6908, and this was originally explicitly fixed in 732eeaf2a930ad2755cb4eb5d99a3deae0de4a72). If multiple object files have weak symbols with defaults, their defaults could cause linker errors due to duplicate definitions, unless the names of the defaults are unique. GNU binutils handles this by appending the name of another symbol from the same object file to the name of the default symbol. Try to implement something similar; before writing the object file, locate a symbol that should have a unique name and use the name of that one for making the weak defaults unique. Differential Revision: https://reviews.llvm.org/D75989
36 lines
1.2 KiB
ArmAsm
36 lines
1.2 KiB
ArmAsm
// RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -defsym case=0 -o %t.case0.o
|
|
// RUN: llvm-readobj --symbols %t.case0.o | FileCheck %s --check-prefix=CHECK-CASE0
|
|
// RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -defsym case=1 -o %t.case1.o
|
|
// RUN: llvm-readobj --symbols %t.case1.o | FileCheck %s --check-prefix=CHECK-CASE1
|
|
// RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -defsym case=2 -o %t.case2.o
|
|
// RUN: llvm-readobj --symbols %t.case2.o | FileCheck %s --check-prefix=CHECK-CASE2
|
|
|
|
// Test that we prefer a non-comdat symbol for naming weak default symbols,
|
|
// if such a symbol is available.
|
|
|
|
.section .text$comdat1,"xr",discard,comdat1
|
|
.globl comdat1
|
|
comdat1:
|
|
call undeffunc
|
|
|
|
.weak weaksym
|
|
|
|
.section .text$comdat2,"xr",discard,comdat2
|
|
.globl comdat2
|
|
comdat2:
|
|
call undeffunc2
|
|
|
|
.if case == 0
|
|
.text
|
|
.globl regular
|
|
regular:
|
|
call undeffunc3
|
|
.elseif case == 1
|
|
.globl abssym
|
|
abssym = 42
|
|
.endif
|
|
|
|
// CHECK-CASE0: Name: .weak.weaksym.default.regular
|
|
// CHECK-CASE1: Name: .weak.weaksym.default.abssym
|
|
// CHECK-CASE2: Name: .weak.weaksym.default.comdat1
|