mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-01 05:01:59 +01:00
f246100fbd
Summary: The following combine currently breaks in the DAGCombiner: ``` extract_vector_elt (concat_vectors v4i16:a, v4i16:b), x -> extract_vector_elt a, x ``` This happens because after we have combined these nodes we have inserted nodes that use individual instances of the vector element type. In the above example i16. However this isn't a legal type on all backends, and when the combining pass calls the legalizer it breaks as it expects types to already be legal. The type legalizer has already been run, and running it again would make a mess of the nodes. In the example code at least, the generated code is still efficient after the change. Reviewers: miyuki, arsenm, dmgreen, lebedev.ri Reviewed By: miyuki, lebedev.ri Subscribers: lebedev.ri, wdng, hiraditya, steven.zhang, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D83231
18 lines
661 B
LLVM
18 lines
661 B
LLVM
; RUN: llc -asm-verbose=0 -mtriple aarch64-arm-none-eabi < %s | FileCheck %s
|
|
|
|
; The following code previously broke in the DAGCombiner. Specifically, trying to combine:
|
|
; extract_vector_elt (concat_vectors v4i16:a, v4i16:b), x
|
|
; -> extract_vector_elt a, x
|
|
|
|
define half @test_combine_extract_concat_vectors(<4 x i16> %a) nounwind {
|
|
entry:
|
|
%0 = shufflevector <4 x i16> %a, <4 x i16> undef, <8 x i32> <i32 0, i32 1, i32 2, i32 3, i32 4, i32 5, i32 6, i32 7>
|
|
%1 = bitcast <8 x i16> %0 to <8 x half>
|
|
%2 = extractelement <8 x half> %1, i32 3
|
|
ret half %2
|
|
}
|
|
|
|
; CHECK-LABEL: test_combine_extract_concat_vectors:
|
|
; CHECK-NEXT: mov h0, v0.h[3]
|
|
; CHECK-NEXT: ret
|