mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 19:52:54 +01:00
dda2ff1737
The pass used to be enabled by default with CodeGenOpt::Less (-O1). This is too aggressive, considering the pass indiscriminately merges all globals together. Currently, performance doesn't always improve, and, on code that uses few globals (e.g., the odd file- or function- static), more often than not is degraded by the optimization. Lengthy discussion can be found on llvmdev (AArch64-focused; ARM has similar problems): http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-February/082800.html Also, it makes tooling and debuggers less useful when dealing with globals and data sections. GlobalMerge needs to better identify those cases that benefit, and this will be done separately. In the meantime, move the pass to run with -O3 rather than -O1, on both ARM and AArch64. llvm-svn: 233024
53 lines
1.7 KiB
LLVM
53 lines
1.7 KiB
LLVM
; RUN: llc %s -mtriple=aarch64-none-linux-gnu -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s
|
|
; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s
|
|
; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS
|
|
|
|
@x = global i32 0, align 4
|
|
@y = global i32 0, align 4
|
|
@z = global i32 0, align 4
|
|
|
|
define void @f1(i32 %a1, i32 %a2) {
|
|
;CHECK-APPLE-IOS-LABEL: _f1:
|
|
;CHECK-APPLE-IOS-NOT: adrp
|
|
;CHECK-APPLE-IOS: adrp x8, __MergedGlobals_x@PAGE
|
|
;CHECK-APPLE-IOS: add x8, x8, __MergedGlobals_x@PAGEOFF
|
|
;CHECK-APPLE-IOS-NOT: adrp
|
|
store i32 %a1, i32* @x, align 4
|
|
store i32 %a2, i32* @y, align 4
|
|
ret void
|
|
}
|
|
|
|
define void @g1(i32 %a1, i32 %a2) {
|
|
;CHECK-APPLE-IOS-LABEL: _g1:
|
|
;CHECK-APPLE-IOS: adrp x8, __MergedGlobals_x@PAGE
|
|
;CHECK-APPLE-IOS: add x8, x8, __MergedGlobals_x@PAGEOFF
|
|
;CHECK-APPLE-IOS-NOT: adrp
|
|
store i32 %a1, i32* @y, align 4
|
|
store i32 %a2, i32* @z, align 4
|
|
ret void
|
|
}
|
|
|
|
;CHECK: .type _MergedGlobals_x,@object // @_MergedGlobals_x
|
|
;CHECK: .globl _MergedGlobals_x
|
|
;CHECK: .align 3
|
|
;CHECK: _MergedGlobals_x:
|
|
;CHECK: .size _MergedGlobals_x, 12
|
|
|
|
;CHECK: .globl x
|
|
;CHECK: x = _MergedGlobals_x
|
|
;CHECK: .globl y
|
|
;CHECK: y = _MergedGlobals_x+4
|
|
;CHECK: .globl z
|
|
;CHECK: z = _MergedGlobals_x+8
|
|
|
|
;CHECK-APPLE-IOS: .globl __MergedGlobals_x ; @_MergedGlobals_x
|
|
;CHECK-APPLE-IOS: .zerofill __DATA,__common,__MergedGlobals_x,12,3
|
|
|
|
;CHECK-APPLE-IOS: .globl _x
|
|
;CHECK-APPLE-IOS: _x = __MergedGlobals_x
|
|
;CHECK-APPLE-IOS: .globl _y
|
|
;CHECK-APPLE-IOS: _y = __MergedGlobals_x+4
|
|
;CHECK-APPLE-IOS: .globl _z
|
|
;CHECK-APPLE-IOS: _z = __MergedGlobals_x+8
|
|
;CHECK-APPLE-IOS: .subsections_via_symbols
|