mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-20 19:42:54 +02:00
d6f4926afa
The code that builds the dependence graph assumes that two PseudoSourceValues don't alias. In a tail calling function two FixedStackObjects might refer to the same location. Worse 'immutable' fixed stack objects like function arguments are not immutable and will be clobbered. Change this so that a load from a FixedStackObject is not invariant in a tail calling function and don't return a PseudoSourceValue for an instruction in tail calling functions when building the dependence graph so that we handle function arguments conservatively. Fix for PR23459. rdar://20740035 llvm-svn: 236916
29 lines
1.3 KiB
LLVM
29 lines
1.3 KiB
LLVM
; RUN: llc < %s -tailcallopt -mcpu=generic -mtriple=x86_64-linux -post-RA-scheduler=true | FileCheck %s
|
|
; RUN: llc < %s -tailcallopt -mcpu=generic -mtriple=x86_64-win32 -post-RA-scheduler=true | FileCheck %s
|
|
|
|
; FIXME: Redundant unused stack allocation could be eliminated.
|
|
; CHECK: subq ${{24|72|80}}, %rsp
|
|
|
|
; Check that lowered arguments on the stack do not overwrite each other.
|
|
; Add %in1 %p1 to a different temporary register (%eax).
|
|
; CHECK: movl [[A1:32|144]](%rsp), [[R1:%e..]]
|
|
; Move param %in1 to temp register (%r10d).
|
|
; CHECK: movl [[A2:40|152]](%rsp), [[R2:%[a-z0-9]+]]
|
|
; Add %in1 %p1 to a different temporary register (%eax).
|
|
; CHECK: addl {{%edi|%ecx}}, [[R1]]
|
|
; Move param %in2 to stack.
|
|
; CHECK-DAG: movl [[R2]], [[A1]](%rsp)
|
|
; Move result of addition to stack.
|
|
; CHECK-DAG: movl [[R1]], [[A2]](%rsp)
|
|
; Eventually, do a TAILCALL
|
|
; CHECK: TAILCALL
|
|
|
|
declare fastcc i32 @tailcallee(i32 %p1, i32 %p2, i32 %p3, i32 %p4, i32 %p5, i32 %p6, i32 %a, i32 %b) nounwind
|
|
|
|
define fastcc i32 @tailcaller(i32 %p1, i32 %p2, i32 %p3, i32 %p4, i32 %p5, i32 %p6, i32 %in1, i32 %in2) nounwind {
|
|
entry:
|
|
%tmp = add i32 %in1, %p1
|
|
%retval = tail call fastcc i32 @tailcallee(i32 %p1, i32 %p2, i32 %p3, i32 %p4, i32 %p5, i32 %p6, i32 %in2,i32 %tmp)
|
|
ret i32 %retval
|
|
}
|