mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-01-31 20:51:52 +01:00
3c2a4cc1bc
findPHICopyInsertPoint special cases placement in a block with a callbr or invoke in it. In that case, we must ensure that the copy is placed before the INLINEASM_BR or call instruction, if the register is defined prior to that instruction, because it may jump out of the block. Previously, the code placed it immediately after the last def _or use_. This is wrong, if the use is the instruction which may jump. We could correctly place it immediately after the last def (ignoring uses), but that is non-optimal for register pressure. Instead, place the copy after the last def, or before the call/inlineasm_br, whichever is later. Differential Revision: https://reviews.llvm.org/D87865
45 lines
1.3 KiB
LLVM
45 lines
1.3 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
|
; RUN: llc -mtriple=x86_64-unknown-linux-gnu -verify-machineinstrs -O2 < %s | FileCheck %s
|
|
|
|
;; https://bugs.llvm.org/PR47468
|
|
|
|
;; PHI elimination should place copies BEFORE the inline asm, not
|
|
;; after, even if the inline-asm uses as an input the same value as
|
|
;; the PHI.
|
|
|
|
declare void @foo(i8*)
|
|
|
|
define void @test1(i8* %arg, i8** %mem) nounwind {
|
|
; CHECK-LABEL: test1:
|
|
; CHECK: # %bb.0: # %entry
|
|
; CHECK-NEXT: pushq %r14
|
|
; CHECK-NEXT: pushq %rbx
|
|
; CHECK-NEXT: pushq %rax
|
|
; CHECK-NEXT: movq %rsi, %r14
|
|
; CHECK-NEXT: .Ltmp0: # Block address taken
|
|
; CHECK-NEXT: .LBB0_1: # %loop
|
|
; CHECK-NEXT: # =>This Inner Loop Header: Depth=1
|
|
; CHECK-NEXT: movq (%r14), %rbx
|
|
; CHECK-NEXT: callq foo
|
|
; CHECK-NEXT: movq %rbx, %rdi
|
|
; CHECK-NEXT: #APP
|
|
; CHECK-NEXT: #NO_APP
|
|
; CHECK-NEXT: # %bb.2: # %end
|
|
; CHECK-NEXT: addq $8, %rsp
|
|
; CHECK-NEXT: popq %rbx
|
|
; CHECK-NEXT: popq %r14
|
|
; CHECK-NEXT: retq
|
|
entry:
|
|
br label %loop
|
|
|
|
loop:
|
|
%a = phi i8* [ %arg, %entry ], [ %b, %loop ]
|
|
%b = load i8*, i8** %mem, align 8
|
|
call void @foo(i8* %a)
|
|
callbr void asm sideeffect "", "*m,X"(i8* %b, i8* blockaddress(@test1, %loop))
|
|
to label %end [label %loop]
|
|
|
|
end:
|
|
ret void
|
|
}
|