mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
a11e4da4cd
Summary: Reland after fixing a bug that allowed outlining of SP modifying instructions that invalidated return address signing. During AArch64 frame lowering instructions to enable return address signing are inserted into functions if needed. Functions generated during machine outlining don't run through target frame lowering and hence are missing such instructions. This patch introduces the following changes: 1. If not all functions that potentially participate in function outlining agree on their return address signing scope and their return address signing key, outlining is disabled for these functions. 2. If not all functions that potentially participate in function outlining agree on their support for v8.3A features, outlining is disabled for these functions. 3. If an outlining candidate would outline instructions that modify sp in a way that invalidates return address signing, outlining is disabled for that particular candidate. 4. If all candidate functions agree on the signing scope, signing key and their support for v8.3 features, the outlined function behaves as if it had the same scope and key attributes and as if it would provide the same v8.3A support as the original functions. Reviewers: ostannard, paquette Reviewed By: ostannard Subscribers: kristof.beyls, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70635
84 lines
2.5 KiB
LLVM
84 lines
2.5 KiB
LLVM
; RUN: llc -verify-machineinstrs -enable-machine-outliner -mtriple \
|
|
; RUN: aarch64-arm-linux-gnu %s -o - | FileCheck %s
|
|
|
|
; Check that outlined functions use the dedicated RETAA/RETAB instructions
|
|
; to sign their return address if available.
|
|
|
|
define void @a() #0 {
|
|
; CHECK-LABEL: a: // @a
|
|
; CHECK: // %bb.0:
|
|
; CHECK-NEXT: pacibsp
|
|
; CHECK: bl [[OUTLINED_FUNC:OUTLINED_FUNCTION_[0-9]+]]
|
|
%1 = alloca i32, align 4
|
|
%2 = alloca i32, align 4
|
|
%3 = alloca i32, align 4
|
|
%4 = alloca i32, align 4
|
|
%5 = alloca i32, align 4
|
|
%6 = alloca i32, align 4
|
|
store i32 1, i32* %1, align 4
|
|
store i32 2, i32* %2, align 4
|
|
store i32 3, i32* %3, align 4
|
|
store i32 4, i32* %4, align 4
|
|
store i32 5, i32* %5, align 4
|
|
store i32 6, i32* %6, align 4
|
|
; CHECK: retab
|
|
; CHECK-NOT: auti[a,b]sp
|
|
ret void
|
|
}
|
|
|
|
define void @b() #0 {
|
|
; CHECK-LABEL: b: // @b
|
|
; CHECK: // %bb.0:
|
|
; CHECK-NEXT: pacibsp
|
|
; CHECK: bl OUTLINED_FUNC
|
|
%1 = alloca i32, align 4
|
|
%2 = alloca i32, align 4
|
|
%3 = alloca i32, align 4
|
|
%4 = alloca i32, align 4
|
|
%5 = alloca i32, align 4
|
|
%6 = alloca i32, align 4
|
|
store i32 1, i32* %1, align 4
|
|
store i32 2, i32* %2, align 4
|
|
store i32 3, i32* %3, align 4
|
|
store i32 4, i32* %4, align 4
|
|
store i32 5, i32* %5, align 4
|
|
store i32 6, i32* %6, align 4
|
|
; CHECK: retab
|
|
; CHECK-NOT: auti[a,b]sp
|
|
ret void
|
|
}
|
|
|
|
define void @c() #0 {
|
|
; CHECK-LABEL: c: // @c
|
|
; CHECK: // %bb.0:
|
|
; CHECK-NEXT: pacibsp
|
|
; CHECK: bl OUTLINED_FUNC
|
|
%1 = alloca i32, align 4
|
|
%2 = alloca i32, align 4
|
|
%3 = alloca i32, align 4
|
|
%4 = alloca i32, align 4
|
|
%5 = alloca i32, align 4
|
|
%6 = alloca i32, align 4
|
|
store i32 1, i32* %1, align 4
|
|
store i32 2, i32* %2, align 4
|
|
store i32 3, i32* %3, align 4
|
|
store i32 4, i32* %4, align 4
|
|
store i32 5, i32* %5, align 4
|
|
store i32 6, i32* %6, align 4
|
|
; CHECK: retab
|
|
; CHECK-NOT: auti[a,b]sp
|
|
ret void
|
|
}
|
|
|
|
attributes #0 = { "sign-return-address"="all"
|
|
"sign-return-address-key"="b_key"
|
|
"target-features"="+v8.3a"
|
|
nounwind }
|
|
|
|
; CHECK: OUTLINED_FUNC
|
|
; CHECK: // %bb.0:
|
|
; CHECK-NEXT: .cfi_b_key_frame
|
|
; CHECK-NEXT: pacibsp
|
|
; CHECK: retab
|
|
; CHECK-NOT: auti[a,b]sp
|