mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
1297c7a3c0
Summary: We have always speculatively promoted all renamable local values (except const non-address taken variables) for both the exporting and importing module. We would then internalize them back based on the ThinLink results if they weren't actually exported. This is inefficient, and results in unnecessary renames. It also meant we had to check the non-renamability of a value in the summary, which was already checked during function importing analysis in the ThinLink. Made renameModuleForThinLTO (which does the promotion/renaming) instead use the index when exporting, to avoid unnecessary renames/promotions. For importing modules, we can simply promoted all values as any local we import by definition is exported and needs promotion. This required changes to the method used by the FunctionImport pass (only invoked from 'opt' for testing) and when invoked from llvm-link, since neither does a ThinLink. We simply conservatively mark all locals in the index as promoted, which preserves the current aggressive promotion behavior. I also needed to change an llvm-lto based test where we had previously been aggressively promoting values that weren't importable (aliasees), but now will not promote. Reviewers: mehdi_amini Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D26467 llvm-svn: 286871
208 lines
13 KiB
LLVM
208 lines
13 KiB
LLVM
; RUN: opt -module-summary %s -o %t1.bc
|
|
; RUN: opt -module-summary %p/Inputs/alias_import.ll -o %t2.bc
|
|
; RUN: llvm-lto -thinlto-action=thinlink -o %t.index.bc %t1.bc %t2.bc
|
|
; RUN: llvm-lto -thinlto-action=promote -thinlto-index %t.index.bc %t2.bc -o - | llvm-dis -o - | FileCheck %s --check-prefix=PROMOTE
|
|
; RUN: llvm-lto -thinlto-action=promote -thinlto-index %t.index.bc %t2.bc -o - | llvm-lto -thinlto-action=internalize -thinlto-index %t.index.bc -thinlto-module-id=%t2.bc - -o - | llvm-dis -o - | FileCheck %s --check-prefix=PROMOTE-INTERNALIZE
|
|
; RUN: llvm-lto -thinlto-action=import -thinlto-index %t.index.bc %t1.bc -o - | llvm-dis -o - | FileCheck %s --check-prefix=IMPORT
|
|
|
|
;
|
|
; Alias can't point to "available_externally", so we can only import an alias
|
|
; when we can import the aliasee with a linkage that won't be
|
|
; available_externally, i.e linkOnceODR. (FIXME this limitation could be lifted)
|
|
; PROMOTE-DAG: @globalfuncAlias = alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-DAG: @globalfuncWeakAlias = weak alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-DAG: @globalfuncLinkonceAlias = weak alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-DAG: @globalfuncWeakODRAlias = weak_odr alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-DAG: @globalfuncLinkonceODRAlias = weak_odr alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-DAG: @internalfuncAlias = alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-DAG: @internalfuncWeakAlias = weak alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-DAG: @internalfuncLinkonceAlias = weak alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-DAG: @internalfuncWeakODRAlias = weak_odr alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-DAG: @internalfuncLinkonceODRAlias = weak_odr alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-DAG: @linkoncefuncAlias = alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-DAG: @linkoncefuncWeakAlias = weak alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-DAG: @linkoncefuncLinkonceAlias = weak alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-DAG: @linkoncefuncWeakODRAlias = weak_odr alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-DAG: @linkoncefuncLinkonceODRAlias = weak_odr alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-DAG: @weakfuncAlias = alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakfuncWeakAlias = weak alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakfuncLinkonceAlias = weak alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakfuncWeakODRAlias = weak_odr alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakfuncLinkonceODRAlias = weak_odr alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakODRfuncAlias = alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakODRfuncWeakAlias = weak alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakODRfuncLinkonceAlias = weak alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakODRfuncWeakODRAlias = weak_odr alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-DAG: @weakODRfuncLinkonceODRAlias = weak_odr alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
|
|
; Only alias to LinkonceODR aliasee can be imported
|
|
; PROMOTE-DAG: @linkonceODRfuncAlias = alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-DAG: @linkonceODRfuncWeakAlias = weak alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-DAG: @linkonceODRfuncWeakODRAlias = weak_odr alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; Amongst these that are imported, check that we promote only linkonce->weak
|
|
; PROMOTE-DAG: @linkonceODRfuncLinkonceAlias = weak alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-DAG: @linkonceODRfuncLinkonceODRAlias = weak_odr alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
|
|
; These will be imported, check the linkage/renaming after promotion
|
|
; PROMOTE-DAG: define void @globalfunc()
|
|
; PROMOTE-DAG: define internal void @internalfunc()
|
|
; PROMOTE-DAG: define weak_odr void @linkonceODRfunc()
|
|
; PROMOTE-DAG: define weak_odr void @weakODRfunc()
|
|
; PROMOTE-DAG: define weak void @linkoncefunc()
|
|
; PROMOTE-DAG: define weak void @weakfunc()
|
|
|
|
; On the import side now, verify that aliases to a linkonce_odr are imported, but the weak/linkonce (we can't inline them)
|
|
; IMPORT-DAG: declare void @linkonceODRfuncWeakAlias
|
|
; IMPORT-DAG: declare void @linkonceODRfuncLinkonceAlias
|
|
; IMPORT-DAG: @linkonceODRfuncAlias = alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; IMPORT-DAG: @linkonceODRfuncWeakODRAlias = alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; IMPORT-DAG: @linkonceODRfuncLinkonceODRAlias = linkonce_odr alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; IMPORT-DAG: define linkonce_odr void @linkonceODRfunc()
|
|
|
|
|
|
; On the import side, these aliases are not imported (they don't point to a linkonce_odr)
|
|
; IMPORT-DAG: declare void @globalfuncAlias()
|
|
; IMPORT-DAG: declare void @globalfuncWeakAlias()
|
|
; IMPORT-DAG: declare void @globalfuncLinkonceAlias()
|
|
; IMPORT-DAG: declare void @globalfuncWeakODRAlias()
|
|
; IMPORT-DAG: declare void @globalfuncLinkonceODRAlias()
|
|
; IMPORT-DAG: declare void @internalfuncAlias()
|
|
; IMPORT-DAG: declare void @internalfuncWeakAlias()
|
|
; IMPORT-DAG: declare void @internalfuncLinkonceAlias()
|
|
; IMPORT-DAG: declare void @internalfuncWeakODRAlias()
|
|
; IMPORT-DAG: declare void @internalfuncLinkonceODRAlias()
|
|
; IMPORT-DAG: declare void @weakODRfuncAlias()
|
|
; IMPORT-DAG: declare void @weakODRfuncWeakAlias()
|
|
; IMPORT-DAG: declare void @weakODRfuncLinkonceAlias()
|
|
; IMPORT-DAG: declare void @weakODRfuncWeakODRAlias()
|
|
; IMPORT-DAG: declare void @weakODRfuncLinkonceODRAlias()
|
|
; IMPORT-DAG: declare void @linkoncefuncAlias()
|
|
; IMPORT-DAG: declare void @linkoncefuncWeakAlias()
|
|
; IMPORT-DAG: declare void @linkoncefuncLinkonceAlias()
|
|
; IMPORT-DAG: declare void @linkoncefuncWeakODRAlias()
|
|
; IMPORT-DAG: declare void @linkoncefuncLinkonceODRAlias()
|
|
; IMPORT-DAG: declare void @weakfuncAlias()
|
|
; IMPORT-DAG: declare void @weakfuncWeakAlias()
|
|
; IMPORT-DAG: declare void @weakfuncLinkonceAlias()
|
|
; IMPORT-DAG: declare void @weakfuncWeakODRAlias()
|
|
; IMPORT-DAG: declare void @weakfuncLinkonceODRAlias()
|
|
|
|
; Promotion + internalization should internalize all of these, except for aliases of
|
|
; linkonce_odr functions, because alias to linkonce_odr are the only aliases we will
|
|
; import (see selectCallee() in FunctionImport.cpp).
|
|
; PROMOTE-INTERNALIZE-DAG: @globalfuncAlias = internal alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @globalfuncWeakAlias = internal alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @globalfuncLinkonceAlias = internal alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @globalfuncWeakODRAlias = internal alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @globalfuncLinkonceODRAlias = internal alias void (...), bitcast (void ()* @globalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @internalfuncAlias = internal alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @internalfuncWeakAlias = internal alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @internalfuncLinkonceAlias = internal alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @internalfuncWeakODRAlias = internal alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @internalfuncLinkonceODRAlias = internal alias void (...), bitcast (void ()* @internalfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkonceODRfuncAlias = alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkonceODRfuncWeakAlias = internal alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkonceODRfuncLinkonceAlias = internal alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkonceODRfuncWeakODRAlias = weak_odr alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkonceODRfuncLinkonceODRAlias = weak_odr alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakODRfuncAlias = internal alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakODRfuncWeakAlias = internal alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakODRfuncLinkonceAlias = internal alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakODRfuncWeakODRAlias = internal alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakODRfuncLinkonceODRAlias = internal alias void (...), bitcast (void ()* @weakODRfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkoncefuncAlias = internal alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkoncefuncWeakAlias = internal alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkoncefuncLinkonceAlias = internal alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkoncefuncWeakODRAlias = internal alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @linkoncefuncLinkonceODRAlias = internal alias void (...), bitcast (void ()* @linkoncefunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakfuncAlias = internal alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakfuncWeakAlias = internal alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakfuncLinkonceAlias = internal alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakfuncWeakODRAlias = internal alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: @weakfuncLinkonceODRAlias = internal alias void (...), bitcast (void ()* @weakfunc to void (...)*)
|
|
; PROMOTE-INTERNALIZE-DAG: define internal void @globalfunc()
|
|
; PROMOTE-INTERNALIZE-DAG: define internal void @internalfunc()
|
|
; PROMOTE-INTERNALIZE-DAG: define internal void @linkonceODRfunc()
|
|
; PROMOTE-INTERNALIZE-DAG: define internal void @weakODRfunc()
|
|
; PROMOTE-INTERNALIZE-DAG: define internal void @linkoncefunc()
|
|
; PROMOTE-INTERNALIZE-DAG: define internal void @weakfunc()
|
|
|
|
define i32 @main() #0 {
|
|
entry:
|
|
call void @globalfuncAlias()
|
|
call void @globalfuncWeakAlias()
|
|
call void @globalfuncLinkonceAlias()
|
|
call void @globalfuncWeakODRAlias()
|
|
call void @globalfuncLinkonceODRAlias()
|
|
|
|
call void @internalfuncAlias()
|
|
call void @internalfuncWeakAlias()
|
|
call void @internalfuncLinkonceAlias()
|
|
call void @internalfuncWeakODRAlias()
|
|
call void @internalfuncLinkonceODRAlias()
|
|
call void @linkonceODRfuncAlias()
|
|
call void @linkonceODRfuncWeakAlias()
|
|
call void @linkonceODRfuncLinkonceAlias()
|
|
call void @linkonceODRfuncWeakODRAlias()
|
|
call void @linkonceODRfuncLinkonceODRAlias()
|
|
|
|
call void @weakODRfuncAlias()
|
|
call void @weakODRfuncWeakAlias()
|
|
call void @weakODRfuncLinkonceAlias()
|
|
call void @weakODRfuncWeakODRAlias()
|
|
call void @weakODRfuncLinkonceODRAlias()
|
|
|
|
call void @linkoncefuncAlias()
|
|
call void @linkoncefuncWeakAlias()
|
|
call void @linkoncefuncLinkonceAlias()
|
|
call void @linkoncefuncWeakODRAlias()
|
|
call void @linkoncefuncLinkonceODRAlias()
|
|
|
|
call void @weakfuncAlias()
|
|
call void @weakfuncWeakAlias()
|
|
call void @weakfuncLinkonceAlias()
|
|
call void @weakfuncWeakODRAlias()
|
|
call void @weakfuncLinkonceODRAlias()
|
|
|
|
ret i32 0
|
|
}
|
|
|
|
|
|
declare void @globalfuncAlias()
|
|
declare void @globalfuncWeakAlias()
|
|
declare void @globalfuncLinkonceAlias()
|
|
declare void @globalfuncWeakODRAlias()
|
|
declare void @globalfuncLinkonceODRAlias()
|
|
|
|
declare void @internalfuncAlias()
|
|
declare void @internalfuncWeakAlias()
|
|
declare void @internalfuncLinkonceAlias()
|
|
declare void @internalfuncWeakODRAlias()
|
|
declare void @internalfuncLinkonceODRAlias()
|
|
|
|
declare void @linkonceODRfuncAlias()
|
|
declare void @linkonceODRfuncWeakAlias()
|
|
declare void @linkonceODRfuncLinkonceAlias()
|
|
declare void @linkonceODRfuncWeakODRAlias()
|
|
declare void @linkonceODRfuncLinkonceODRAlias()
|
|
|
|
declare void @weakODRfuncAlias()
|
|
declare void @weakODRfuncWeakAlias()
|
|
declare void @weakODRfuncLinkonceAlias()
|
|
declare void @weakODRfuncWeakODRAlias()
|
|
declare void @weakODRfuncLinkonceODRAlias()
|
|
|
|
declare void @linkoncefuncAlias()
|
|
declare void @linkoncefuncWeakAlias()
|
|
declare void @linkoncefuncLinkonceAlias()
|
|
declare void @linkoncefuncWeakODRAlias()
|
|
declare void @linkoncefuncLinkonceODRAlias()
|
|
|
|
declare void @weakfuncAlias()
|
|
declare void @weakfuncWeakAlias()
|
|
declare void @weakfuncLinkonceAlias()
|
|
declare void @weakfuncWeakODRAlias()
|
|
declare void @weakfuncLinkonceODRAlias()
|
|
|
|
|