mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 11:02:59 +02:00
348b96dc3b
Summary: When sinking an instruction in InstCombine we now also sink the DbgInfoIntrinsics that are using the sunken value. Example) When sinking the load in this input bb.X: %0 = load i64, i64* %start, align 4, !dbg !31 tail call void @llvm.dbg.value(metadata i64 %0, ...) br i1 %cond, label %for.end, label %for.body.lr.ph for.body.lr.ph: br label %for.body we now also move the dbg.value, like this bb.X: br i1 %cond, label %for.end, label %for.body.lr.ph for.body.lr.ph: %0 = load i64, i64* %start, align 4, !dbg !31 tail call void @llvm.dbg.value(metadata i64 %0, ...) br label %for.body In the past we haven't moved the dbg.value so we got bb.X: tail call void @llvm.dbg.value(metadata i64 %0, ...) br i1 %cond, label %for.end, label %for.body.lr.ph for.body.lr.ph: %0 = load i64, i64* %start, align 4, !dbg !31 br label %for.body So in the past we got a debug-use before the def of %0. And that dbg.value was also on the path jumping to %for.end, for which %0 never was defined. CodeGenPrepare normally comes to rescue later (when not moving the dbg.value), since it moves dbg.value instrinsics quite brutally, without really analysing if it is correct to move the intrinsic (see PR31878). So at the moment this patch isn't expected to have much impact, besides that it is moving the dbg.value already in opt, making the IR look more sane directly. This can be seen as a preparation to (hopefully) make it possible to turn off CodeGenPrepare::placeDbgValues later as a solution to PR31878. I also adjusted test/DebugInfo/X86/sdagsplit-1.ll to make the IR in the test case up-to-date with this behavior in InstCombine. Reviewers: rnk, vsk, aprantl Reviewed By: vsk, aprantl Subscribers: mattd, JDevlieghere, llvm-commits Tags: #debug-info Differential Revision: https://reviews.llvm.org/D45425 llvm-svn: 330243
70 lines
3.0 KiB
LLVM
70 lines
3.0 KiB
LLVM
; RUN: llc %s -stop-after=livedebugvars -o %t
|
|
; RUN: cat %t | FileCheck %s
|
|
;
|
|
; Test that we can emit debug info for large values that are split
|
|
; up across multiple registers by the SelectionDAG type legalizer.
|
|
;
|
|
; // Compile with -O1 -m32.
|
|
; long long foo (long long a, long long b)
|
|
; {
|
|
; long long res = b+1;
|
|
; if ( a == b )
|
|
; return res;
|
|
; return 0;
|
|
; }
|
|
;
|
|
; CHECK-DAG: DBG_VALUE debug-use ${{[a-z]+}}, debug-use $noreg, !{{[0-9]+}}, !DIExpression(DW_OP_LLVM_fragment, 0, 32), debug-location !{{[0-9]+}}
|
|
; CHECK-DAG: DBG_VALUE debug-use ${{[a-z]+}}, debug-use $noreg, !{{[0-9]+}}, !DIExpression(DW_OP_LLVM_fragment, 32, 32), debug-location !{{[0-9]+}}
|
|
|
|
; ModuleID = 'sdagsplit-1.c'
|
|
target datalayout = "e-m:e-p:32:32-f64:32:64-f80:32-n8:16:32-S128"
|
|
target triple = "i386"
|
|
|
|
; Function Attrs: nounwind readnone
|
|
define i64 @foo(i64 %a, i64 %b) local_unnamed_addr #0 !dbg !8 {
|
|
entry:
|
|
tail call void @llvm.dbg.value(metadata i64 %a, metadata !13, metadata !16), !dbg !17
|
|
tail call void @llvm.dbg.value(metadata i64 %b, metadata !14, metadata !16), !dbg !18
|
|
%cmp = icmp eq i64 %a, %b, !dbg !20
|
|
%add = add nsw i64 %b, 1, !dbg !22
|
|
tail call void @llvm.dbg.value(metadata i64 %add, metadata !15, metadata !16), !dbg !19
|
|
%retval.0 = select i1 %cmp, i64 %add, i64 0, !dbg !23
|
|
ret i64 %retval.0, !dbg !24
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone speculatable
|
|
declare void @llvm.dbg.value(metadata, metadata, metadata) #1
|
|
|
|
attributes #0 = { nounwind readnone }
|
|
attributes #1 = { nounwind readnone speculatable }
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!3, !4, !5, !6}
|
|
!llvm.ident = !{!7}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 6.0.0 ", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2)
|
|
!1 = !DIFile(filename: "sdagsplit-1.c", directory: "/X86")
|
|
!2 = !{}
|
|
!3 = !{i32 1, !"NumRegisterParameters", i32 0}
|
|
!4 = !{i32 2, !"Dwarf Version", i32 2}
|
|
!5 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!6 = !{i32 1, !"wchar_size", i32 4}
|
|
!7 = !{!"clang version 6.0.0 "}
|
|
!8 = distinct !DISubprogram(name: "foo", scope: !1, file: !1, line: 2, type: !9, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: true, unit: !0, variables: !12)
|
|
!9 = !DISubroutineType(types: !10)
|
|
!10 = !{!11, !11, !11}
|
|
!11 = !DIBasicType(name: "long long int", size: 64, encoding: DW_ATE_signed)
|
|
!12 = !{!13, !14, !15}
|
|
!13 = !DILocalVariable(name: "a", arg: 1, scope: !8, file: !1, line: 2, type: !11)
|
|
!14 = !DILocalVariable(name: "b", arg: 2, scope: !8, file: !1, line: 2, type: !11)
|
|
!15 = !DILocalVariable(name: "res", scope: !8, file: !1, line: 4, type: !11)
|
|
!16 = !DIExpression()
|
|
!17 = !DILocation(line: 2, column: 26, scope: !8)
|
|
!18 = !DILocation(line: 2, column: 39, scope: !8)
|
|
!19 = !DILocation(line: 4, column: 12, scope: !8)
|
|
!20 = !DILocation(line: 5, column: 9, scope: !21)
|
|
!21 = distinct !DILexicalBlock(scope: !8, file: !1, line: 5, column: 7)
|
|
!22 = !DILocation(line: 4, column: 19, scope: !8)
|
|
!23 = !DILocation(line: 5, column: 7, scope: !8)
|
|
!24 = !DILocation(line: 8, column: 1, scope: !8)
|