mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
f6eeeaf04e
This broke Chromium's PGO build, it seems because hot-cold-splitting got turned on unintentionally. See comment on the code review for repro etc. > This patch adds -f[no-]split-cold-code CC1 options to clang. This allows > the splitting pass to be toggled on/off. The current method of passing > `-mllvm -hot-cold-split=true` to clang isn't ideal as it may not compose > correctly (say, with `-O0` or `-Oz`). > > To implement the -fsplit-cold-code option, an attribute is applied to > functions to indicate that they may be considered for splitting. This > removes some complexity from the old/new PM pipeline builders, and > behaves as expected when LTO is enabled. > > Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org> > Differential Revision: https://reviews.llvm.org/D57265 > Reviewed By: Aditya Kumar, Vedant Kumar > Reviewers: Teresa Johnson, Aditya Kumar, Fedor Sergeev, Philip Pfaffe, Vedant Kumar This reverts commit 273c299d5d649a0222fbde03c9a41e41913751b4.
117 lines
3.5 KiB
LLVM
117 lines
3.5 KiB
LLVM
; RUN: opt -S -hotcoldsplit -hotcoldsplit-threshold=0 < %s | FileCheck %s
|
|
|
|
; Source:
|
|
;
|
|
; extern void sideeffect(int);
|
|
; extern void __attribute__((cold)) sink();
|
|
; void foo(int cond) {
|
|
; if (cond) { //< Start outlining here.
|
|
; while (cond > 10) {
|
|
; --cond;
|
|
; sideeffect(0);
|
|
; }
|
|
; sink();
|
|
; }
|
|
; sideeffect(1);
|
|
; }
|
|
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx10.14.0"
|
|
|
|
; CHECK-LABEL: define {{.*}}@foo(
|
|
; CHECK: br i1 {{.*}}, label %if.end, label %codeRepl
|
|
; CHECK-LABEL: codeRepl:
|
|
; CHECK-NEXT: call void @foo.cold.1
|
|
; CHECK-LABEL: if.end:
|
|
; CHECK: call void @sideeffect(i32 1)
|
|
define void @foo(i32 %cond) {
|
|
entry:
|
|
%tobool = icmp eq i32 %cond, 0
|
|
br i1 %tobool, label %if.end, label %while.cond.preheader
|
|
|
|
while.cond.preheader: ; preds = %entry
|
|
%cmp3 = icmp sgt i32 %cond, 10
|
|
br i1 %cmp3, label %while.body.preheader, label %while.end
|
|
|
|
while.body.preheader: ; preds = %while.cond.preheader
|
|
br label %while.body
|
|
|
|
while.body: ; preds = %while.body.preheader, %while.body
|
|
%cond.addr.04 = phi i32 [ %dec, %while.body ], [ %cond, %while.body.preheader ]
|
|
%dec = add nsw i32 %cond.addr.04, -1
|
|
tail call void @sideeffect(i32 0) #3
|
|
%cmp = icmp sgt i32 %dec, 10
|
|
br i1 %cmp, label %while.body, label %while.end.loopexit
|
|
|
|
while.end.loopexit: ; preds = %while.body
|
|
br label %while.end
|
|
|
|
while.end: ; preds = %while.end.loopexit, %while.cond.preheader
|
|
tail call void (...) @sink()
|
|
ret void
|
|
|
|
if.end: ; preds = %entry
|
|
tail call void @sideeffect(i32 1)
|
|
ret void
|
|
}
|
|
|
|
; This is the same as @foo, but the while loop comes after the sink block.
|
|
; CHECK-LABEL: define {{.*}}@while_loop_after_sink(
|
|
; CHECK: br i1 {{.*}}, label %if.end, label %codeRepl
|
|
; CHECK-LABEL: codeRepl:
|
|
; CHECK-NEXT: call void @while_loop_after_sink.cold.1
|
|
; CHECK-LABEL: if.end:
|
|
; CHECK: call void @sideeffect(i32 1)
|
|
define void @while_loop_after_sink(i32 %cond) {
|
|
entry:
|
|
%tobool = icmp eq i32 %cond, 0
|
|
br i1 %tobool, label %if.end, label %sink
|
|
|
|
sink:
|
|
tail call void (...) @sink()
|
|
br label %while.cond.preheader
|
|
|
|
while.cond.preheader:
|
|
%cmp3 = icmp sgt i32 %cond, 10
|
|
br i1 %cmp3, label %while.body.preheader, label %while.end
|
|
|
|
while.body.preheader: ; preds = %while.cond.preheader
|
|
br label %while.body
|
|
|
|
while.body: ; preds = %while.body.preheader, %while.body
|
|
%cond.addr.04 = phi i32 [ %dec, %while.body ], [ %cond, %while.body.preheader ]
|
|
%dec = add nsw i32 %cond.addr.04, -1
|
|
tail call void @sideeffect(i32 0) #3
|
|
%cmp = icmp sgt i32 %dec, 10
|
|
br i1 %cmp, label %while.body, label %while.end.loopexit
|
|
|
|
while.end.loopexit: ; preds = %while.body
|
|
br label %while.end
|
|
|
|
while.end: ; preds = %while.end.loopexit, %while.cond.preheader
|
|
ret void
|
|
|
|
if.end: ; preds = %entry
|
|
tail call void @sideeffect(i32 1)
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: define {{.*}}@foo.cold.1
|
|
; CHECK: phi i32
|
|
; CHECK-NEXT: add nsw i32
|
|
; CHECK-NEXT: call {{.*}}@sideeffect
|
|
; CHECK-NEXT: icmp
|
|
; CHECK-NEXT: br
|
|
|
|
; CHECK-LABEL: define {{.*}}@while_loop_after_sink.cold.1
|
|
; CHECK: call {{.*}}@sink
|
|
; CHECK: phi i32
|
|
; CHECK-NEXT: add nsw i32
|
|
; CHECK-NEXT: call {{.*}}@sideeffect
|
|
; CHECK-NEXT: icmp
|
|
; CHECK-NEXT: br
|
|
|
|
declare void @sideeffect(i32)
|
|
|
|
declare void @sink(...) cold
|