mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-24 05:23:45 +02:00
bce1b9a58d
Summary: In a .symver assembler directive like: .symver name, name2@@nodename "name2@@nodename" should get the same symbol binding as "name". While the ELF object writer is updating the symbol binding for .symver aliases before emitting the object file, not doing so when the module inline assembly is handled by the RecordStreamer is causing the wrong behavior in *LTO mode. E.g. when "name" is global, "name2@@nodename" must also be marked as global. Otherwise, the symbol is skipped when iterating over the LTO InputFile symbols (InputFile::Symbol::shouldSkip). So, for example, when performing any *LTO via the gold-plugin, the versioned symbol definition is not recorded by the plugin and passed back to the linker. If the object was in an archive, and there were no other symbols needed from that object, the object would not be included in the final link and references to the versioned symbol are undefined. The llvm-lto2 tests added will give an error about an unused symbol resolution without the fix. Reviewers: rafael, pcc Reviewed By: pcc Subscribers: mehdi_amini, llvm-commits Differential Revision: https://reviews.llvm.org/D30485 llvm-svn: 297332
118 lines
3.0 KiB
C++
118 lines
3.0 KiB
C++
//===-- RecordStreamer.cpp - Record asm definde and used symbols ----------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "RecordStreamer.h"
|
|
#include "llvm/MC/MCSymbol.h"
|
|
using namespace llvm;
|
|
|
|
void RecordStreamer::markDefined(const MCSymbol &Symbol) {
|
|
State &S = Symbols[Symbol.getName()];
|
|
switch (S) {
|
|
case DefinedGlobal:
|
|
case Global:
|
|
S = DefinedGlobal;
|
|
break;
|
|
case NeverSeen:
|
|
case Defined:
|
|
case Used:
|
|
S = Defined;
|
|
break;
|
|
case DefinedWeak:
|
|
break;
|
|
case UndefinedWeak:
|
|
S = DefinedWeak;
|
|
}
|
|
}
|
|
|
|
void RecordStreamer::markGlobal(const MCSymbol &Symbol,
|
|
MCSymbolAttr Attribute) {
|
|
State &S = Symbols[Symbol.getName()];
|
|
switch (S) {
|
|
case DefinedGlobal:
|
|
case Defined:
|
|
S = (Attribute == MCSA_Weak) ? DefinedWeak : DefinedGlobal;
|
|
break;
|
|
|
|
case NeverSeen:
|
|
case Global:
|
|
case Used:
|
|
S = (Attribute == MCSA_Weak) ? UndefinedWeak : Global;
|
|
break;
|
|
case UndefinedWeak:
|
|
case DefinedWeak:
|
|
break;
|
|
}
|
|
}
|
|
|
|
void RecordStreamer::markUsed(const MCSymbol &Symbol) {
|
|
State &S = Symbols[Symbol.getName()];
|
|
switch (S) {
|
|
case DefinedGlobal:
|
|
case Defined:
|
|
case Global:
|
|
case DefinedWeak:
|
|
case UndefinedWeak:
|
|
break;
|
|
|
|
case NeverSeen:
|
|
case Used:
|
|
S = Used;
|
|
break;
|
|
}
|
|
}
|
|
|
|
void RecordStreamer::visitUsedSymbol(const MCSymbol &Sym) { markUsed(Sym); }
|
|
|
|
RecordStreamer::const_iterator RecordStreamer::begin() {
|
|
return Symbols.begin();
|
|
}
|
|
|
|
RecordStreamer::const_iterator RecordStreamer::end() { return Symbols.end(); }
|
|
|
|
RecordStreamer::RecordStreamer(MCContext &Context) : MCStreamer(Context) {}
|
|
|
|
void RecordStreamer::EmitInstruction(const MCInst &Inst,
|
|
const MCSubtargetInfo &STI) {
|
|
MCStreamer::EmitInstruction(Inst, STI);
|
|
}
|
|
|
|
void RecordStreamer::EmitLabel(MCSymbol *Symbol, SMLoc Loc) {
|
|
MCStreamer::EmitLabel(Symbol);
|
|
markDefined(*Symbol);
|
|
}
|
|
|
|
void RecordStreamer::EmitAssignment(MCSymbol *Symbol, const MCExpr *Value) {
|
|
markDefined(*Symbol);
|
|
MCStreamer::EmitAssignment(Symbol, Value);
|
|
}
|
|
|
|
bool RecordStreamer::EmitSymbolAttribute(MCSymbol *Symbol,
|
|
MCSymbolAttr Attribute) {
|
|
if (Attribute == MCSA_Global || Attribute == MCSA_Weak)
|
|
markGlobal(*Symbol, Attribute);
|
|
if (Attribute == MCSA_LazyReference)
|
|
markUsed(*Symbol);
|
|
return true;
|
|
}
|
|
|
|
void RecordStreamer::EmitZerofill(MCSection *Section, MCSymbol *Symbol,
|
|
uint64_t Size, unsigned ByteAlignment) {
|
|
markDefined(*Symbol);
|
|
}
|
|
|
|
void RecordStreamer::EmitCommonSymbol(MCSymbol *Symbol, uint64_t Size,
|
|
unsigned ByteAlignment) {
|
|
markDefined(*Symbol);
|
|
}
|
|
|
|
void RecordStreamer::emitELFSymverDirective(MCSymbol *Alias,
|
|
const MCSymbol *Aliasee) {
|
|
SymverAliasMap[Aliasee].push_back(Alias);
|
|
}
|