mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-01 05:01:59 +01:00
73b691a716
Summary: A *lot* of instructions have this special register. It seems this never really worked, but i finally noticed it only because it happened to break for `CMOV16rm` instruction. We serialized that register as "" (empty string), which is naturally 'ignored' during deserialization, so we re-create a `MCInst` with too few operands. And when we then happened to try to resolve variant sched class for this mis-serialized instruction, and the variant predicate tried to read an operand that was out of bounds since we got less operands, we crashed. Fixes [[ https://bugs.llvm.org/show_bug.cgi?id=41448 | PR41448 ]]. Reviewers: craig.topper, courbet Reviewed By: courbet Subscribers: tschuett, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D60517 llvm-svn: 358153
18 lines
1.0 KiB
ArmAsm
18 lines
1.0 KiB
ArmAsm
# RUN: llvm-exegesis -mode=uops -opcode-name=CMOV16rm -benchmarks-file=%t.CMOV16rm-uops.yaml
|
|
# RUN: FileCheck -check-prefixes=CHECK-YAML -input-file=%t.CMOV16rm-uops.yaml %s
|
|
# RUN: llvm-exegesis -mcpu=bdver2 -mode=analysis -benchmarks-file=%t.CMOV16rm-uops.yaml -analysis-clusters-output-file=- -analysis-clustering-epsilon=0.1 -analysis-inconsistency-epsilon=0.1 -analysis-numpoints=1 -analysis-clustering=naive | FileCheck -check-prefixes=CHECK-CLUSTERS %s
|
|
|
|
# https://bugs.llvm.org/show_bug.cgi?id=41448
|
|
# 1. Verify that we correctly serialize RegNo 0 as %noreg, not as an empty string!
|
|
# 2. Verify that deserialization works. Since CMOV16rm has a variant sched class, just printing clusters is sufficient
|
|
|
|
CHECK-YAML: ---
|
|
CHECK-YAML-NEXT: mode: uops
|
|
CHECK-YAML-NEXT: key:
|
|
CHECK-YAML-NEXT: instructions:
|
|
CHECK-YAML-NEXT: - 'CMOV16rm {{[A-Z0-9]+}} {{[A-Z0-9]+}} {{[A-Z0-9]+}} i_0x1 %noreg i_0x0 %noreg i_0x{{[0-9a-f]}}'
|
|
CHECK-YAML-LAST: ...
|
|
|
|
# CHECK-CLUSTERS: {{^}}cluster_id,opcode_name,config,sched_class,
|
|
# CHECK-CLUSTERS-NEXT: {{^}}0,
|