mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 03:33:20 +01:00
b401fd4c9e
Also avoid locals evicting locals just because they want a cheaper register. Problem: MI Sched knows exactly how many registers we have and assumes they can be colored. In cases where we have large blocks, usually from unrolled loops, greedy coloring fails. This is a source of "regressions" from the MI Scheduler on x86. I noticed this issue on x86 where we have long chains of two-address defs in the same live range. It's easy to see this in matrix multiplication benchmarks like IRSmk and even the unit test misched-matmul.ll. A fundamental difference between the LLVM register allocator and conventional graph coloring is that in our model a live range can't discover its neighbors, it can only verify its neighbors. That's why we initially went for greedy coloring and added eviction to deal with the hard cases. However, for singly defined and two-address live ranges, we can optimally color without visiting neighbors simply by processing the live ranges in instruction order. Other beneficial side effects: It is much easier to understand and debug regalloc for large blocks when the live ranges are allocated in order. Yes, global allocation is still very confusing, but it's nice to be able to comprehend what happened locally. Heuristics could be added to bias register assignment based on instruction locality (think late register pairing, banks...). Intuituvely this will make some test cases that are on the threshold of register pressure more stable. llvm-svn: 187139
21 lines
434 B
LLVM
21 lines
434 B
LLVM
; RUN: llc < %s -march=x86 -mtriple=i686-apple-darwin | FileCheck %s
|
|
|
|
declare void @bar(<2 x i64>* %n)
|
|
|
|
define void @foo(i32 %h) {
|
|
%p = alloca <2 x i64>, i32 %h
|
|
call void @bar(<2 x i64>* %p)
|
|
ret void
|
|
; CHECK: foo
|
|
; CHECK-NOT: andl $-32, %eax
|
|
}
|
|
|
|
define void @foo2(i32 %h) {
|
|
%p = alloca <2 x i64>, i32 %h, align 32
|
|
call void @bar(<2 x i64>* %p)
|
|
ret void
|
|
; CHECK: foo2
|
|
; CHECK: andl $-32, %esp
|
|
; CHECK: andl $-32, %e{{..}}
|
|
}
|