mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-31 07:52:55 +01:00
b3ecd3b03e
System z branches have a mask to select which of the 4 CC values should cause the branch to be taken. We can invert a branch by inverting the mask. However, not all instructions can produce all 4 CC values, so inverting the branch like this can lead to some oddities. For example, integer comparisons only produce a CC of 0 (equal), 1 (less) or 2 (greater). If an integer EQ is reversed to NE before instruction selection, the branch will test for 1 or 2. If instead the branch is reversed after instruction selection (by inverting the mask), it will test for 1, 2 or 3. Both are correct, but the second isn't really canonical. This patch therefore keeps track of which CC values are possible and uses this when inverting a mask. Although this is mostly cosmestic, it fixes undefined behavior for the CIJNLH in branch-08.ll. Another fix would have been to mask out bit 0 when generating the fused compare and branch, but the point of this patch is that we shouldn't need to do that in the first place. The patch also makes it easier to reuse CC results from other instructions. llvm-svn: 187495
323 lines
8.4 KiB
LLVM
323 lines
8.4 KiB
LLVM
; Test 32-bit conditional stores that are presented as selects.
|
|
;
|
|
; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s
|
|
|
|
declare void @foo(i32 *)
|
|
|
|
; Test the simple case, with the loaded value first.
|
|
define void @f1(i32 *%ptr, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f1:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; ...and with the loaded value second
|
|
define void @f2(i32 *%ptr, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f2:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jhe [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %alt, i32 %orig
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Test cases where the value is explicitly sign-extended to 64 bits, with the
|
|
; loaded value first.
|
|
define void @f3(i32 *%ptr, i64 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f3:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%ext = sext i32 %orig to i64
|
|
%res = select i1 %cond, i64 %ext, i64 %alt
|
|
%trunc = trunc i64 %res to i32
|
|
store i32 %trunc, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; ...and with the loaded value second
|
|
define void @f4(i32 *%ptr, i64 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f4:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jhe [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%ext = sext i32 %orig to i64
|
|
%res = select i1 %cond, i64 %alt, i64 %ext
|
|
%trunc = trunc i64 %res to i32
|
|
store i32 %trunc, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Test cases where the value is explicitly zero-extended to 32 bits, with the
|
|
; loaded value first.
|
|
define void @f5(i32 *%ptr, i64 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f5:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%ext = zext i32 %orig to i64
|
|
%res = select i1 %cond, i64 %ext, i64 %alt
|
|
%trunc = trunc i64 %res to i32
|
|
store i32 %trunc, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; ...and with the loaded value second
|
|
define void @f6(i32 *%ptr, i64 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f6:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jhe [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%ext = zext i32 %orig to i64
|
|
%res = select i1 %cond, i64 %alt, i64 %ext
|
|
%trunc = trunc i64 %res to i32
|
|
store i32 %trunc, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check the high end of the aligned ST range.
|
|
define void @f7(i32 *%base, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f7:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: st %r3, 4092(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%ptr = getelementptr i32 *%base, i64 1023
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check the next word up, which should use STY instead of ST.
|
|
define void @f8(i32 *%base, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f8:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: sty %r3, 4096(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%ptr = getelementptr i32 *%base, i64 1024
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check the high end of the aligned STY range.
|
|
define void @f9(i32 *%base, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f9:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: sty %r3, 524284(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%ptr = getelementptr i32 *%base, i64 131071
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check the next word up, which needs separate address logic.
|
|
; Other sequences besides this one would be OK.
|
|
define void @f10(i32 *%base, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f10:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: agfi %r2, 524288
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%ptr = getelementptr i32 *%base, i64 131072
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check the low end of the STY range.
|
|
define void @f11(i32 *%base, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f11:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: sty %r3, -524288(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%ptr = getelementptr i32 *%base, i64 -131072
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check the next word down, which needs separate address logic.
|
|
; Other sequences besides this one would be OK.
|
|
define void @f12(i32 *%base, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f12:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: agfi %r2, -524292
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%ptr = getelementptr i32 *%base, i64 -131073
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check that STY allows an index.
|
|
define void @f13(i64 %base, i64 %index, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f13:
|
|
; CHECK-NOT: %r2
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r2
|
|
; CHECK: sty %r4, 4096(%r3,%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: br %r14
|
|
%add1 = add i64 %base, %index
|
|
%add2 = add i64 %add1, 4096
|
|
%ptr = inttoptr i64 %add2 to i32 *
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check that volatile loads are not matched.
|
|
define void @f14(i32 *%ptr, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f14:
|
|
; CHECK: l {{%r[0-5]}}, 0(%r2)
|
|
; CHECK: {{jl|jnl}} [[LABEL:[^ ]*]]
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: st {{%r[0-5]}}, 0(%r2)
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load volatile i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; ...likewise stores. In this case we should have a conditional load into %r3.
|
|
define void @f15(i32 *%ptr, i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f15:
|
|
; CHECK: jhe [[LABEL:[^ ]*]]
|
|
; CHECK: l %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: st %r3, 0(%r2)
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store volatile i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; Check that atomic loads are not matched. The transformation is OK for
|
|
; the "unordered" case tested here, but since we don't try to handle atomic
|
|
; operations at all in this context, it seems better to assert that than
|
|
; to restrict the test to a stronger ordering.
|
|
define void @f16(i32 *%ptr, i32 %alt, i32 %limit) {
|
|
; FIXME: should use a normal load instead of CS.
|
|
; CHECK-LABEL: f16:
|
|
; CHECK: cs {{%r[0-5]}}, {{%r[0-5]}}, 0(%r2)
|
|
; CHECK: {{jl|jnl}} [[LABEL:[^ ]*]]
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: st {{%r[0-5]}}, 0(%r2)
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load atomic i32 *%ptr unordered, align 4
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
ret void
|
|
}
|
|
|
|
; ...likewise stores.
|
|
define void @f17(i32 *%ptr, i32 %alt, i32 %limit) {
|
|
; FIXME: should use a normal store instead of CS.
|
|
; CHECK-LABEL: f17:
|
|
; CHECK: jhe [[LABEL:[^ ]*]]
|
|
; CHECK: l %r3, 0(%r2)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: cs {{%r[0-5]}}, %r3, 0(%r2)
|
|
; CHECK: br %r14
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store atomic i32 %res, i32 *%ptr unordered, align 4
|
|
ret void
|
|
}
|
|
|
|
; Try a frame index base.
|
|
define void @f18(i32 %alt, i32 %limit) {
|
|
; CHECK-LABEL: f18:
|
|
; CHECK: brasl %r14, foo@PLT
|
|
; CHECK-NOT: %r15
|
|
; CHECK: jl [[LABEL:[^ ]*]]
|
|
; CHECK-NOT: %r15
|
|
; CHECK: st {{%r[0-9]+}}, {{[0-9]+}}(%r15)
|
|
; CHECK: [[LABEL]]:
|
|
; CHECK: brasl %r14, foo@PLT
|
|
; CHECK: br %r14
|
|
%ptr = alloca i32
|
|
call void @foo(i32 *%ptr)
|
|
%cond = icmp ult i32 %limit, 42
|
|
%orig = load i32 *%ptr
|
|
%res = select i1 %cond, i32 %orig, i32 %alt
|
|
store i32 %res, i32 *%ptr
|
|
call void @foo(i32 *%ptr)
|
|
ret void
|
|
}
|