mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
97a2ec64f5
Summary: This hopefully fixes PR28825. The problem now was that a value from the original loop was used in a subloop, which became a sibling after separation. While a subloop doesn't need an lcssa phi node, a sibling does, and that's where we broke LCSSA. The most natural way to fix this now is to simply call formLCSSA on the original loop: it'll do what we've been doing before plus it'll cover situations described above. I think we don't need to run formLCSSARecursively here, and we have an assert to verify this (I've tried testing it on LLVM testsuite + SPECs). I'd be happy to be corrected here though. I also changed a run line in the test from '-lcssa -loop-unroll' to '-lcssa -loop-simplify -indvars', because it exercises LCSSA preservation to the same extent, but also makes less unrelated transformation on the CFG, which makes it easier to verify. Reviewers: chandlerc, sanjoy, silvas Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D23288 llvm-svn: 278173 |
||
|---|---|---|
| .. | ||
| 2003-04-25-AssertFail.ll | ||
| 2003-05-12-PreheaderExitOfChild.ll | ||
| 2003-08-15-PreheadersFail.ll | ||
| 2003-12-10-ExitBlocksProblem.ll | ||
| 2004-02-05-DominatorInfoCorruption.ll | ||
| 2004-03-15-IncorrectDomUpdate.ll | ||
| 2004-04-01-IncorrectDomUpdate.ll | ||
| 2004-04-12-LoopSimplify-SwitchBackedges.ll | ||
| 2004-04-13-LoopSimplifyUpdateDomFrontier.ll | ||
| 2007-10-28-InvokeCrash.ll | ||
| 2010-07-15-IncorrectDomFrontierUpdate.ll | ||
| 2010-12-26-PHIInfiniteLoop.ll | ||
| 2011-12-14-LandingpadHeader.ll | ||
| 2012-03-20-indirectbr.ll | ||
| ashr-crash.ll | ||
| basictest.ll | ||
| dbg-loc.ll | ||
| dup-preds.ll | ||
| hardertest.ll | ||
| indirectbr-backedge.ll | ||
| indirectbr.ll | ||
| merge-exits.ll | ||
| notify-scev.ll | ||
| phi-node-simplify.ll | ||
| pr26682.ll | ||
| pr28272.ll | ||
| preserve-scev.ll | ||
| single-backedge.ll | ||
| unreachable-loop-pred.ll | ||