mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-01-31 20:51:52 +01:00
fcbd79805b
The normal dataflow sequence in the ARC optimizer consists of the following
states:
Retain -> CanRelease -> Use -> Release
The optimizer before this patch stored the uses that determine the lifetime of
the retainable object pointer when it bottom up hits a retain or when top down
it hits a release. This is correct for an imprecise lifetime scenario since what
we are trying to do is remove retains/releases while making sure that no
``CanRelease'' (which is usually a call) deallocates the given pointer before we
get to the ``Use'' (since that would cause a segfault).
If we are considering the precise lifetime scenario though, this is not
correct. In such a situation, we *DO* care about the previous sequence, but
additionally, we wish to track the uses resulting from the following incomplete
sequences:
Retain -> CanRelease -> Release (TopDown)
Retain <- Use <- Release (BottomUp)
*NOTE* This patch looks large but the most of it consists of updating
test cases. Additionally this fix exposed an additional bug. I removed
the test case that expressed said bug and will recommit it with the fix
in a little bit.
llvm-svn: 178921
115 lines
4.1 KiB
LLVM
115 lines
4.1 KiB
LLVM
; RUN: opt -basicaa -objc-arc -S < %s | FileCheck %s
|
|
|
|
target datalayout = "e-p:64:64:64"
|
|
|
|
declare i8* @objc_retain(i8*)
|
|
declare i8* @objc_retainAutorelease(i8*)
|
|
declare void @objc_release(i8*)
|
|
declare i8* @objc_autorelease(i8*)
|
|
|
|
declare void @clang.arc.use(...)
|
|
|
|
declare void @test0_helper(i8*, i8**)
|
|
|
|
; Ensure that we honor clang.arc.use as a use and don't miscompile
|
|
; the reduced test case from <rdar://13195034>.
|
|
;
|
|
; FIXME: the fact that we re-order retains w.r.t. @clang.arc.use could
|
|
; be problematic if we get run twice, e.g. under LTO.
|
|
;
|
|
; CHECK: define void @test0(
|
|
; CHECK: @objc_retain(i8* %x)
|
|
; CHECK-NEXT: store i8* %y, i8** %temp0
|
|
; CHECK-NEXT: @objc_retain(i8* %y)
|
|
; CHECK-NEXT: call void @test0_helper
|
|
; CHECK-NEXT: [[VAL1:%.*]] = load i8** %temp0
|
|
; CHECK-NEXT: call void (...)* @clang.arc.use(i8* %y)
|
|
; CHECK-NEXT: @objc_retain(i8* [[VAL1]])
|
|
; CHECK-NEXT: @objc_release(i8* %y)
|
|
; CHECK-NEXT: store i8* [[VAL1]], i8** %temp1
|
|
; CHECK-NEXT: call void @test0_helper
|
|
; CHECK-NEXT: [[VAL2:%.*]] = load i8** %temp1
|
|
; CHECK-NEXT: call void (...)* @clang.arc.use(i8* [[VAL1]])
|
|
; CHECK-NEXT: @objc_retain(i8* [[VAL2]])
|
|
; CHECK-NEXT: @objc_release(i8* [[VAL1]])
|
|
; CHECK-NEXT: @objc_autorelease(i8* %x)
|
|
; CHECK-NEXT: store i8* %x, i8** %out
|
|
; CHECK-NEXT: @objc_retain(i8* %x)
|
|
; CHECK-NEXT: @objc_release(i8* [[VAL2]])
|
|
; CHECK-NEXT: @objc_release(i8* %x)
|
|
; CHECK-NEXT: ret void
|
|
define void @test0(i8** %out, i8* %x, i8* %y) {
|
|
entry:
|
|
%temp0 = alloca i8*, align 8
|
|
%temp1 = alloca i8*, align 8
|
|
%0 = call i8* @objc_retain(i8* %x) nounwind
|
|
%1 = call i8* @objc_retain(i8* %y) nounwind
|
|
store i8* %y, i8** %temp0
|
|
call void @test0_helper(i8* %x, i8** %temp0)
|
|
%val1 = load i8** %temp0
|
|
%2 = call i8* @objc_retain(i8* %val1) nounwind
|
|
call void (...)* @clang.arc.use(i8* %y) nounwind
|
|
call void @objc_release(i8* %y) nounwind
|
|
store i8* %val1, i8** %temp1
|
|
call void @test0_helper(i8* %x, i8** %temp1)
|
|
%val2 = load i8** %temp1
|
|
%3 = call i8* @objc_retain(i8* %val2) nounwind
|
|
call void (...)* @clang.arc.use(i8* %val1) nounwind
|
|
call void @objc_release(i8* %val1) nounwind
|
|
%4 = call i8* @objc_retain(i8* %x) nounwind
|
|
%5 = call i8* @objc_autorelease(i8* %x) nounwind
|
|
store i8* %x, i8** %out
|
|
call void @objc_release(i8* %val2) nounwind
|
|
call void @objc_release(i8* %x) nounwind
|
|
ret void
|
|
}
|
|
|
|
; CHECK: define void @test0a(
|
|
; CHECK: @objc_retain(i8* %x)
|
|
; CHECK-NEXT: store i8* %y, i8** %temp0
|
|
; CHECK-NEXT: @objc_retain(i8* %y)
|
|
; CHECK-NEXT: call void @test0_helper
|
|
; CHECK-NEXT: [[VAL1:%.*]] = load i8** %temp0
|
|
; CHECK-NEXT: call void (...)* @clang.arc.use(i8* %y)
|
|
; CHECK-NEXT: @objc_retain(i8* [[VAL1]])
|
|
; CHECK-NEXT: @objc_release(i8* %y)
|
|
; CHECK-NEXT: store i8* [[VAL1]], i8** %temp1
|
|
; CHECK-NEXT: call void @test0_helper
|
|
; CHECK-NEXT: [[VAL2:%.*]] = load i8** %temp1
|
|
; CHECK-NEXT: call void (...)* @clang.arc.use(i8* [[VAL1]])
|
|
; CHECK-NEXT: @objc_retain(i8* [[VAL2]])
|
|
; CHECK-NEXT: @objc_release(i8* [[VAL1]])
|
|
; CHECK-NEXT: @objc_autorelease(i8* %x)
|
|
; CHECK-NEXT: @objc_release(i8* [[VAL2]])
|
|
; CHECK-NEXT: store i8* %x, i8** %out
|
|
; CHECK-NEXT: ret void
|
|
define void @test0a(i8** %out, i8* %x, i8* %y) {
|
|
entry:
|
|
%temp0 = alloca i8*, align 8
|
|
%temp1 = alloca i8*, align 8
|
|
%0 = call i8* @objc_retain(i8* %x) nounwind
|
|
%1 = call i8* @objc_retain(i8* %y) nounwind
|
|
store i8* %y, i8** %temp0
|
|
call void @test0_helper(i8* %x, i8** %temp0)
|
|
%val1 = load i8** %temp0
|
|
%2 = call i8* @objc_retain(i8* %val1) nounwind
|
|
call void (...)* @clang.arc.use(i8* %y) nounwind
|
|
call void @objc_release(i8* %y) nounwind, !clang.imprecise_release !0
|
|
store i8* %val1, i8** %temp1
|
|
call void @test0_helper(i8* %x, i8** %temp1)
|
|
%val2 = load i8** %temp1
|
|
%3 = call i8* @objc_retain(i8* %val2) nounwind
|
|
call void (...)* @clang.arc.use(i8* %val1) nounwind
|
|
call void @objc_release(i8* %val1) nounwind, !clang.imprecise_release !0
|
|
%4 = call i8* @objc_retain(i8* %x) nounwind
|
|
%5 = call i8* @objc_autorelease(i8* %x) nounwind
|
|
store i8* %x, i8** %out
|
|
call void @objc_release(i8* %val2) nounwind, !clang.imprecise_release !0
|
|
call void @objc_release(i8* %x) nounwind, !clang.imprecise_release !0
|
|
ret void
|
|
}
|
|
|
|
|
|
!0 = metadata !{}
|
|
|