mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
93d80a543f
When sampleFDO is enabled, people may expect they can use -fno-profile-sample-use to opt-out using sample profile for a certain file. That could be either for debugging purpose or for performance tuning purpose. However, when thinlto is enabled, if a function in file A compiled with -fno-profile-sample-use is imported to another file B compiled with -fprofile-sample-use, the inlined copy of the function in file B may still get its profile annotated. The inconsistency may even introduce profile unused warning because if the target is not compiled with explicit debug information flag, the function in file A won't have its debug information enabled (debug information will be enabled implicitly only when -fprofile-sample-use is used). After it is imported into file B which is compiled with -fprofile-sample-use, profile annotation for the outline copy of the function will fail because the function has no debug information, and that will trigger profile unused warning. We add a new attribute use-sample-profile to control whether a function will use its sample profile no matter for its outline or inline copies. That will make the behavior of -fno-profile-sample-use consistent. Differential Revision: https://reviews.llvm.org/D79959
51 lines
1.3 KiB
LLVM
51 lines
1.3 KiB
LLVM
; RUN: opt < %s -passes=inline -inline-threshold=100 -S | FileCheck %s
|
|
|
|
;; caller1/caller2/callee1/callee2 test functions with incompatible attributes
|
|
;; won't be inlined into each other.
|
|
|
|
define i32 @callee1(i32 %x) {
|
|
%x1 = add i32 %x, 1
|
|
%x2 = add i32 %x1, 1
|
|
%x3 = add i32 %x2, 1
|
|
call void @extern()
|
|
ret i32 %x3
|
|
}
|
|
|
|
define i32 @callee2(i32 %x) #0 {
|
|
%x1 = add i32 %x, 1
|
|
%x2 = add i32 %x1, 1
|
|
%x3 = add i32 %x2, 1
|
|
call void @extern()
|
|
ret i32 %x3
|
|
}
|
|
|
|
define i32 @caller1(i32 %y1) {
|
|
;; caller1 doesn't have use-sample-profile attribute but callee2 has,
|
|
;; so callee2 won't be inlined into caller1.
|
|
;; caller1 and callee1 don't have use-sample-profile attribute, so
|
|
;; callee1 can be inlined into caller1.
|
|
; CHECK-LABEL: @caller1(
|
|
; CHECK: call i32 @callee2
|
|
; CHECK-NOT: call i32 @callee1
|
|
%y2 = call i32 @callee2(i32 %y1)
|
|
%y3 = call i32 @callee1(i32 %y2)
|
|
ret i32 %y3
|
|
}
|
|
|
|
define i32 @caller2(i32 %y1) #0 {
|
|
;; caller2 and callee2 both have use-sample-profile attribute, so
|
|
;; callee2 can be inlined into caller2.
|
|
;; caller2 has use-sample-profile attribute but callee1 doesn't have,
|
|
;; so callee1 won't be inlined into caller2.
|
|
; CHECK-LABEL: @caller2(
|
|
; CHECK-NOT: call i32 @callee2
|
|
; CHECK: call i32 @callee1
|
|
%y2 = call i32 @callee2(i32 %y1)
|
|
%y3 = call i32 @callee1(i32 %y2)
|
|
ret i32 %y3
|
|
}
|
|
|
|
declare void @extern()
|
|
|
|
attributes #0 = { "use-sample-profile" }
|