mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
62 lines
2.3 KiB
LLVM
62 lines
2.3 KiB
LLVM
; RUN: not llvm-as -disable-output <%s 2>&1 | FileCheck %s
|
|
define void @foo() {
|
|
entry:
|
|
call void @llvm.dbg.value(
|
|
metadata i8* undef,
|
|
i64 0,
|
|
metadata !DILocalVariable(scope: !1),
|
|
metadata !DIExpression())
|
|
; CHECK-LABEL: llvm.dbg.value intrinsic requires a !dbg attachment
|
|
; CHECK-NEXT: call void @llvm.dbg.value({{.*}})
|
|
; CHECK-NEXT: label %entry
|
|
; CHECK-NEXT: void ()* @foo
|
|
|
|
call void @llvm.dbg.declare(
|
|
metadata i8* undef,
|
|
metadata !DILocalVariable(scope: !1),
|
|
metadata !DIExpression())
|
|
; CHECK-LABEL: llvm.dbg.declare intrinsic requires a !dbg attachment
|
|
; CHECK-NEXT: call void @llvm.dbg.declare({{.*}})
|
|
; CHECK-NEXT: label %entry
|
|
; CHECK-NEXT: void ()* @foo
|
|
|
|
call void @llvm.dbg.value(
|
|
metadata i8* undef,
|
|
i64 0,
|
|
metadata !DILocalVariable(scope: !1),
|
|
metadata !DIExpression()),
|
|
!dbg !DILocation(scope: !2)
|
|
; CHECK-LABEL: mismatched subprogram between llvm.dbg.value variable and !dbg attachment
|
|
; CHECK-NEXT: call void @llvm.dbg.value({{[^,]+, [^,]+}}, metadata ![[VAR:[0-9]+]], {{[^,]+}}), !dbg ![[LOC:[0-9]+]]
|
|
; CHECK-NEXT: label %entry
|
|
; CHECK-NEXT: void ()* @foo
|
|
; CHECK-NEXT: ![[VAR]] = !DILocalVariable({{.*}}scope: ![[VARSP:[0-9]+]]
|
|
; CHECK-NEXT: ![[VARSP]] = distinct !DISubprogram(
|
|
; CHECK-NEXT: ![[LOC]] = !DILocation({{.*}}scope: ![[LOCSP:[0-9]+]]
|
|
; CHECK-NEXT: ![[LOCSP]] = distinct !DISubprogram(
|
|
|
|
call void @llvm.dbg.declare(
|
|
metadata i8* undef,
|
|
metadata !DILocalVariable(scope: !1),
|
|
metadata !DIExpression()),
|
|
!dbg !DILocation(scope: !2)
|
|
; CHECK-LABEL: mismatched subprogram between llvm.dbg.declare variable and !dbg attachment
|
|
; CHECK-NEXT: call void @llvm.dbg.declare({{[^,]+}}, metadata ![[VAR:[0-9]+]], {{.*[^,]+}}), !dbg ![[LOC:[0-9]+]]
|
|
; CHECK-NEXT: label %entry
|
|
; CHECK-NEXT: void ()* @foo
|
|
; CHECK-NEXT: ![[VAR]] = !DILocalVariable({{.*}}scope: ![[VARSP:[0-9]+]]
|
|
; CHECK-NEXT: ![[VARSP]] = distinct !DISubprogram(
|
|
; CHECK-NEXT: ![[LOC]] = !DILocation({{.*}}scope: ![[LOCSP:[0-9]+]]
|
|
; CHECK-NEXT: ![[LOCSP]] = distinct !DISubprogram(
|
|
|
|
ret void
|
|
}
|
|
|
|
declare void @llvm.dbg.value(metadata, i64, metadata, metadata)
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata)
|
|
|
|
!llvm.module.flags = !{!0}
|
|
!0 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!1 = distinct !DISubprogram(name: "foo")
|
|
!2 = distinct !DISubprogram(name: "bar")
|