mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-18 18:42:46 +02:00
7a1a2170b7
For `.bss; nop`, MC inappropriately calls abort() (via report_fatal_error()) with a message `cannot have fixups in virtual section!` It is a bug to crash for invalid user input. Fix it by erroring out early in EmitInstToData(). Similarly, emitIntValue() in a virtual section (SHT_NOBITS in ELF) can crash with the mssage `non-zero initializer found in section '.bss'` (see D4199) It'd be nice to report the location but so many directives can call emitIntValue() and it is difficult to track every location. Note, COFF does not crash because MCAssembler::writeSectionData() is not called for an IMAGE_SCN_CNT_UNINITIALIZED_DATA section. Note, GNU as' arm64 backend reports ``Error: attempt to store non-zero value in section `.bss'`` for a non-zero .inst but fails to do so for other instructions. We simply reject all instructions, even if the encoding is all zeros. The Mach-O counterpart is D48517 (see `test/MC/MachO/zerofill-text.s`) Reviewed By: rnk, skan Differential Revision: https://reviews.llvm.org/D78138
118 lines
3.5 KiB
C++
118 lines
3.5 KiB
C++
//===- lib/MC/MCSectionCOFF.cpp - COFF Code Section Representation --------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/MC/MCSectionCOFF.h"
|
|
#include "llvm/BinaryFormat/COFF.h"
|
|
#include "llvm/MC/MCSymbol.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
#include <cassert>
|
|
|
|
using namespace llvm;
|
|
|
|
// ShouldOmitSectionDirective - Decides whether a '.section' directive
|
|
// should be printed before the section name
|
|
bool MCSectionCOFF::ShouldOmitSectionDirective(StringRef Name,
|
|
const MCAsmInfo &MAI) const {
|
|
if (COMDATSymbol)
|
|
return false;
|
|
|
|
// FIXME: Does .section .bss/.data/.text work everywhere??
|
|
if (Name == ".text" || Name == ".data" || Name == ".bss")
|
|
return true;
|
|
|
|
return false;
|
|
}
|
|
|
|
void MCSectionCOFF::setSelection(int Selection) const {
|
|
assert(Selection != 0 && "invalid COMDAT selection type");
|
|
this->Selection = Selection;
|
|
Characteristics |= COFF::IMAGE_SCN_LNK_COMDAT;
|
|
}
|
|
|
|
void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
|
|
raw_ostream &OS,
|
|
const MCExpr *Subsection) const {
|
|
// standard sections don't require the '.section'
|
|
if (ShouldOmitSectionDirective(getName(), MAI)) {
|
|
OS << '\t' << getName() << '\n';
|
|
return;
|
|
}
|
|
|
|
OS << "\t.section\t" << getName() << ",\"";
|
|
if (getCharacteristics() & COFF::IMAGE_SCN_CNT_INITIALIZED_DATA)
|
|
OS << 'd';
|
|
if (getCharacteristics() & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)
|
|
OS << 'b';
|
|
if (getCharacteristics() & COFF::IMAGE_SCN_MEM_EXECUTE)
|
|
OS << 'x';
|
|
if (getCharacteristics() & COFF::IMAGE_SCN_MEM_WRITE)
|
|
OS << 'w';
|
|
else if (getCharacteristics() & COFF::IMAGE_SCN_MEM_READ)
|
|
OS << 'r';
|
|
else
|
|
OS << 'y';
|
|
if (getCharacteristics() & COFF::IMAGE_SCN_LNK_REMOVE)
|
|
OS << 'n';
|
|
if (getCharacteristics() & COFF::IMAGE_SCN_MEM_SHARED)
|
|
OS << 's';
|
|
if ((getCharacteristics() & COFF::IMAGE_SCN_MEM_DISCARDABLE) &&
|
|
!isImplicitlyDiscardable(getName()))
|
|
OS << 'D';
|
|
OS << '"';
|
|
|
|
if (getCharacteristics() & COFF::IMAGE_SCN_LNK_COMDAT) {
|
|
if (COMDATSymbol)
|
|
OS << ",";
|
|
else
|
|
OS << "\n\t.linkonce\t";
|
|
switch (Selection) {
|
|
case COFF::IMAGE_COMDAT_SELECT_NODUPLICATES:
|
|
OS << "one_only";
|
|
break;
|
|
case COFF::IMAGE_COMDAT_SELECT_ANY:
|
|
OS << "discard";
|
|
break;
|
|
case COFF::IMAGE_COMDAT_SELECT_SAME_SIZE:
|
|
OS << "same_size";
|
|
break;
|
|
case COFF::IMAGE_COMDAT_SELECT_EXACT_MATCH:
|
|
OS << "same_contents";
|
|
break;
|
|
case COFF::IMAGE_COMDAT_SELECT_ASSOCIATIVE:
|
|
OS << "associative";
|
|
break;
|
|
case COFF::IMAGE_COMDAT_SELECT_LARGEST:
|
|
OS << "largest";
|
|
break;
|
|
case COFF::IMAGE_COMDAT_SELECT_NEWEST:
|
|
OS << "newest";
|
|
break;
|
|
default:
|
|
assert(false && "unsupported COFF selection type");
|
|
break;
|
|
}
|
|
if (COMDATSymbol) {
|
|
OS << ",";
|
|
COMDATSymbol->print(OS, &MAI);
|
|
}
|
|
}
|
|
OS << '\n';
|
|
}
|
|
|
|
bool MCSectionCOFF::UseCodeAlign() const {
|
|
return getKind().isText();
|
|
}
|
|
|
|
bool MCSectionCOFF::isVirtualSection() const {
|
|
return getCharacteristics() & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA;
|
|
}
|
|
|
|
StringRef MCSectionCOFF::getVirtualSectionKind() const {
|
|
return "IMAGE_SCN_CNT_UNINITIALIZED_DATA";
|
|
}
|