RPCS3/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2024-11-22 02:32:36 +01:00
Code Issues Releases Wiki Activity

Update based on feedback by GovanifY

Browse Source
This commit is contained in:
shinra-electric 2022-10-08 23:01:41 +02:00 committed by kd-11
parent fa744e53d3
commit 151d98df51
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
3rdparty/pine/pine_server.h vendored
View File

@ -267,7 +267,6 @@ namespace pine
char version[256] = {}; char version[256] = {};
snprintf(version, sizeof(version), "RPCS3 %s", Impl::get_version_and_branch().c_str()); snprintf(version, sizeof(version), "RPCS3 %s", Impl::get_version_and_branch().c_str());
const u32 size = strlen(version) + 1; const u32 size = strlen(version) + 1;
version[size] = 0x00;
if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size)) if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size))
goto error; goto error;
ToArray(ret_buffer, size, ret_cnt); ToArray(ret_buffer, size, ret_cnt);
@ -291,8 +290,7 @@ namespace pine
const auto title_string = Impl::get_title(); const auto title_string = Impl::get_title();
const auto size = title_string.size() + 1; const auto size = title_string.size() + 1;
char* title = new char[size]; char* title = new char[size];
snprintf(title, sizeof(title), "%s", title_string.c_str()); snprintf(title, size, "%s", title_string.c_str());
title[size] = 0x00;
if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size)) if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size))
goto error; goto error;
ToArray(ret_buffer, size, ret_cnt); ToArray(ret_buffer, size, ret_cnt);
@ -307,8 +305,7 @@ namespace pine
const auto title_id_string = Impl::get_title_ID(); const auto title_id_string = Impl::get_title_ID();
const auto size = title_id_string.size() + 1; const auto size = title_id_string.size() + 1;
char* title_id = new char[size]; char* title_id = new char[size];
snprintf(title_id, sizeof(title_id), "%s", title_id_string.c_str()); snprintf(title_id, size, "%s", title_id_string.c_str());
title_id[size] = 0x00;
if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size)) if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size))
goto error; goto error;
ToArray(ret_buffer, size, ret_cnt); ToArray(ret_buffer, size, ret_cnt);
@ -323,8 +320,7 @@ namespace pine
const auto hash_string = Impl::get_executable_hash(); const auto hash_string = Impl::get_executable_hash();
const auto size = hash_string.size() + 1; const auto size = hash_string.size() + 1;
char* hash = new char[size]; char* hash = new char[size];
snprintf(hash, sizeof(hash), "%s", hash_string.c_str()); snprintf(hash, size, "%s", hash_string.c_str());
hash[size] = 0x00;
if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size)) if (!SafetyChecks(buf_cnt, 0, ret_cnt, size + 4, buf_size))
goto error; goto error;
ToArray(ret_buffer, size, ret_cnt); ToArray(ret_buffer, size, ret_cnt);
@ -339,8 +335,7 @@ namespace pine
const auto game_version_string = Impl::get_app_version(); const auto game_version_string = Impl::get_app_version();
const auto size = game_version_string.size() + 1; const auto size = game_version_string.size() + 1;
char* game_version = new char[size]; char* game_version = new char[size];
snprintf(game_version, sizeof(game_version), "%s", game_version_string.c_str()); snprintf(game_version, size, "%s", game_version_string.c_str());
game_version[size] = 0x00;
if (!SafetyChecks(buf_cnt, 0, ret_cnt, size, buf_size)) if (!SafetyChecks(buf_cnt, 0, ret_cnt, size, buf_size))
goto error; goto error;
ToArray(ret_buffer, size, ret_cnt); ToArray(ret_buffer, size, ret_cnt);