stdafx.h: remove BOM from custom included headers

Also add warnings about adding them.

Utilities/BEType.h

@@ -1,5 +1,4 @@
-#ifndef BETYPE_H_GUARD
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
-#define BETYPE_H_GUARD
 
 #include "types.h"
 #include "util/endian.hpp"
@@ -510,5 +509,3 @@ struct fmt_unveil<se_t<T, Se, Align>, void>
 
 static_assert(be_t<u16>(1) + be_t<u32>(2) + be_t<u64>(3) == 6);
 static_assert(le_t<u16>(1) + le_t<u32>(2) + le_t<u64>(3) == 6);
-
-#endif // BETYPE_H_GUARD

Utilities/File.h

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
 
 #include "types.h"
 #include "bit_set.h"

Utilities/StrFmt.h

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
 
 #include "types.h"
 

Utilities/types.h

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
 
 #ifdef _MSC_VER
 #include <intrin.h>

rpcs3/stdafx.cpp

@@ -1 +1,5 @@
+// No BOM and only basic ASCII in this file, or a neko will die
 #include "stdafx.h"
+
+static_assert(be_t<u16>(1) + be_t<u32>(2) + be_t<u64>(3) == 6);
+static_assert(le_t<u16>(1) + le_t<u32>(2) + le_t<u64>(3) == 6);

rpcs3/stdafx.h

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
 
 #ifdef MSVC_CRT_MEMLEAK_DETECTION
 	#define _CRTDBG_MAP_ALLOC

rpcs3/util/atomic.hpp

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
 
 #include "Utilities/types.h"
 #include <functional>

rpcs3/util/endian.hpp

@@ -1,5 +1,4 @@
-#ifndef ENDIAN_HPP_GUARD
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
-#define ENDIAN_HPP_GUARD
 
 #include <cstdint>
 #include "Utilities/types.h"
@@ -492,5 +491,3 @@ public:
 		}
 	};
 }
-
-#endif // ENDIAN_HPP_GUARD

rpcs3/util/logs.hpp

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
 
 #include <cstdint>
 #include <atomic>

rpcs3/util/shared_ptr.hpp

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once // No BOM and only basic ASCII in this header, or a neko will die
 
 #include <cstdint>
 #include <memory>
@@ -9,10 +9,12 @@ namespace stx
 	template <typename T, typename U>
 	constexpr bool is_same_ptr() noexcept
 	{
-		// Should be possible if constexpr bit_cast is available?
+		// I would like to make it a trait if there is some trick.
+		// And believe it shall possible with constexpr bit_cast.
 		// Otherwise I hope it will compile in null code anyway.
 		const auto u = reinterpret_cast<U*>(0x11223344556);
-		return static_cast<T*>(u) == static_cast<void*>(u);
+		const volatile void* x = u;
+		return static_cast<T*>(u) == x;
 	}
 
 	// TODO