From 4357892081e7d3de7b8d62e18a4178ef17b30fb8 Mon Sep 17 00:00:00 2001 From: Ani Date: Wed, 29 Aug 2018 01:55:43 +0100 Subject: [PATCH] Bump CMake Requirement to 3.8.2+ With older builds CMake will error out with `CXX_STANDARD is set to invalid value '17'` CXX_STANDARD 17 was added on CMake 3.8.X as found in the 3.8.2 documentation: https://cmake.org/cmake/help/v3.8/prop_tgt/CXX_STANDARD.html Also removes leftover from old VS2015/2017 mixed instructions, removes "Not GCC 6.1" since we require 7.3+ now and bumps Xcode to 10. Proper MacOS instructions will be added afterwards by someone else. --- CMakeLists.txt | 2 +- README.md | 9 ++++----- rpcs3/CMakeLists.txt | 2 +- rpcs3/cmake_modules/ConfigureCompiler.cmake | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a4bd368105..e93cbaafa1 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.1) +cmake_minimum_required(VERSION 3.8.2) option(WITH_GDB "WITH_GDB" OFF) option(WITHOUT_LLVM "WITHOUT_LLVM" OFF) diff --git a/README.md b/README.md index a8be3ac8f6..fc54454643 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ If you want to contribute please take a look at the [Coding Style](https://githu ### Windows * [Visual Studio 2017](https://www.visualstudio.com/en/downloads/) * [Visual C++ Redistributable Packages for Visual Studio 2017](https://go.microsoft.com/fwlink/?LinkId=746572) -* [Cmake 3.1.0+](https://www.cmake.org/download/) (add to PATH) +* [CMake 3.8.2+](https://www.cmake.org/download/) (add to PATH) * [Python 3.3+](https://www.python.org/downloads/) (add to PATH) * [Vulkan SDK](https://vulkan.lunarg.com/sdk/home) (See "Install the SDK" [here](https://vulkan.lunarg.com/doc/sdk/latest/windows/getting_started.html)) * [Qt 5.10+](https://www.qt.io/download-open-source/) @@ -32,7 +32,8 @@ If you want to contribute please take a look at the [Coding Style](https://githu ### Linux * [Qt 5.10+](https://www.qt.io/download-open-source/) -* GCC 7.3+ or Clang 5.0+ ([not GCC 6.1](https://github.com/RPCS3/rpcs3/issues/1691)) +* GCC 7.3+ or Clang 5.0+ +* CMake 3.8.2+ * Debian & Ubuntu: `sudo apt-get install cmake build-essential libasound2-dev libpulse-dev libopenal-dev libglew-dev zlib1g-dev libedit-dev libvulkan-dev libudev-dev git qt5-default` * Arch: `sudo pacman -S glew openal cmake vulkan-validation-layers qt5-base` * Fedora: `sudo dnf install alsa-lib-devel cmake glew glew-devel libatomic libevdev-devel libudev-devel openal-devel qt5-devel vulkan-devel` @@ -42,15 +43,13 @@ If you want to contribute please take a look at the [Coding Style](https://githu ### MacOS MacOS is not supported at this moment because it doesn't meet system requirements (OpenGL 4.3) -* Xcode 6+ (tested with Xcode 6.4) +* Xcode 10 * Install with Homebrew: `brew install glew llvm qt cmake` ## Building on Windows: To initialize the repository don't forget to execute `git submodule update --init` to pull the submodules. -*If you're using Visual Studio 2017, when you first open the project, do not upgrade the targets or the packages. Leave both at "No upgrade". Note that you will need the v140 toolset, which may not be in VS 2017 by default. It can be acquired by running the VS installer.* - ### Configuring the Qt plugin (if used) 1) Go to the Qt5 menu and edit Qt5 options. Add the path to your Qt installation with compiler e.g. `\5.11.1\msvc2017_64`. diff --git a/rpcs3/CMakeLists.txt b/rpcs3/CMakeLists.txt index 3260dce4bf..5b154a3702 100644 --- a/rpcs3/CMakeLists.txt +++ b/rpcs3/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.1) +cmake_minimum_required(VERSION 3.8.2) set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake_modules") set(RES_FILES "") diff --git a/rpcs3/cmake_modules/ConfigureCompiler.cmake b/rpcs3/cmake_modules/ConfigureCompiler.cmake index 13226dd922..ac39108739 100644 --- a/rpcs3/cmake_modules/ConfigureCompiler.cmake +++ b/rpcs3/cmake_modules/ConfigureCompiler.cmake @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 2.8.12) +cmake_minimum_required(VERSION 3.8.2) # Check and configure compiler options for RPCS3 if(CMAKE_COMPILER_IS_GNUCXX)