RPCS3/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2024-11-22 02:32:36 +01:00
Code Issues Releases Wiki Activity

Win32/File.cpp: Avoid potential race in concurrent writes

Browse Source 
Uninitialized data is better than overwritten data. Affects SPU Cache (unprotected writes).
This commit is contained in:
Eladash 2023-09-02 11:01:38 +03:00 committed by Elad Ashkenazi
parent 3f7afb8375
commit 66b6bae596
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Utilities/File.cpp
View File

@ -1303,12 +1303,12 @@ fs::file::file(const std::string& path, bs_t<open_mode> mode)
DWORD nwritten = 0; DWORD nwritten = 0;
OVERLAPPED ovl{}; OVERLAPPED ovl{};
const u64 pos = m_pos; const u64 pos = m_pos.fetch_add(size);
ovl.Offset = DWORD(pos); ovl.Offset = DWORD(pos);
ovl.OffsetHigh = DWORD(pos >> 32); ovl.OffsetHigh = DWORD(pos >> 32);
ensure(WriteFile(m_handle, data, size, &nwritten, &ovl)); // "file::write" ensure(WriteFile(m_handle, data, size, &nwritten, &ovl)); // "file::write"
ensure(nwritten == size);
nwritten_sum += nwritten; nwritten_sum += nwritten;
m_pos += nwritten;
if (nwritten < size) if (nwritten < size)
{ {