RPCS3/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2024-11-22 18:53:28 +01:00
Code Issues Releases Wiki Activity

rsx: Workaround for broken rtt resampling

Browse Source 
- Avoids WCB requirement for now to keep res scaling working correctly.
- TODO: Fix this properly
This commit is contained in:
kd-11 2020-01-25 14:39:46 +03:00 committed by kd-11
parent 698702cd4a
commit 79216917b3
1 changed files with 22 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
rpcs3/Emu/RSX/Common/texture_cache.h
View File

@ -1656,31 +1656,36 @@ namespace rsx
}
if (const auto section_count = result.external_subresource_desc.sections_to_copy.size();
section_count > 0 && result.atlas_covers_target_area(section_count == 1? 99 : 90))
section_count > 0)
{
// TODO: Overlapped section persistance is required for framebuffer resources to work with this!
// Yellow filter in SCV is because of a 384x384 surface being reused as 160x90 (and likely not getting written to)
// Its then sampled again here as 384x384 and this does not work! (obviously)
// TODO: Some games may render a small region (e.g 1024x256x2) and sample a huge texture (e.g 1024x1024).
// Seen in APF2k8 - this causes missing bits to be reuploaded from CPU which can cause WCB requirement.
// Properly fix this by introducing partial data upload into the surface cache in such cases and making RCB/RDB
// enabled by default. Blit engine already handles this correctly.
// Optionally disallow caching if resource is being written to as it is being read from
for (const auto& section : overlapping_fbos)
if (_pool == 0 || /* Hack to avoid WCB requirement for some games with wrongly declared sampler dimensions */
result.atlas_covers_target_area(section_count == 1? 99 : 90))
{
if (m_rtts.address_is_bound(section.base_address))
// Optionally disallow caching if resource is being written to as it is being read from
for (const auto& section : overlapping_fbos)
{
if (result.external_subresource_desc.op == deferred_request_command::copy_image_static)
if (m_rtts.address_is_bound(section.base_address))
{
result.external_subresource_desc.op = deferred_request_command::copy_image_dynamic;
}
else
{
result.external_subresource_desc.do_not_cache = true;
}
if (result.external_subresource_desc.op == deferred_request_command::copy_image_static)
{
result.external_subresource_desc.op = deferred_request_command::copy_image_dynamic;
}
else
{
result.external_subresource_desc.do_not_cache = true;
}
break;
break;
}
}
}
return result;
return result;
}
}
}
}