Simplify qstr function

rpcs3/rpcs3qt/about_dialog.cpp

@@ -6,7 +6,7 @@
 #include <QDesktopServices>
 #include <QUrl>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 about_dialog::about_dialog(QWidget* parent) : QDialog(parent), ui(new Ui::about_dialog)
 {

rpcs3/rpcs3qt/auto_pause_settings_dialog.cpp

@@ -1,7 +1,7 @@
 
 #include "auto_pause_settings_dialog.h"
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 auto_pause_settings_dialog::auto_pause_settings_dialog(QWidget *parent) : QDialog(parent)
 {

rpcs3/rpcs3qt/cg_disasm_window.cpp

@@ -16,7 +16,7 @@
 
 #include "Emu/RSX/CgBinaryProgram.h"
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 inline std::string sstr(const QString& _in) { return _in.toUtf8().toStdString(); }
 
 cg_disasm_window::cg_disasm_window(std::shared_ptr<gui_settings> xSettings, QWidget* parent): QWidget(parent), xgui_settings(xSettings)

rpcs3/rpcs3qt/debugger_frame.cpp

@@ -5,7 +5,7 @@
 #include <QFontDatabase>
 #include <QCompleter>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 extern bool user_asked_for_frame_capture;
 
 debugger_frame::debugger_frame(std::shared_ptr<gui_settings> settings, QWidget *parent)

rpcs3/rpcs3qt/emu_settings.h

@@ -11,7 +11,7 @@
 #include <QObject>
 #include <QComboBox>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 struct Render_Creator
 {

rpcs3/rpcs3qt/gs_frame.cpp

@@ -8,7 +8,7 @@
 #include <QTimer>
 #include <QThread>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 gs_frame::gs_frame(const QString& title, int w, int h, QIcon appIcon, bool disableMouse)
 	: QWindow(), m_windowTitle(title), m_disable_mouse(disableMouse)

rpcs3/rpcs3qt/instruction_editor_dialog.cpp

@@ -2,7 +2,7 @@
 #include "instruction_editor_dialog.h"
 #include <QFontDatabase>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 instruction_editor_dialog::instruction_editor_dialog(QWidget *parent, u32 _pc, const std::shared_ptr<cpu_thread>& _cpu, CPUDisAsm* _disasm)
 	: QDialog(parent)

rpcs3/rpcs3qt/kernel_explorer.cpp

@@ -60,7 +60,7 @@ kernel_explorer::kernel_explorer(QWidget* parent) : QDialog(parent)
 	Update();
 };
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 void kernel_explorer::Update()
 {

rpcs3/rpcs3qt/log_frame.cpp

@@ -8,7 +8,7 @@
 #include <QActionGroup>
 #include <QScrollBar>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 struct gui_listener : logs::listener
 {

rpcs3/rpcs3qt/memory_viewer_panel.cpp

@@ -3,7 +3,7 @@
 
 #include "memory_viewer_panel.h"
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 memory_viewer_panel::memory_viewer_panel(QWidget* parent) 
 	: QDialog(parent)

rpcs3/rpcs3qt/msg_dialog_frame.cpp

@@ -5,7 +5,7 @@
 #include <QScreen>
 #include <QThread>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), _in.size()); }
+constexpr auto qstr = QString::fromStdString;
 
 void msg_dialog_frame::Create(const std::string& msg)
 {

rpcs3/rpcs3qt/register_editor_dialog.cpp

@@ -1,7 +1,7 @@
 
 #include "register_editor_dialog.h"
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 inline std::string sstr(const QString& _in) { return _in.toUtf8().toStdString(); }
 inline std::string sstr(const QVariant& _in) { return sstr(_in.toString()); }
 

rpcs3/rpcs3qt/rsx_debugger.cpp

@@ -7,7 +7,7 @@ enum GCMEnumTypes
 	CELL_GCM_PRIMITIVE_ENUM,
 };
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), static_cast<int>(_in.size())); }
+constexpr auto qstr = QString::fromStdString;
 
 rsx_debugger::rsx_debugger(QWidget* parent)
 	: QDialog(parent)

rpcs3/rpcs3qt/save_data_info_dialog.cpp

@@ -4,7 +4,7 @@
 #include <QHBoxLayout>
 #include <QHeaderView>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), _in.size()); }
+constexpr auto qstr = QString::fromStdString;
 
 save_data_info_dialog::save_data_info_dialog(const SaveDataEntry& save, QWidget* parent)
 	: QDialog(parent), m_entry(save)

rpcs3/rpcs3qt/save_data_list_dialog.cpp

@@ -8,7 +8,7 @@
 #include <QHeaderView>
 #include <QMenu>
 
-inline QString qstr(const std::string& _in) { return QString::fromUtf8(_in.data(), _in.size()); }
+constexpr auto qstr = QString::fromStdString;
 
 //Show up the savedata list, either to choose one to save/load or to manage saves.
 //I suggest to use function callbacks to give save data list or get save data entry. (Not implemented or stubbed)