From f08d3e12caae81015a113a21fbb81ef76aa884ab Mon Sep 17 00:00:00 2001 From: Ani Date: Sun, 11 Jun 2023 20:52:46 +0100 Subject: [PATCH] Settings: Remove PPU Interpreter (dynamic) It has been unimplemented for a long while, so no point in displaying it, it can be added once the feature is implemented again --- rpcs3/Emu/system_config_types.cpp | 1 - rpcs3/Emu/system_config_types.h | 1 - rpcs3/rpcs3qt/emu_settings.cpp | 1 - rpcs3/rpcs3qt/settings_dialog.cpp | 4 ---- rpcs3/rpcs3qt/settings_dialog.ui | 7 ------- 5 files changed, 14 deletions(-) diff --git a/rpcs3/Emu/system_config_types.cpp b/rpcs3/Emu/system_config_types.cpp index 79bd61f11c..7324101a89 100644 --- a/rpcs3/Emu/system_config_types.cpp +++ b/rpcs3/Emu/system_config_types.cpp @@ -492,7 +492,6 @@ void fmt_class_string::format(std::string& out, u64 arg) switch (type) { case ppu_decoder_type::_static: return "Interpreter (static)"; - case ppu_decoder_type::dynamic: return "Interpreter (dynamic)"; case ppu_decoder_type::llvm: return "Recompiler (LLVM)"; } diff --git a/rpcs3/Emu/system_config_types.h b/rpcs3/Emu/system_config_types.h index 4e7446d2f5..cf1214a967 100644 --- a/rpcs3/Emu/system_config_types.h +++ b/rpcs3/Emu/system_config_types.h @@ -3,7 +3,6 @@ enum class ppu_decoder_type : unsigned { _static, - dynamic, llvm, }; diff --git a/rpcs3/rpcs3qt/emu_settings.cpp b/rpcs3/rpcs3qt/emu_settings.cpp index a7f69cfef4..13a5c01d05 100644 --- a/rpcs3/rpcs3qt/emu_settings.cpp +++ b/rpcs3/rpcs3qt/emu_settings.cpp @@ -1127,7 +1127,6 @@ QString emu_settings::GetLocalizedSetting(const QString& original, emu_settings_ switch (static_cast(index)) { case ppu_decoder_type::_static: return tr("Interpreter (static)", "PPU decoder"); - case ppu_decoder_type::dynamic: return tr("Interpreter (dynamic)", "PPU decoder"); case ppu_decoder_type::llvm: return tr("Recompiler (LLVM)", "PPU decoder"); } break; diff --git a/rpcs3/rpcs3qt/settings_dialog.cpp b/rpcs3/rpcs3qt/settings_dialog.cpp index bbc25fcf18..e9d2fe690a 100644 --- a/rpcs3/rpcs3qt/settings_dialog.cpp +++ b/rpcs3/rpcs3qt/settings_dialog.cpp @@ -383,12 +383,10 @@ settings_dialog::settings_dialog(std::shared_ptr gui_settings, std // PPU tool tips SubscribeTooltip(ui->ppu__static, tooltips.settings.ppu__static); - SubscribeTooltip(ui->ppu_dynamic, tooltips.settings.ppu_dynamic); SubscribeTooltip(ui->ppu_llvm, tooltips.settings.ppu_llvm); QButtonGroup *ppu_bg = new QButtonGroup(this); ppu_bg->addButton(ui->ppu__static, static_cast(ppu_decoder_type::_static)); - ppu_bg->addButton(ui->ppu_dynamic, static_cast(ppu_decoder_type::dynamic)); ppu_bg->addButton(ui->ppu_llvm, static_cast(ppu_decoder_type::llvm)); connect(ppu_bg, &QButtonGroup::idToggled, [this](int id, bool checked) @@ -402,7 +400,6 @@ settings_dialog::settings_dialog(std::shared_ptr gui_settings, std ui->accuratePPUNJ->setEnabled(true); ui->accuratePPUVNAN->setEnabled(true); break; - case static_cast(ppu_decoder_type::dynamic): case static_cast(ppu_decoder_type::llvm): ui->accuratePPUFPCC->setEnabled(false); ui->accuratePPUNJ->setEnabled(false); @@ -453,7 +450,6 @@ settings_dialog::settings_dialog(std::shared_ptr gui_settings, std ui->spu_llvm->setEnabled(false); ui->spu_dynamic->setEnabled(false); #endif - ui->ppu_dynamic->setEnabled(false); // _____ _____ _ _ _______ _ // / ____| __ \| | | | |__ __| | | diff --git a/rpcs3/rpcs3qt/settings_dialog.ui b/rpcs3/rpcs3qt/settings_dialog.ui index 02ea3ce9a5..b7c8ad3cdd 100644 --- a/rpcs3/rpcs3qt/settings_dialog.ui +++ b/rpcs3/rpcs3qt/settings_dialog.ui @@ -78,13 +78,6 @@ - - - - Interpreter (dynamic) - - -