From ba1cb7727eadb871eddbaeedf9b1e9aaadfcc17d Mon Sep 17 00:00:00 2001 From: Sam James Date: Sun, 24 Mar 2024 07:19:34 +0000 Subject: [PATCH] configure.ac: fix bashism in CXXFLAGS assignment configure scripts need to be runnable with a POSIX-compliant /bin/sh. On many (but not all!) systems, /bin/sh is provided by Bash, so errors like this aren't spotted. Notably Debian defaults to /bin/sh provided by dash which doesn't tolerate such bashisms as '=='. This retains compatibility with bash. Fixes configure warnings/errors like: ``` checking whether make supports nested variables... (cached) yes configure: 3698: CXXFLAGS+= -Ofast: not found ``` Signed-off-by: Sam James --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 837745e..ab0813d 100644 --- a/configure.ac +++ b/configure.ac @@ -33,7 +33,7 @@ AC_LANG(C++) # Compiler flags. Apply -Ofast (implies -O3 -ffast-math) to allow gcc autovectorization # generate effective SIMD code. -CXXFLAGS+=" -Ofast -Wall -Wextra -Wzero-as-null-pointer-constant -Wno-unknown-pragmas" +CXXFLAGS="${CXXFLAGS} -Ofast -Wall -Wextra -Wzero-as-null-pointer-constant -Wno-unknown-pragmas" # Set AR_FLAGS to avoid build warning "ar: `u' modifier ignored since `D' is the default (see `U')" AR_FLAGS='cr'