1
0
mirror of https://github.com/spacebarchat/client.git synced 2024-11-26 04:02:46 +01:00

fix 2 for rich embeds

This commit is contained in:
Puyodead1 2023-09-02 23:28:42 -04:00
parent 90b5b83a63
commit ca8929ea88
No known key found for this signature in database
GPG Key ID: A4FA4FEC0DD353FC
3 changed files with 19 additions and 13 deletions

View File

@ -1,4 +1,4 @@
import { APIAttachment, MessageType } from "@spacebarchat/spacebar-api-types/v9";
import { APIAttachment, APIEmbed, MessageType } from "@spacebarchat/spacebar-api-types/v9";
import { observer } from "mobx-react-lite";
import React from "react";
import Moment from "react-moment";
@ -123,6 +123,10 @@ function Message({ message, isHeader, isSending, isFailed }: Props) {
[contextMenuItems],
);
const renderEmbed = React.useCallback((embed: APIEmbed) => {
return <MessageEmbed embed={embed} contextMenuItems={contextMenuItems} />;
}, []);
// construct the context menu options
// React.useEffect(() => {
// // if the message is queued, we don't need a context menu
@ -194,11 +198,7 @@ function Message({ message, isHeader, isSending, isFailed }: Props) {
{"attachments" in message
? message.attachments.map((attachment) => renderAttachment(attachment))
: null}
{"embeds" in message
? message.embeds.map((embed) => (
<MessageEmbed embed={embed} contextMenuItems={contextMenuItems} />
))
: null}
{"embeds" in message ? message.embeds.map((embed) => renderEmbed(embed)) : null}
</MessageContent>
) : (
<div>

View File

@ -23,7 +23,7 @@ const EmbedContainer = styled.div<{ type: EmbedType }>`
props.type == EmbedType.Link || props.type == EmbedType.Rich ? "auto min-content" : "min-content"};
grid-template-rows: auto;
max-width: 500px;
width: ${(props) => (props.type == EmbedType.Link || props.type == EmbedType.Rich ? undefined : "min-content")};
width: ${(props) => (props.type == EmbedType.Link ? undefined : "min-content")};
border: 1px solid var(--background-tertiary);
`;
@ -67,14 +67,18 @@ const YoutubeEmbed = styled.iframe`
const createEmbedAttachment = (embed: APIEmbed, contextMenuItems: IContextMenuItem[]) => {
const url = new URL(embed.url!);
console.log(embed.image);
const image = embed.thumbnail ?? embed.image;
if (!image) return null;
const fakeAttachment: APIAttachment = {
id: embed.url as string,
filename: url.pathname.split("/").reverse()[0],
size: -1,
width: embed.thumbnail!.width,
height: embed.thumbnail!.height,
proxy_url: embed.thumbnail!.proxy_url!,
url: embed.thumbnail!.url,
width: image.width,
height: image.height,
proxy_url: image.proxy_url!,
url: image.url,
content_type: "image",
};
@ -89,7 +93,7 @@ const createEmbedAttachment = (embed: APIEmbed, contextMenuItems: IContextMenuIt
<MessageAttachment {...props} maxWidth={160} maxHeight={80} />
</EmbedImageLink>
);
} else if (embed.type == EmbedType.Article) {
} else if (embed.type == EmbedType.Article || embed.type == EmbedType.Rich) {
return (
<EmbedImageArticle>
<MessageAttachment {...props} />
@ -106,7 +110,8 @@ export default function MessageEmbed({ embed, contextMenuItems }: EmbedProps) {
const logger = useLogger("MessageEmbed");
// seems like the server sometimes sends thumbnails with 0 width and height, and no urls
const thumbnail = embed.thumbnail && embed.thumbnail.url ? createEmbedAttachment(embed, contextMenuItems) : null;
const image = embed.thumbnail ?? embed.image;
const thumbnail = image && image.url ? createEmbedAttachment(embed, contextMenuItems) : null;
if (embed.type == EmbedType.Image) return thumbnail;

View File

@ -246,6 +246,7 @@ export default class Message {
this.mention_channels = message.mention_channels;
this.attachments = message.attachments;
this.embeds = message.embeds;
console.log(message.embeds.map((embed) => embed.image));
this.reactions = message.reactions;
this.nonce = message.nonce;
this.pinned = message.pinned;