Spacebar/server
1
0
Fork 0
mirror of https://github.com/spacebarchat/server.git synced 2024-11-14 06:32:36 +01:00
Code Issues Releases Activity

While backfilling, message ids must now be valid snowflakes, cannot be in the future, and cannot overwrite existing messages

Browse Source
This commit is contained in:
Madeline 2022-04-24 16:09:38 +10:00
parent ccf4386d70
commit 2e84840213
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
api/src/routes/channels/#channel_id/messages/#message_id/index.ts
View File

@ -16,6 +16,8 @@ import multer from "multer";
import { route } from "@fosscord/api";
import { handleMessage, postHandleMessage } from "@fosscord/api";
import { MessageCreateSchema } from "../index";
import { Snowflake } from "@fosscord/util";
import { HTTPError } from "lambert-server";
const router = Router();
// TODO: message content/embed string length limit
@ -91,6 +93,22 @@ router.put(
var body = req.body as MessageCreateSchema;
const attachments: Attachment[] = [];
// regex to check if message contains anything other than numerals ( also no decimals )
if (!message_id.match(/^\+?\d+$/)) {
throw new HTTPError("Message IDs must be positive integers")
}
const snowflake = Snowflake.deconstruct(message_id)
if (Date.now() < snowflake.timestamp) {
// message is in the future
throw new HTTPError("You cannot backfill messages in the future", 400);
}
const exists = await Message.findOne({ where: { id: message_id, channel_id: channel_id }});
if (exists) {
throw new HTTPError("Cannot backfill to message ID that already exists", 400);
}
if (req.file) {
try {
const file = await uploadFile(`/attachments/${req.params.channel_id}`, req.file);
@ -101,8 +119,6 @@ router.put(
}
const channel = await Channel.findOneOrFail({ where: { id: channel_id }, relations: ["recipients", "recipients.user"] });
// TODO: check the ID is not from the future, to prevent future-faking of channel histories
const embeds = body.embeds || [];
if (body.embed) embeds.push(body.embed);
let message = await handleMessage({
@ -115,11 +131,9 @@ router.put(
channel_id,
attachments,
edited_timestamp: undefined,
timestamp: undefined, // FIXME: calculate timestamp from snowflake
timestamp: new Date(snowflake.timestamp),
});
channel.last_message_id = message.id;
//Fix for the client bug
delete message.member