Spacebar/server
1
0
Fork 0
mirror of https://github.com/spacebarchat/server.git synced 2024-11-06 10:52:31 +01:00
Code Issues Releases Activity

fix(api): always add @everyone in user's roles

Browse Source 
When you add or delete an user's role, you MUST always add "@everyone" role to the roles map
This commit is contained in:
Nobody 2022-03-08 09:18:19 -03:00 committed by Erkin Alp Güney
parent 22467f2596
commit 4a617faf02
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api/src/routes/guilds/#guild_id/members/#member_id/index.ts
View File

@ -28,6 +28,9 @@ router.patch("/", route({ body: "MemberChangeSchema" }), async (req: Request, re
if (body.roles) { if (body.roles) {
permission.hasThrow("MANAGE_ROLES"); permission.hasThrow("MANAGE_ROLES");
const everyone = await Role.findOneOrFail({ guild_id: guild_id, name: "@everyone", position: 0 });
body.roles.push(everyone?.id);
member.roles = body.roles.map((x) => new Role({ id: x })); // foreign key constraint will fail if role doesn't exist member.roles = body.roles.map((x) => new Role({ id: x })); // foreign key constraint will fail if role doesn't exist
} }