Spacebar/server
1
0
Fork 0
mirror of https://github.com/spacebarchat/server.git synced 2024-11-10 04:32:35 +01:00
Code Issues Releases Activity

Remove Member.isInGuildOrFail, as it will always pass ( route permission check )

Browse Source
This commit is contained in:
Madeline 2023-04-11 12:33:59 +10:00
parent b91fca6d74
commit 6a148898a5
No known key found for this signature in database
GPG Key ID: 1958E017C36F2E47
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/api/routes/guilds/#guild_id/roles/#role_id/members.ts
View File

@ -29,11 +29,12 @@ router.patch(
// Payload is JSON containing a list of member_ids, the new list of members to have the role // Payload is JSON containing a list of member_ids, the new list of members to have the role
const { guild_id, role_id } = req.params; const { guild_id, role_id } = req.params;
const { member_ids } = req.body; const { member_ids } = req.body;
await Member.IsInGuildOrFail(req.user_id, guild_id);
const members = await Member.find({ const members = await Member.find({
where: { guild_id }, where: { guild_id },
relations: ["roles"], relations: ["roles"],
}); });
const members_to_add = members.filter((member) => { const members_to_add = members.filter((member) => {
return ( return (
member_ids.includes(member.id) && member_ids.includes(member.id) &&
@ -46,12 +47,15 @@ router.patch(
member.roles.map((role) => role.id).includes(role_id) member.roles.map((role) => role.id).includes(role_id)
); );
}); });
for (const member of members_to_add) { for (const member of members_to_add) {
Member.addRole(member.id, guild_id, role_id); await Member.addRole(member.id, guild_id, role_id);
} }
for (const member of members_to_remove) { for (const member of members_to_remove) {
Member.removeRole(member.id, guild_id, role_id); await Member.removeRole(member.id, guild_id, role_id);
} }
res.sendStatus(204); res.sendStatus(204);
}, },
); );