Spacebar/server
1
0
Fork 0
mirror of https://github.com/spacebarchat/server.git synced 2024-11-06 10:52:31 +01:00
Code Issues Releases Activity

Punitive rate limiting

Browse Source
This commit is contained in:
Erkin Alp Güney 2022-04-24 14:57:26 +03:00 committed by GitHub
parent 7835cb9963
commit c87671d080
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
api/src/middlewares/RateLimit.ts
View File

@ -53,12 +53,12 @@ export default function rateLimit(opts: {
if (opts.GET && ["GET", "OPTIONS", "HEAD"].includes(req.method)) max_hits = opts.GET; if (opts.GET && ["GET", "OPTIONS", "HEAD"].includes(req.method)) max_hits = opts.GET;
else if (opts.MODIFY && ["POST", "DELETE", "PATCH", "PUT"].includes(req.method)) max_hits = opts.MODIFY; else if (opts.MODIFY && ["POST", "DELETE", "PATCH", "PUT"].includes(req.method)) max_hits = opts.MODIFY;
const offender = Cache.get(executor_id + bucket_id); let offender = Cache.get(executor_id + bucket_id);
if (offender) { if (offender) {
const reset = offender.expires_at.getTime(); let reset = offender.expires_at.getTime();
const resetAfterMs = reset - Date.now(); let resetAfterMs = reset - Date.now();
const resetAfterSec = resetAfterMs / 1000; let resetAfterSec = (resetAfterMs + 999) / 1000;
if (resetAfterMs <= 0) { if (resetAfterMs <= 0) {
offender.hits = 0; offender.hits = 0;
@ -70,6 +70,10 @@ export default function rateLimit(opts: {
if (offender.blocked) { if (offender.blocked) {
const global = bucket_id === "global"; const global = bucket_id === "global";
reset = reset + opts.window * 1000; // each block violation pushes the expiry one full window further
offender.expires_at += opts.window * 1000;
resetAfterMs = reset - Date.now();
resetAfterSec = (resetAfterMs + 999) / 1000;
console.log("blocked bucket: " + bucket_id, { resetAfterMs }); console.log("blocked bucket: " + bucket_id, { resetAfterMs });
return ( return (