From ef2d739965a6887021b796140c0c7543b1587d63 Mon Sep 17 00:00:00 2001
From: Madeline <46743919+MaddyUnderStars@users.noreply.github.com>
Date: Sat, 5 Nov 2022 21:59:12 +1100
Subject: [PATCH] Fix 404 handler

---
 src/api/Server.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/api/Server.ts b/src/api/Server.ts
index 6c4b5652..c7e53d70 100644
--- a/src/api/Server.ts
+++ b/src/api/Server.ts
@@ -74,15 +74,16 @@ export class FosscordServer extends Server {
 			path.join(__dirname, "routes", "/"),
 		);
 
+		// 404 is not an error in express, so this should not be an error middleware
+		// this is a fine place to put the 404 handler because its after we register the routes
+		// and since its not an error middleware, our error handler below still works.
 		api.use(
 			"*",
-			(error: any, req: Request, res: Response, next: NextFunction) => {
-				if (error) return next(error);
+			(req: Request, res: Response, next: NextFunction) => {
 				res.status(404).json({
 					message: "404 endpoint not found",
 					code: 0,
 				});
-				next();
 			},
 		);