1
0
mirror of https://github.com/spacebarchat/server.git synced 2024-11-25 11:43:07 +01:00

Fix linter warnings in connections

This commit is contained in:
Puyodead1 2023-08-06 23:15:35 -04:00
parent 5c8359ec45
commit fe4acbfee5
No known key found for this signature in database
GPG Key ID: A4FA4FEC0DD353FC
13 changed files with 178 additions and 95 deletions

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { BattleNetSettings } from "./BattleNetSettings"; import { BattleNetSettings } from "./BattleNetSettings";
@ -47,17 +47,21 @@ export default class BattleNetConnection extends Connection {
settings: BattleNetSettings = new BattleNetSettings(); settings: BattleNetSettings = new BattleNetSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings =
this.id, ConnectionLoader.getConnectionConfig<BattleNetSettings>(
this.settings, this.id,
) as BattleNetSettings; this.settings,
);
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
url.searchParams.append("state", state); url.searchParams.append("state", state);
@ -85,8 +89,8 @@ export default class BattleNetConnection extends Connection {
new URLSearchParams({ new URLSearchParams({
grant_type: "authorization_code", grant_type: "authorization_code",
code: code, code: code,
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
client_secret: this.settings.clientSecret!, client_secret: this.settings.clientSecret as string,
redirect_uri: this.getRedirectUri(), redirect_uri: this.getRedirectUri(),
}), }),
) )
@ -115,8 +119,11 @@ export default class BattleNetConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.id.toString()); const exists = await this.hasConnection(userId, userInfo.id.toString());

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { DiscordSettings } from "./DiscordSettings"; import { DiscordSettings } from "./DiscordSettings";
@ -43,10 +43,13 @@ export default class DiscordConnection extends Connection {
settings: DiscordSettings = new DiscordSettings(); settings: DiscordSettings = new DiscordSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<DiscordSettings>(
this.id, this.id,
this.settings, this.settings,
) as DiscordSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
@ -54,7 +57,7 @@ export default class DiscordConnection extends Connection {
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("state", state); url.searchParams.append("state", state);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
// controls whether, on repeated authorizations, the consent screen is shown // controls whether, on repeated authorizations, the consent screen is shown
@ -82,8 +85,8 @@ export default class DiscordConnection extends Connection {
}) })
.body( .body(
new URLSearchParams({ new URLSearchParams({
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
client_secret: this.settings.clientSecret!, client_secret: this.settings.clientSecret as string,
grant_type: "authorization_code", grant_type: "authorization_code",
code: code, code: code,
redirect_uri: this.getRedirectUri(), redirect_uri: this.getRedirectUri(),
@ -114,8 +117,11 @@ export default class DiscordConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.id); const exists = await this.hasConnection(userId, userInfo.id);

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { EpicGamesSettings } from "./EpicGamesSettings"; import { EpicGamesSettings } from "./EpicGamesSettings";
@ -53,17 +53,21 @@ export default class EpicGamesConnection extends Connection {
settings: EpicGamesSettings = new EpicGamesSettings(); settings: EpicGamesSettings = new EpicGamesSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings =
this.id, ConnectionLoader.getConnectionConfig<EpicGamesSettings>(
this.settings, this.id,
) as EpicGamesSettings; this.settings,
);
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
@ -127,8 +131,11 @@ export default class EpicGamesConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo[0].accountId); const exists = await this.hasConnection(userId, userInfo[0].accountId);

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { FacebookSettings } from "./FacebookSettings"; import { FacebookSettings } from "./FacebookSettings";
@ -52,17 +52,20 @@ export default class FacebookConnection extends Connection {
settings: FacebookSettings = new FacebookSettings(); settings: FacebookSettings = new FacebookSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<FacebookSettings>(
this.id, this.id,
this.settings, this.settings,
) as FacebookSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("state", state); url.searchParams.append("state", state);
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
@ -73,8 +76,11 @@ export default class FacebookConnection extends Connection {
getTokenUrl(code: string): string { getTokenUrl(code: string): string {
const url = new URL(this.tokenUrl); const url = new URL(this.tokenUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("client_secret", this.settings.clientSecret!); url.searchParams.append(
"client_secret",
this.settings.clientSecret as string,
);
url.searchParams.append("code", code); url.searchParams.append("code", code);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
return url.toString(); return url.toString();
@ -118,8 +124,11 @@ export default class FacebookConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.id); const exists = await this.hasConnection(userId, userInfo.id);

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { GitHubSettings } from "./GitHubSettings"; import { GitHubSettings } from "./GitHubSettings";
@ -42,17 +42,20 @@ export default class GitHubConnection extends Connection {
settings: GitHubSettings = new GitHubSettings(); settings: GitHubSettings = new GitHubSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<GitHubSettings>(
this.id, this.id,
this.settings, this.settings,
) as GitHubSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
url.searchParams.append("state", state); url.searchParams.append("state", state);
@ -61,8 +64,11 @@ export default class GitHubConnection extends Connection {
getTokenUrl(code: string): string { getTokenUrl(code: string): string {
const url = new URL(this.tokenUrl); const url = new URL(this.tokenUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("client_secret", this.settings.clientSecret!); url.searchParams.append(
"client_secret",
this.settings.clientSecret as string,
);
url.searchParams.append("code", code); url.searchParams.append("code", code);
return url.toString(); return url.toString();
} }
@ -105,8 +111,11 @@ export default class GitHubConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.id.toString()); const exists = await this.hasConnection(userId, userInfo.id.toString());

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { RedditSettings } from "./RedditSettings"; import { RedditSettings } from "./RedditSettings";
@ -54,17 +54,20 @@ export default class RedditConnection extends Connection {
settings: RedditSettings = new RedditSettings(); settings: RedditSettings = new RedditSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<RedditSettings>(
this.id, this.id,
this.settings, this.settings,
) as RedditSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
@ -124,8 +127,11 @@ export default class RedditConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.id.toString()); const exists = await this.hasConnection(userId, userInfo.id.toString());

View File

@ -63,17 +63,20 @@ export default class SpotifyConnection extends RefreshableConnection {
* So to prevent spamming the spotify api we disable the ability to refresh. * So to prevent spamming the spotify api we disable the ability to refresh.
*/ */
this.refreshEnabled = false; this.refreshEnabled = false;
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<SpotifySettings>(
this.id, this.id,
this.settings, this.settings,
) as SpotifySettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
@ -98,7 +101,9 @@ export default class SpotifyConnection extends RefreshableConnection {
Accept: "application/json", Accept: "application/json",
"Content-Type": "application/x-www-form-urlencoded", "Content-Type": "application/x-www-form-urlencoded",
Authorization: `Basic ${Buffer.from( Authorization: `Basic ${Buffer.from(
`${this.settings.clientId!}:${this.settings.clientSecret!}`, `${this.settings.clientId as string}:${
this.settings.clientSecret as string
}`,
).toString("base64")}`, ).toString("base64")}`,
}) })
.body( .body(
@ -129,7 +134,9 @@ export default class SpotifyConnection extends RefreshableConnection {
Accept: "application/json", Accept: "application/json",
"Content-Type": "application/x-www-form-urlencoded", "Content-Type": "application/x-www-form-urlencoded",
Authorization: `Basic ${Buffer.from( Authorization: `Basic ${Buffer.from(
`${this.settings.clientId!}:${this.settings.clientSecret!}`, `${this.settings.clientId as string}:${
this.settings.clientSecret as string
}`,
).toString("base64")}`, ).toString("base64")}`,
}) })
.body( .body(
@ -169,8 +176,11 @@ export default class SpotifyConnection extends RefreshableConnection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.id); const exists = await this.hasConnection(userId, userInfo.id);

View File

@ -55,17 +55,20 @@ export default class TwitchConnection extends RefreshableConnection {
settings: TwitchSettings = new TwitchSettings(); settings: TwitchSettings = new TwitchSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<TwitchSettings>(
this.id, this.id,
this.settings, this.settings,
) as TwitchSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
@ -94,8 +97,8 @@ export default class TwitchConnection extends RefreshableConnection {
new URLSearchParams({ new URLSearchParams({
grant_type: "authorization_code", grant_type: "authorization_code",
code: code, code: code,
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
client_secret: this.settings.clientSecret!, client_secret: this.settings.clientSecret as string,
redirect_uri: this.getRedirectUri(), redirect_uri: this.getRedirectUri(),
}), }),
) )
@ -124,8 +127,8 @@ export default class TwitchConnection extends RefreshableConnection {
.body( .body(
new URLSearchParams({ new URLSearchParams({
grant_type: "refresh_token", grant_type: "refresh_token",
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
client_secret: this.settings.clientSecret!, client_secret: this.settings.clientSecret as string,
refresh_token: refresh_token, refresh_token: refresh_token,
}), }),
) )
@ -148,7 +151,7 @@ export default class TwitchConnection extends RefreshableConnection {
return wretch(url.toString()) return wretch(url.toString())
.headers({ .headers({
Authorization: `Bearer ${token}`, Authorization: `Bearer ${token}`,
"Client-Id": this.settings.clientId!, "Client-Id": this.settings.clientId as string,
}) })
.get() .get()
.json<TwitchConnectionUserResponse>() .json<TwitchConnectionUserResponse>()
@ -161,8 +164,11 @@ export default class TwitchConnection extends RefreshableConnection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.data[0].id); const exists = await this.hasConnection(userId, userInfo.data[0].id);

View File

@ -55,17 +55,20 @@ export default class TwitterConnection extends RefreshableConnection {
settings: TwitterSettings = new TwitterSettings(); settings: TwitterSettings = new TwitterSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<TwitterSettings>(
this.id, this.id,
this.settings, this.settings,
) as TwitterSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
@ -92,14 +95,16 @@ export default class TwitterConnection extends RefreshableConnection {
Accept: "application/json", Accept: "application/json",
"Content-Type": "application/x-www-form-urlencoded", "Content-Type": "application/x-www-form-urlencoded",
Authorization: `Basic ${Buffer.from( Authorization: `Basic ${Buffer.from(
`${this.settings.clientId!}:${this.settings.clientSecret!}`, `${this.settings.clientId as string}:${
this.settings.clientSecret as string
}`,
).toString("base64")}`, ).toString("base64")}`,
}) })
.body( .body(
new URLSearchParams({ new URLSearchParams({
grant_type: "authorization_code", grant_type: "authorization_code",
code: code, code: code,
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
redirect_uri: this.getRedirectUri(), redirect_uri: this.getRedirectUri(),
code_verifier: "challenge", // TODO: properly use PKCE challenge code_verifier: "challenge", // TODO: properly use PKCE challenge
}), }),
@ -126,14 +131,16 @@ export default class TwitterConnection extends RefreshableConnection {
Accept: "application/json", Accept: "application/json",
"Content-Type": "application/x-www-form-urlencoded", "Content-Type": "application/x-www-form-urlencoded",
Authorization: `Basic ${Buffer.from( Authorization: `Basic ${Buffer.from(
`${this.settings.clientId!}:${this.settings.clientSecret!}`, `${this.settings.clientId as string}:${
this.settings.clientSecret as string
}`,
).toString("base64")}`, ).toString("base64")}`,
}) })
.body( .body(
new URLSearchParams({ new URLSearchParams({
grant_type: "refresh_token", grant_type: "refresh_token",
refresh_token, refresh_token,
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
redirect_uri: this.getRedirectUri(), redirect_uri: this.getRedirectUri(),
code_verifier: "challenge", // TODO: properly use PKCE challenge code_verifier: "challenge", // TODO: properly use PKCE challenge
}), }),
@ -163,8 +170,11 @@ export default class TwitterConnection extends RefreshableConnection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.data.id); const exists = await this.hasConnection(userId, userInfo.data.id);

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { XboxSettings } from "./XboxSettings"; import { XboxSettings } from "./XboxSettings";
@ -62,17 +62,20 @@ export default class XboxConnection extends Connection {
settings: XboxSettings = new XboxSettings(); settings: XboxSettings = new XboxSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<XboxSettings>(
this.id, this.id,
this.settings, this.settings,
) as XboxSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
@ -124,14 +127,16 @@ export default class XboxConnection extends Connection {
Accept: "application/json", Accept: "application/json",
"Content-Type": "application/x-www-form-urlencoded", "Content-Type": "application/x-www-form-urlencoded",
Authorization: `Basic ${Buffer.from( Authorization: `Basic ${Buffer.from(
`${this.settings.clientId!}:${this.settings.clientSecret!}`, `${this.settings.clientId as string}:${
this.settings.clientSecret as string
}`,
).toString("base64")}`, ).toString("base64")}`,
}) })
.body( .body(
new URLSearchParams({ new URLSearchParams({
grant_type: "authorization_code", grant_type: "authorization_code",
code: code, code: code,
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
redirect_uri: this.getRedirectUri(), redirect_uri: this.getRedirectUri(),
scope: this.scopes.join(" "), scope: this.scopes.join(" "),
}), }),
@ -174,8 +179,11 @@ export default class XboxConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userToken = await this.getUserToken(tokenData.access_token); const userToken = await this.getUserToken(tokenData.access_token);
const userInfo = await this.getUser(userToken); const userInfo = await this.getUser(userToken);

View File

@ -19,10 +19,10 @@
import { import {
ConnectedAccount, ConnectedAccount,
ConnectedAccountCommonOAuthTokenResponse, ConnectedAccountCommonOAuthTokenResponse,
Connection,
ConnectionCallbackSchema, ConnectionCallbackSchema,
ConnectionLoader, ConnectionLoader,
DiscordApiErrors, DiscordApiErrors,
Connection,
} from "@spacebar/util"; } from "@spacebar/util";
import wretch from "wretch"; import wretch from "wretch";
import { YoutubeSettings } from "./YoutubeSettings"; import { YoutubeSettings } from "./YoutubeSettings";
@ -62,17 +62,20 @@ export default class YoutubeConnection extends Connection {
settings: YoutubeSettings = new YoutubeSettings(); settings: YoutubeSettings = new YoutubeSettings();
init(): void { init(): void {
this.settings = ConnectionLoader.getConnectionConfig( const settings = ConnectionLoader.getConnectionConfig<YoutubeSettings>(
this.id, this.id,
this.settings, this.settings,
) as YoutubeSettings; );
if (settings.enabled && (!settings.clientId || !settings.clientSecret))
throw new Error(`Invalid settings for connection ${this.id}`);
} }
getAuthorizationUrl(userId: string): string { getAuthorizationUrl(userId: string): string {
const state = this.createState(userId); const state = this.createState(userId);
const url = new URL(this.authorizeUrl); const url = new URL(this.authorizeUrl);
url.searchParams.append("client_id", this.settings.clientId!); url.searchParams.append("client_id", this.settings.clientId as string);
url.searchParams.append("redirect_uri", this.getRedirectUri()); url.searchParams.append("redirect_uri", this.getRedirectUri());
url.searchParams.append("response_type", "code"); url.searchParams.append("response_type", "code");
url.searchParams.append("scope", this.scopes.join(" ")); url.searchParams.append("scope", this.scopes.join(" "));
@ -101,8 +104,8 @@ export default class YoutubeConnection extends Connection {
new URLSearchParams({ new URLSearchParams({
grant_type: "authorization_code", grant_type: "authorization_code",
code: code, code: code,
client_id: this.settings.clientId!, client_id: this.settings.clientId as string,
client_secret: this.settings.clientSecret!, client_secret: this.settings.clientSecret as string,
redirect_uri: this.getRedirectUri(), redirect_uri: this.getRedirectUri(),
}), }),
) )
@ -131,8 +134,11 @@ export default class YoutubeConnection extends Connection {
async handleCallback( async handleCallback(
params: ConnectionCallbackSchema, params: ConnectionCallbackSchema,
): Promise<ConnectedAccount | null> { ): Promise<ConnectedAccount | null> {
const userId = this.getUserId(params.state); const { state, code } = params;
const tokenData = await this.exchangeCode(params.state, params.code!); if (!code) throw new Error("No code provided");
const userId = this.getUserId(state);
const tokenData = await this.exchangeCode(state, code);
const userInfo = await this.getUser(tokenData.access_token); const userInfo = await this.getUser(tokenData.access_token);
const exists = await this.hasConnection(userId, userInfo.items[0].id); const exists = await this.hasConnection(userId, userInfo.items[0].id);

View File

@ -16,9 +16,9 @@
along with this program. If not, see <https://www.gnu.org/licenses/>. along with this program. If not, see <https://www.gnu.org/licenses/>.
*/ */
import { Connection } from "@spacebar/util";
import fs from "fs"; import fs from "fs";
import path from "path"; import path from "path";
import { Connection } from "@spacebar/util";
import { ConnectionConfig } from "./ConnectionConfig"; import { ConnectionConfig } from "./ConnectionConfig";
import { ConnectionStore } from "./ConnectionStore"; import { ConnectionStore } from "./ConnectionStore";
@ -48,8 +48,7 @@ export class ConnectionLoader {
}); });
} }
// eslint-disable-next-line @typescript-eslint/no-explicit-any public static getConnectionConfig<T>(id: string, defaults?: unknown): T {
public static getConnectionConfig(id: string, defaults?: any): any {
let cfg = ConnectionConfig.get()[id]; let cfg = ConnectionConfig.get()[id];
if (defaults) { if (defaults) {
if (cfg) cfg = Object.assign({}, defaults, cfg); if (cfg) cfg = Object.assign({}, defaults, cfg);
@ -70,8 +69,7 @@ export class ConnectionLoader {
public static async setConnectionConfig( public static async setConnectionConfig(
id: string, id: string,
// eslint-disable-next-line @typescript-eslint/no-explicit-any config: Partial<unknown>,
config: Partial<any>,
): Promise<void> { ): Promise<void> {
if (!config) if (!config)
console.warn(`[Connections/WARN] ${id} tried to set config=null!`); console.warn(`[Connections/WARN] ${id} tried to set config=null!`);

View File

@ -25,6 +25,7 @@ import { Connection } from "./Connection";
*/ */
export abstract class RefreshableConnection extends Connection { export abstract class RefreshableConnection extends Connection {
refreshEnabled = true; refreshEnabled = true;
/** /**
* Refreshes the token for a connected account. * Refreshes the token for a connected account.
* @param connectedAccount The connected account to refresh * @param connectedAccount The connected account to refresh